From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5
Date: Mon, 30 Jan 2017 10:03:07 +0100 [thread overview]
Message-ID: <20170130090307.mmeab5ybfxaeicq2@lukather> (raw)
In-Reply-To: <20170129023331.62106-4-icenowy-ymACFijhrKM@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]
Hi,
On Sun, Jan 29, 2017 at 10:33:24AM +0800, Icenowy Zheng wrote:
> As the CCU in the Allwinner H5 SoC is very similar to the one in H3,
> rename the H3 driver to sunxi-h3-h5 so that it can be extended with H5
> support.
>
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> ---
> The original PATCH v2 3/9 is splited into two patches in v3, this one renames
> the H3 driver to h3-h5, and the next one finally add H5 support to it.
>
> drivers/clk/sunxi-ng/Kconfig | 4 +-
> drivers/clk/sunxi-ng/Makefile | 2 +-
> .../sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} | 42 +++---
> .../sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} | 10 +-
> include/dt-bindings/clock/sun8i-h3-ccu.h | 146 +--------------------
> include/dt-bindings/clock/sunxi-h3-h5-ccu.h | 145 ++++++++++++++++++++
> include/dt-bindings/reset/sun8i-h3-ccu.h | 104 +--------------
> include/dt-bindings/reset/sunxi-h3-h5-ccu.h | 103 +++++++++++++++
> 8 files changed, 282 insertions(+), 274 deletions(-)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} (96%)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} (88%)
> mode change 100644 => 120000 include/dt-bindings/clock/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/clock/sunxi-h3-h5-ccu.h
> mode change 100644 => 120000 include/dt-bindings/reset/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/reset/sunxi-h3-h5-ccu.h
Please generate your patches with -M
> -static void __init sun8i_h3_ccu_setup(struct device_node *node)
> +static void __init sunxi_h3_h5_ccu_init(struct device_node *node,
> + const struct sunxi_ccu_desc *desc)
> {
The indentation should be on the opening parenthesis.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Vinod Koul <vinod.koul@intel.com>,
Andre Przywara <andre.przywara@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
Jaroslav Kysela <perex@perex.cz>,
linux-gpio@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Mark Brown <broonie@kernel.org>,
dmaengine@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5
Date: Mon, 30 Jan 2017 10:03:07 +0100 [thread overview]
Message-ID: <20170130090307.mmeab5ybfxaeicq2@lukather> (raw)
In-Reply-To: <20170129023331.62106-4-icenowy@aosc.xyz>
[-- Attachment #1.1: Type: text/plain, Size: 1922 bytes --]
Hi,
On Sun, Jan 29, 2017 at 10:33:24AM +0800, Icenowy Zheng wrote:
> As the CCU in the Allwinner H5 SoC is very similar to the one in H3,
> rename the H3 driver to sunxi-h3-h5 so that it can be extended with H5
> support.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> The original PATCH v2 3/9 is splited into two patches in v3, this one renames
> the H3 driver to h3-h5, and the next one finally add H5 support to it.
>
> drivers/clk/sunxi-ng/Kconfig | 4 +-
> drivers/clk/sunxi-ng/Makefile | 2 +-
> .../sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} | 42 +++---
> .../sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} | 10 +-
> include/dt-bindings/clock/sun8i-h3-ccu.h | 146 +--------------------
> include/dt-bindings/clock/sunxi-h3-h5-ccu.h | 145 ++++++++++++++++++++
> include/dt-bindings/reset/sun8i-h3-ccu.h | 104 +--------------
> include/dt-bindings/reset/sunxi-h3-h5-ccu.h | 103 +++++++++++++++
> 8 files changed, 282 insertions(+), 274 deletions(-)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} (96%)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} (88%)
> mode change 100644 => 120000 include/dt-bindings/clock/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/clock/sunxi-h3-h5-ccu.h
> mode change 100644 => 120000 include/dt-bindings/reset/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/reset/sunxi-h3-h5-ccu.h
Please generate your patches with -M
> -static void __init sun8i_h3_ccu_setup(struct device_node *node)
> +static void __init sunxi_h3_h5_ccu_init(struct device_node *node,
> + const struct sunxi_ccu_desc *desc)
> {
The indentation should be on the opening parenthesis.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5
Date: Mon, 30 Jan 2017 10:03:07 +0100 [thread overview]
Message-ID: <20170130090307.mmeab5ybfxaeicq2@lukather> (raw)
In-Reply-To: <20170129023331.62106-4-icenowy@aosc.xyz>
Hi,
On Sun, Jan 29, 2017 at 10:33:24AM +0800, Icenowy Zheng wrote:
> As the CCU in the Allwinner H5 SoC is very similar to the one in H3,
> rename the H3 driver to sunxi-h3-h5 so that it can be extended with H5
> support.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> The original PATCH v2 3/9 is splited into two patches in v3, this one renames
> the H3 driver to h3-h5, and the next one finally add H5 support to it.
>
> drivers/clk/sunxi-ng/Kconfig | 4 +-
> drivers/clk/sunxi-ng/Makefile | 2 +-
> .../sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} | 42 +++---
> .../sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} | 10 +-
> include/dt-bindings/clock/sun8i-h3-ccu.h | 146 +--------------------
> include/dt-bindings/clock/sunxi-h3-h5-ccu.h | 145 ++++++++++++++++++++
> include/dt-bindings/reset/sun8i-h3-ccu.h | 104 +--------------
> include/dt-bindings/reset/sunxi-h3-h5-ccu.h | 103 +++++++++++++++
> 8 files changed, 282 insertions(+), 274 deletions(-)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} (96%)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} (88%)
> mode change 100644 => 120000 include/dt-bindings/clock/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/clock/sunxi-h3-h5-ccu.h
> mode change 100644 => 120000 include/dt-bindings/reset/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/reset/sunxi-h3-h5-ccu.h
Please generate your patches with -M
> -static void __init sun8i_h3_ccu_setup(struct device_node *node)
> +static void __init sunxi_h3_h5_ccu_init(struct device_node *node,
> + const struct sunxi_ccu_desc *desc)
> {
The indentation should be on the opening parenthesis.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170130/c21a3680/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Chen-Yu Tsai <wens@csie.org>,
Linus Walleij <linus.walleij@linaro.org>,
Vinod Koul <vinod.koul@intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Andre Przywara <andre.przywara@arm.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
dmaengine@vger.kernel.org, alsa-devel@alsa-project.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5
Date: Mon, 30 Jan 2017 10:03:07 +0100 [thread overview]
Message-ID: <20170130090307.mmeab5ybfxaeicq2@lukather> (raw)
In-Reply-To: <20170129023331.62106-4-icenowy@aosc.xyz>
[-- Attachment #1: Type: text/plain, Size: 1922 bytes --]
Hi,
On Sun, Jan 29, 2017 at 10:33:24AM +0800, Icenowy Zheng wrote:
> As the CCU in the Allwinner H5 SoC is very similar to the one in H3,
> rename the H3 driver to sunxi-h3-h5 so that it can be extended with H5
> support.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> The original PATCH v2 3/9 is splited into two patches in v3, this one renames
> the H3 driver to h3-h5, and the next one finally add H5 support to it.
>
> drivers/clk/sunxi-ng/Kconfig | 4 +-
> drivers/clk/sunxi-ng/Makefile | 2 +-
> .../sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} | 42 +++---
> .../sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} | 10 +-
> include/dt-bindings/clock/sun8i-h3-ccu.h | 146 +--------------------
> include/dt-bindings/clock/sunxi-h3-h5-ccu.h | 145 ++++++++++++++++++++
> include/dt-bindings/reset/sun8i-h3-ccu.h | 104 +--------------
> include/dt-bindings/reset/sunxi-h3-h5-ccu.h | 103 +++++++++++++++
> 8 files changed, 282 insertions(+), 274 deletions(-)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} (96%)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} (88%)
> mode change 100644 => 120000 include/dt-bindings/clock/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/clock/sunxi-h3-h5-ccu.h
> mode change 100644 => 120000 include/dt-bindings/reset/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/reset/sunxi-h3-h5-ccu.h
Please generate your patches with -M
> -static void __init sun8i_h3_ccu_setup(struct device_node *node)
> +static void __init sunxi_h3_h5_ccu_init(struct device_node *node,
> + const struct sunxi_ccu_desc *desc)
> {
The indentation should be on the opening parenthesis.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-01-30 9:03 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 2:33 [PATCH v3 00/10] Allwinner H5 and Orange Pi PC2 support Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
[not found] ` <20170129023331.62106-1-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-29 2:33 ` [PATCH v3 01/10] drivers: pinctrl: add driver for Allwinner H5 SoC Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
[not found] ` <20170129023331.62106-2-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-30 15:23 ` Linus Walleij
2017-01-30 15:23 ` Linus Walleij
2017-01-30 15:23 ` Linus Walleij
2017-01-30 15:23 ` Linus Walleij
2017-01-29 2:33 ` [PATCH v3 02/10] arm64: allwinner: Kconfig: add essential pinctrl driver for H5 Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5 Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
[not found] ` <20170129023331.62106-4-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-30 9:03 ` Maxime Ripard [this message]
2017-01-30 9:03 ` Maxime Ripard
2017-01-30 9:03 ` Maxime Ripard
2017-01-30 9:03 ` Maxime Ripard
2017-01-29 2:33 ` [PATCH v3 04/10] clk: sunxi-ng: add support for Allwinner H5 SoC Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
[not found] ` <20170129023331.62106-5-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-30 9:04 ` Maxime Ripard
2017-01-30 9:04 ` Maxime Ripard
2017-01-30 9:04 ` Maxime Ripard
2017-01-30 9:04 ` Maxime Ripard
2017-01-29 2:33 ` [PATCH v3 05/10] arm: dts: sun8i: split Allwinner H3 .dtsi Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
[not found] ` <20170129023331.62106-6-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-30 1:42 ` André Przywara
2017-01-30 1:42 ` André Przywara
2017-01-30 1:42 ` André Przywara
[not found] ` <2b8672bc-58ae-66a9-46d7-c7f3c5825a9d-5wv7dgnIgG8@public.gmane.org>
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:06 ` Maxime Ripard
2017-01-30 9:06 ` Maxime Ripard
2017-01-30 9:06 ` Maxime Ripard
2017-01-30 9:06 ` Maxime Ripard
2017-01-29 2:33 ` [PATCH v3 06/10] clk: sunxi-ng: remove transitional headers for dt-bindings Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
[not found] ` <20170129023331.62106-7-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:09 ` Maxime Ripard
2017-01-30 9:09 ` Maxime Ripard
2017-01-29 2:33 ` [PATCH v3 07/10] arm64: dts: allwinner: add Allwinner H5 .dtsi Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` [PATCH v3 08/10] dmaengine: sun6i: allow build on ARM64 platforms (sun50i) Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
[not found] ` <20170129023331.62106-9-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-30 16:42 ` Vinod Koul
2017-01-30 16:42 ` Vinod Koul
2017-01-30 16:42 ` Vinod Koul
2017-01-30 18:23 ` Icenowy Zheng
2017-01-30 18:23 ` Icenowy Zheng
[not found] ` <3729521485800635-hGpGylqI9Klxpj1cXAZ9Bg@public.gmane.org>
2017-01-31 3:32 ` Vinod Koul
2017-01-31 3:32 ` Vinod Koul
2017-01-31 3:32 ` Vinod Koul
2017-02-02 15:50 ` Icenowy Zheng
2017-02-02 15:50 ` Icenowy Zheng
2017-02-05 7:19 ` Vinod Koul
2017-02-05 7:19 ` Vinod Koul
2017-02-05 7:19 ` Vinod Koul
2017-01-29 2:33 ` [PATCH v3 09/10] ASoC: sunxi: allow the analog codec driver to be built on ARM64 Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` [PATCH v3 10/10] arm64: dts: sunxi: add support for the Orange Pi PC 2 board Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
2017-01-29 2:33 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130090307.mmeab5ybfxaeicq2@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=andre.przywara-5wv7dgnIgG8@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=icenowy-ymACFijhrKM@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.