* [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode
@ 2017-01-30 14:50 David Hildenbrand
2017-01-30 14:51 ` Alexander Graf
2017-01-30 15:09 ` Stefan Weil
0 siblings, 2 replies; 6+ messages in thread
From: David Hildenbrand @ 2017-01-30 14:50 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, rth, agraf, sw, borntraeger, cornelia.huck,
riku.voipio, david
"any" does not exist, therefore resulting in a misleading error message.
Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
linux-user/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/main.c b/linux-user/main.c
index 3004958..e588f58 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -4322,6 +4322,8 @@ int main(int argc, char **argv, char **envp)
# endif
#elif defined TARGET_SH4
cpu_model = TYPE_SH7785_CPU;
+#elif defined TARGET_S390X
+ cpu_model = "qemu";
#else
cpu_model = "any";
#endif
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode
2017-01-30 14:50 [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode David Hildenbrand
@ 2017-01-30 14:51 ` Alexander Graf
2017-01-30 15:09 ` Stefan Weil
1 sibling, 0 replies; 6+ messages in thread
From: Alexander Graf @ 2017-01-30 14:51 UTC (permalink / raw)
To: David Hildenbrand, qemu-devel
Cc: peter.maydell, rth, sw, borntraeger, cornelia.huck, riku.voipio
On 01/30/2017 03:50 PM, David Hildenbrand wrote:
> "any" does not exist, therefore resulting in a misleading error message.
>
> Reported-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: David Hildenbrand <david@redhat.com>
I think we support more instructions in user space than in kernel space,
but for now this change is good as it definitely unbreaks user emulation.
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
> ---
> linux-user/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 3004958..e588f58 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -4322,6 +4322,8 @@ int main(int argc, char **argv, char **envp)
> # endif
> #elif defined TARGET_SH4
> cpu_model = TYPE_SH7785_CPU;
> +#elif defined TARGET_S390X
> + cpu_model = "qemu";
> #else
> cpu_model = "any";
> #endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode
2017-01-30 14:50 [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode David Hildenbrand
2017-01-30 14:51 ` Alexander Graf
@ 2017-01-30 15:09 ` Stefan Weil
2017-01-30 15:11 ` Peter Maydell
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2017-01-30 15:09 UTC (permalink / raw)
To: David Hildenbrand, qemu-devel
Cc: peter.maydell, rth, agraf, borntraeger, cornelia.huck,
riku.voipio, pkg-qemu-devel
Am 30.01.2017 um 15:50 schrieb David Hildenbrand:
> "any" does not exist, therefore resulting in a misleading error message.
>
> Reported-by: Stefan Weil <sw@weilnetz.de>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> linux-user/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 3004958..e588f58 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -4322,6 +4322,8 @@ int main(int argc, char **argv, char **envp)
> # endif
> #elif defined TARGET_SH4
> cpu_model = TYPE_SH7785_CPU;
> +#elif defined TARGET_S390X
> + cpu_model = "qemu";
> #else
> cpu_model = "any";
> #endif
Thanks.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
This fix is also needed for Debian's QEMU user emulation.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode
2017-01-30 15:09 ` Stefan Weil
@ 2017-01-30 15:11 ` Peter Maydell
2017-01-30 15:23 ` Stefan Weil
0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2017-01-30 15:11 UTC (permalink / raw)
To: Stefan Weil
Cc: David Hildenbrand, QEMU Developers, Richard Henderson,
Alexander Graf, Christian Borntraeger, Cornelia Huck, Riku Voipio,
pkg-qemu-devel
On 30 January 2017 at 15:09, Stefan Weil <sw@weilnetz.de> wrote:
> Am 30.01.2017 um 15:50 schrieb David Hildenbrand:
>> "any" does not exist, therefore resulting in a misleading error message.
>>
>> Reported-by: Stefan Weil <sw@weilnetz.de>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>> linux-user/main.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/linux-user/main.c b/linux-user/main.c
>> index 3004958..e588f58 100644
>> --- a/linux-user/main.c
>> +++ b/linux-user/main.c
>> @@ -4322,6 +4322,8 @@ int main(int argc, char **argv, char **envp)
>> # endif
>> #elif defined TARGET_SH4
>> cpu_model = TYPE_SH7785_CPU;
>> +#elif defined TARGET_S390X
>> + cpu_model = "qemu";
>> #else
>> cpu_model = "any";
>> #endif
>
>
> Thanks.
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
> This fix is also needed for Debian's QEMU user emulation.
Does it merit a cc: qemu-stable ?
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode
2017-01-30 15:11 ` Peter Maydell
@ 2017-01-30 15:23 ` Stefan Weil
2017-02-01 8:04 ` Christian Borntraeger
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2017-01-30 15:23 UTC (permalink / raw)
To: Peter Maydell
Cc: David Hildenbrand, QEMU Developers, Richard Henderson,
Alexander Graf, Christian Borntraeger, Cornelia Huck, Riku Voipio,
pkg-qemu-devel, qemu-stable
Am 30.01.2017 um 16:11 schrieb Peter Maydell:
> On 30 January 2017 at 15:09, Stefan Weil <sw@weilnetz.de> wrote:
>> Am 30.01.2017 um 15:50 schrieb David Hildenbrand:
>>> "any" does not exist, therefore resulting in a misleading error message.
>>>
>>> Reported-by: Stefan Weil <sw@weilnetz.de>
>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>> ---
>>> linux-user/main.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/linux-user/main.c b/linux-user/main.c
>>> index 3004958..e588f58 100644
>>> --- a/linux-user/main.c
>>> +++ b/linux-user/main.c
>>> @@ -4322,6 +4322,8 @@ int main(int argc, char **argv, char **envp)
>>> # endif
>>> #elif defined TARGET_SH4
>>> cpu_model = TYPE_SH7785_CPU;
>>> +#elif defined TARGET_S390X
>>> + cpu_model = "qemu";
>>> #else
>>> cpu_model = "any";
>>> #endif
>>
>> Thanks.
>>
>> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>>
>> This fix is also needed for Debian's QEMU user emulation.
> Does it merit a cc: qemu-stable ?
>
> thanks
> -- PMM
Yes, of course. Thanks for the reminder - I added that list now as cc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode
2017-01-30 15:23 ` Stefan Weil
@ 2017-02-01 8:04 ` Christian Borntraeger
0 siblings, 0 replies; 6+ messages in thread
From: Christian Borntraeger @ 2017-02-01 8:04 UTC (permalink / raw)
To: Stefan Weil, Peter Maydell
Cc: David Hildenbrand, QEMU Developers, Richard Henderson,
Alexander Graf, Cornelia Huck, Riku Voipio, pkg-qemu-devel,
qemu-stable
On 01/30/2017 04:23 PM, Stefan Weil wrote:
> Am 30.01.2017 um 16:11 schrieb Peter Maydell:
>> On 30 January 2017 at 15:09, Stefan Weil <sw@weilnetz.de> wrote:
>>> Am 30.01.2017 um 15:50 schrieb David Hildenbrand:
>>>> "any" does not exist, therefore resulting in a misleading error message.
>>>>
>>>> Reported-by: Stefan Weil <sw@weilnetz.de>
>>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>>> ---
>>>> linux-user/main.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/linux-user/main.c b/linux-user/main.c
>>>> index 3004958..e588f58 100644
>>>> --- a/linux-user/main.c
>>>> +++ b/linux-user/main.c
>>>> @@ -4322,6 +4322,8 @@ int main(int argc, char **argv, char **envp)
>>>> # endif
>>>> #elif defined TARGET_SH4
>>>> cpu_model = TYPE_SH7785_CPU;
>>>> +#elif defined TARGET_S390X
>>>> + cpu_model = "qemu";
>>>> #else
>>>> cpu_model = "any";
>>>> #endif
>>>
>>> Thanks.
>>>
>>> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>>>
>>> This fix is also needed for Debian's QEMU user emulation.
>> Does it merit a cc: qemu-stable ?
>>
>> thanks
>> -- PMM
>
> Yes, of course. Thanks for the reminder - I added that list now as cc.
Added to the kvm/s390 tree (since this tree introduced the regression)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-01 8:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-30 14:50 [Qemu-devel] [PATCH] target/s390x: use "qemu" cpu model in user mode David Hildenbrand
2017-01-30 14:51 ` Alexander Graf
2017-01-30 15:09 ` Stefan Weil
2017-01-30 15:11 ` Peter Maydell
2017-01-30 15:23 ` Stefan Weil
2017-02-01 8:04 ` Christian Borntraeger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.