From: Minchan Kim <minchan@kernel.org>
To: Vinayak Menon <vinmenon@codeaurora.org>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
mgorman@techsingularity.net, vbabka@suse.cz, mhocko@suse.com,
riel@redhat.com, vdavydov.dev@gmail.com,
anton.vorontsov@linaro.org, shashim@codeaurora.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: vmpressure: fix sending wrong events on underflow
Date: Tue, 31 Jan 2017 08:58:34 +0900 [thread overview]
Message-ID: <20170130235834.GC7942@bbox> (raw)
In-Reply-To: <1485504817-3124-2-git-send-email-vinmenon@codeaurora.org>
On Fri, Jan 27, 2017 at 01:43:37PM +0530, Vinayak Menon wrote:
> At the end of a window period, if the reclaimed pages
> is greater than scanned, an unsigned underflow can
> result in a huge pressure value and thus a critical event.
> Reclaimed pages is found to go higher than scanned because
> of the addition of reclaimed slab pages to reclaimed in
> shrink_node without a corresponding increment to scanned
> pages. Minchan Kim mentioned that this can also happen in
> the case of a THP page where the scanned is 1 and reclaimed
> could be 512.
>
> Signed-off-by: Vinayak Menon <vinmenon@codeaurora.org>
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks for the fix up!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Vinayak Menon <vinmenon@codeaurora.org>
Cc: <akpm@linux-foundation.org>, <hannes@cmpxchg.org>,
<mgorman@techsingularity.net>, <vbabka@suse.cz>,
<mhocko@suse.com>, <riel@redhat.com>, <vdavydov.dev@gmail.com>,
<anton.vorontsov@linaro.org>, <shashim@codeaurora.org>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mm: vmpressure: fix sending wrong events on underflow
Date: Tue, 31 Jan 2017 08:58:34 +0900 [thread overview]
Message-ID: <20170130235834.GC7942@bbox> (raw)
In-Reply-To: <1485504817-3124-2-git-send-email-vinmenon@codeaurora.org>
On Fri, Jan 27, 2017 at 01:43:37PM +0530, Vinayak Menon wrote:
> At the end of a window period, if the reclaimed pages
> is greater than scanned, an unsigned underflow can
> result in a huge pressure value and thus a critical event.
> Reclaimed pages is found to go higher than scanned because
> of the addition of reclaimed slab pages to reclaimed in
> shrink_node without a corresponding increment to scanned
> pages. Minchan Kim mentioned that this can also happen in
> the case of a THP page where the scanned is 1 and reclaimed
> could be 512.
>
> Signed-off-by: Vinayak Menon <vinmenon@codeaurora.org>
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks for the fix up!
next prev parent reply other threads:[~2017-01-30 23:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 8:13 [PATCH 1/2 v2] mm: vmscan: do not pass reclaimed slab to vmpressure Vinayak Menon
2017-01-27 8:13 ` Vinayak Menon
2017-01-27 8:13 ` [PATCH 2/2] mm: vmpressure: fix sending wrong events on underflow Vinayak Menon
2017-01-27 8:13 ` Vinayak Menon
2017-01-30 23:58 ` Minchan Kim [this message]
2017-01-30 23:58 ` Minchan Kim
2017-01-30 23:56 ` [PATCH 1/2 v2] mm: vmscan: do not pass reclaimed slab to vmpressure Minchan Kim
2017-01-30 23:56 ` Minchan Kim
2017-01-31 7:48 ` vinayak menon
2017-01-31 7:48 ` vinayak menon
2017-01-31 9:02 ` [PATCH 1/2 v3] " Vinayak Menon
2017-01-31 9:02 ` Vinayak Menon
2017-02-01 6:12 ` Minchan Kim
2017-02-01 6:12 ` Minchan Kim
2017-02-02 10:44 ` Michal Hocko
2017-02-02 10:44 ` Michal Hocko
2017-02-02 10:48 ` Michal Hocko
2017-02-02 10:48 ` Michal Hocko
2017-02-02 11:25 ` vinayak menon
2017-02-02 11:25 ` vinayak menon
2017-02-02 11:52 ` Michal Hocko
2017-02-02 11:52 ` Michal Hocko
2017-02-02 15:30 ` vinayak menon
2017-02-02 15:30 ` vinayak menon
2017-02-02 16:01 ` Michal Hocko
2017-02-02 16:01 ` Michal Hocko
2017-02-03 5:26 ` vinayak menon
2017-02-03 5:26 ` vinayak menon
2017-02-03 14:59 ` Michal Hocko
2017-02-03 14:59 ` Michal Hocko
2017-02-06 11:31 ` vinayak menon
2017-02-06 11:31 ` vinayak menon
2017-02-02 11:28 ` vinayak menon
2017-02-02 11:28 ` vinayak menon
2017-02-03 6:17 ` Minchan Kim
2017-02-03 6:17 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130235834.GC7942@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=riel@redhat.com \
--cc=shashim@codeaurora.org \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.