Re: [GIT PULL FOR v4.11] Add et8ek8 driver

[Mauro Carvalho Chehab <mchehab@s-opensource.com>]

Em Tue, 31 Jan 2017 14:45:34 +0200
Sakari Ailus <sakari.ailus@iki.fi> escreveu:

> Hi Mauro,
> 
> On Tue, Jan 31, 2017 at 10:42:48AM -0200, Mauro Carvalho Chehab wrote:
> > That added a new warning:
> > 
> > drivers/media/i2c/et8ek8/et8ek8_driver.c: In function 'et8ek8_registered':
> > drivers/media/i2c/et8ek8/et8ek8_driver.c:1262:29: warning: variable 'format' set but not used [-Wunused-but-set-variable]
> >   struct v4l2_mbus_framefmt *format;
> >                              ^~~~~~
> > compilation succeeded
> > 
> > 
> > The driver is calling this function and storing it on a var
> > that is not used:
> > 
> >         format = __et8ek8_get_pad_format(sensor, NULL, 0,
> >                                          V4L2_SUBDEV_FORMAT_ACTIVE);
> >         return 0;
> > 
> > Please send a fixup patch.  
> 
> I compiled it, too, but I guess I had a GCC version that didn't complain
> about this particular matter. I'll send you a fix.

I run make with "W=1", to enable a few extra warnings that are usually
troubles, like the above. W=2 would point some other things, but
IMHO, it is not worth trying to fix the extra warnings, as it will enable
a lot of signed/unsigned errors with are usually OK.

Thanks,
Mauro