* [GIT PULL FOR v4.11] Add et8ek8 driver
@ 2017-01-25 14:07 Sakari Ailus
2017-01-31 12:42 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 5+ messages in thread
From: Sakari Ailus @ 2017-01-25 14:07 UTC (permalink / raw)
To: linux-media
Hi Mauro,
This pull request adds the sensor et8ek8 driver which is used on the Nokia
N900. Please pull.
The following changes since commit 40eca140c404505c09773d1c6685d818cb55ab1a:
[media] mn88473: add DVB-T2 PLP support (2016-12-27 14:00:15 -0200)
are available in the git repository at:
ssh://linuxtv.org/git/sailus/media_tree.git et8ek8
for you to fetch changes up to 1d26b93d5341d36cdd45b4d801f85d6c35128385:
mark myself as mainainer for camera on N900 (2017-01-25 15:49:45 +0200)
----------------------------------------------------------------
Pavel Machek (3):
media: et8ek8: add device tree binding documentation
media: Driver for Toshiba et8ek8 5MP sensor
mark myself as mainainer for camera on N900
.../bindings/media/i2c/toshiba,et8ek8.txt | 48 +
MAINTAINERS | 8 +
drivers/media/i2c/Kconfig | 1 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/et8ek8/Kconfig | 6 +
drivers/media/i2c/et8ek8/Makefile | 2 +
drivers/media/i2c/et8ek8/et8ek8_driver.c | 1515 ++++++++++++++++++++
drivers/media/i2c/et8ek8/et8ek8_mode.c | 587 ++++++++
drivers/media/i2c/et8ek8/et8ek8_reg.h | 96 ++
9 files changed, 2264 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
create mode 100644 drivers/media/i2c/et8ek8/Kconfig
create mode 100644 drivers/media/i2c/et8ek8/Makefile
create mode 100644 drivers/media/i2c/et8ek8/et8ek8_driver.c
create mode 100644 drivers/media/i2c/et8ek8/et8ek8_mode.c
create mode 100644 drivers/media/i2c/et8ek8/et8ek8_reg.h
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [GIT PULL FOR v4.11] Add et8ek8 driver 2017-01-25 14:07 [GIT PULL FOR v4.11] Add et8ek8 driver Sakari Ailus @ 2017-01-31 12:42 ` Mauro Carvalho Chehab 2017-01-31 12:45 ` Sakari Ailus 0 siblings, 1 reply; 5+ messages in thread From: Mauro Carvalho Chehab @ 2017-01-31 12:42 UTC (permalink / raw) To: Sakari Ailus, Tuukka Toivonen, Pavel Machek; +Cc: linux-media Em Wed, 25 Jan 2017 16:07:45 +0200 Sakari Ailus <sakari.ailus@iki.fi> escreveu: > Hi Mauro, > > This pull request adds the sensor et8ek8 driver which is used on the Nokia > N900. Please pull. > > > The following changes since commit 40eca140c404505c09773d1c6685d818cb55ab1a: > > [media] mn88473: add DVB-T2 PLP support (2016-12-27 14:00:15 -0200) > > are available in the git repository at: > > ssh://linuxtv.org/git/sailus/media_tree.git et8ek8 > > for you to fetch changes up to 1d26b93d5341d36cdd45b4d801f85d6c35128385: > > mark myself as mainainer for camera on N900 (2017-01-25 15:49:45 +0200) > > ---------------------------------------------------------------- > Pavel Machek (3): > media: et8ek8: add device tree binding documentation > media: Driver for Toshiba et8ek8 5MP sensor > mark myself as mainainer for camera on N900 > > .../bindings/media/i2c/toshiba,et8ek8.txt | 48 + > MAINTAINERS | 8 + > drivers/media/i2c/Kconfig | 1 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/et8ek8/Kconfig | 6 + > drivers/media/i2c/et8ek8/Makefile | 2 + > drivers/media/i2c/et8ek8/et8ek8_driver.c | 1515 ++++++++++++++++++++ > drivers/media/i2c/et8ek8/et8ek8_mode.c | 587 ++++++++ > drivers/media/i2c/et8ek8/et8ek8_reg.h | 96 ++ > 9 files changed, 2264 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt > create mode 100644 drivers/media/i2c/et8ek8/Kconfig > create mode 100644 drivers/media/i2c/et8ek8/Makefile > create mode 100644 drivers/media/i2c/et8ek8/et8ek8_driver.c > create mode 100644 drivers/media/i2c/et8ek8/et8ek8_mode.c > create mode 100644 drivers/media/i2c/et8ek8/et8ek8_reg.h > That added a new warning: drivers/media/i2c/et8ek8/et8ek8_driver.c: In function 'et8ek8_registered': drivers/media/i2c/et8ek8/et8ek8_driver.c:1262:29: warning: variable 'format' set but not used [-Wunused-but-set-variable] struct v4l2_mbus_framefmt *format; ^~~~~~ compilation succeeded The driver is calling this function and storing it on a var that is not used: format = __et8ek8_get_pad_format(sensor, NULL, 0, V4L2_SUBDEV_FORMAT_ACTIVE); return 0; Please send a fixup patch. Thanks, Mauro ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PULL FOR v4.11] Add et8ek8 driver 2017-01-31 12:42 ` Mauro Carvalho Chehab @ 2017-01-31 12:45 ` Sakari Ailus 2017-01-31 13:01 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 5+ messages in thread From: Sakari Ailus @ 2017-01-31 12:45 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Tuukka Toivonen, Pavel Machek, linux-media Hi Mauro, On Tue, Jan 31, 2017 at 10:42:48AM -0200, Mauro Carvalho Chehab wrote: > That added a new warning: > > drivers/media/i2c/et8ek8/et8ek8_driver.c: In function 'et8ek8_registered': > drivers/media/i2c/et8ek8/et8ek8_driver.c:1262:29: warning: variable 'format' set but not used [-Wunused-but-set-variable] > struct v4l2_mbus_framefmt *format; > ^~~~~~ > compilation succeeded > > > The driver is calling this function and storing it on a var > that is not used: > > format = __et8ek8_get_pad_format(sensor, NULL, 0, > V4L2_SUBDEV_FORMAT_ACTIVE); > return 0; > > Please send a fixup patch. I compiled it, too, but I guess I had a GCC version that didn't complain about this particular matter. I'll send you a fix. -- Cheers, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PULL FOR v4.11] Add et8ek8 driver 2017-01-31 12:45 ` Sakari Ailus @ 2017-01-31 13:01 ` Mauro Carvalho Chehab 2017-02-01 12:47 ` Sakari Ailus 0 siblings, 1 reply; 5+ messages in thread From: Mauro Carvalho Chehab @ 2017-01-31 13:01 UTC (permalink / raw) To: Sakari Ailus; +Cc: Tuukka Toivonen, Pavel Machek, linux-media Em Tue, 31 Jan 2017 14:45:34 +0200 Sakari Ailus <sakari.ailus@iki.fi> escreveu: > Hi Mauro, > > On Tue, Jan 31, 2017 at 10:42:48AM -0200, Mauro Carvalho Chehab wrote: > > That added a new warning: > > > > drivers/media/i2c/et8ek8/et8ek8_driver.c: In function 'et8ek8_registered': > > drivers/media/i2c/et8ek8/et8ek8_driver.c:1262:29: warning: variable 'format' set but not used [-Wunused-but-set-variable] > > struct v4l2_mbus_framefmt *format; > > ^~~~~~ > > compilation succeeded > > > > > > The driver is calling this function and storing it on a var > > that is not used: > > > > format = __et8ek8_get_pad_format(sensor, NULL, 0, > > V4L2_SUBDEV_FORMAT_ACTIVE); > > return 0; > > > > Please send a fixup patch. > > I compiled it, too, but I guess I had a GCC version that didn't complain > about this particular matter. I'll send you a fix. I run make with "W=1", to enable a few extra warnings that are usually troubles, like the above. W=2 would point some other things, but IMHO, it is not worth trying to fix the extra warnings, as it will enable a lot of signed/unsigned errors with are usually OK. Thanks, Mauro ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [GIT PULL FOR v4.11] Add et8ek8 driver 2017-01-31 13:01 ` Mauro Carvalho Chehab @ 2017-02-01 12:47 ` Sakari Ailus 0 siblings, 0 replies; 5+ messages in thread From: Sakari Ailus @ 2017-02-01 12:47 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Tuukka Toivonen, Pavel Machek, linux-media Hi Mauro, On Tue, Jan 31, 2017 at 11:01:11AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 31 Jan 2017 14:45:34 +0200 > Sakari Ailus <sakari.ailus@iki.fi> escreveu: > > > Hi Mauro, > > > > On Tue, Jan 31, 2017 at 10:42:48AM -0200, Mauro Carvalho Chehab wrote: > > > That added a new warning: > > > > > > drivers/media/i2c/et8ek8/et8ek8_driver.c: In function 'et8ek8_registered': > > > drivers/media/i2c/et8ek8/et8ek8_driver.c:1262:29: warning: variable 'format' set but not used [-Wunused-but-set-variable] > > > struct v4l2_mbus_framefmt *format; > > > ^~~~~~ > > > compilation succeeded > > > > > > > > > The driver is calling this function and storing it on a var > > > that is not used: > > > > > > format = __et8ek8_get_pad_format(sensor, NULL, 0, > > > V4L2_SUBDEV_FORMAT_ACTIVE); > > > return 0; > > > > > > Please send a fixup patch. > > > > I compiled it, too, but I guess I had a GCC version that didn't complain > > about this particular matter. I'll send you a fix. > > I run make with "W=1", to enable a few extra warnings that are usually > troubles, like the above. W=2 would point some other things, but > IMHO, it is not worth trying to fix the extra warnings, as it will enable > a lot of signed/unsigned errors with are usually OK. I couldn't reproduce the warnings but I'm providing a patch nonetheless, also removing the extra semicolon. -- Regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-01 12:47 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-01-25 14:07 [GIT PULL FOR v4.11] Add et8ek8 driver Sakari Ailus 2017-01-31 12:42 ` Mauro Carvalho Chehab 2017-01-31 12:45 ` Sakari Ailus 2017-01-31 13:01 ` Mauro Carvalho Chehab 2017-02-01 12:47 ` Sakari Ailus
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.