From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver
Date: Tue, 31 Jan 2017 21:01:49 +0100 [thread overview]
Message-ID: <20170131200149.GM5656@lunn.ch> (raw)
In-Reply-To: <1485889401-13909-5-git-send-email-isubramanian@apm.com>
> + phy_mode = device_get_phy_mode(dev);
> + if (phy_mode < 0) {
> + dev_err(dev, "Unable to get phy-connection-type\n");
> + return phy_mode;
> + }
> + pdata->resources.phy_mode = phy_mode;
> +
> + if (pdata->resources.phy_mode != PHY_INTERFACE_MODE_RGMII) {
> + dev_err(dev, "Incorrect phy-connection-type specified\n");
> + return -ENODEV;
> + }
This seems a bit limiting. What if you need to use:
PHY_INTERFACE_MODE_RGMII_ID,
PHY_INTERFACE_MODE_RGMII_RXID,
PHY_INTERFACE_MODE_RGMII_TXID,
in order to set the RGMII delays.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Iyappan Subramanian <isubramanian@apm.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, patches@apm.com,
kchudgar@apm.com
Subject: Re: [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver
Date: Tue, 31 Jan 2017 21:01:49 +0100 [thread overview]
Message-ID: <20170131200149.GM5656@lunn.ch> (raw)
In-Reply-To: <1485889401-13909-5-git-send-email-isubramanian@apm.com>
> + phy_mode = device_get_phy_mode(dev);
> + if (phy_mode < 0) {
> + dev_err(dev, "Unable to get phy-connection-type\n");
> + return phy_mode;
> + }
> + pdata->resources.phy_mode = phy_mode;
> +
> + if (pdata->resources.phy_mode != PHY_INTERFACE_MODE_RGMII) {
> + dev_err(dev, "Incorrect phy-connection-type specified\n");
> + return -ENODEV;
> + }
This seems a bit limiting. What if you need to use:
PHY_INTERFACE_MODE_RGMII_ID,
PHY_INTERFACE_MODE_RGMII_RXID,
PHY_INTERFACE_MODE_RGMII_TXID,
in order to set the RGMII delays.
Andrew
next prev parent reply other threads:[~2017-01-31 20:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 19:03 [PATCH net-next 0/6] drivers: net: xgene-v2: Add RGMII based 1G driver Iyappan Subramanian
2017-01-31 19:03 ` Iyappan Subramanian
2017-01-31 19:03 ` [PATCH net-next 1/6] drivers: net: xgene-v2: Add DMA descriptor Iyappan Subramanian
2017-01-31 19:03 ` Iyappan Subramanian
2017-01-31 19:03 ` [PATCH net-next 2/6] drivers: net: xgene-v2: Add mac configuration Iyappan Subramanian
2017-01-31 19:03 ` Iyappan Subramanian
2017-01-31 19:03 ` [PATCH net-next 3/6] drivers: net: xgene-v2: Add ethernet hardware configuration Iyappan Subramanian
2017-01-31 19:03 ` Iyappan Subramanian
2017-01-31 19:03 ` [PATCH net-next 4/6] drivers: net: xgene-v2: Add base driver Iyappan Subramanian
2017-01-31 19:03 ` Iyappan Subramanian
2017-01-31 20:01 ` Andrew Lunn [this message]
2017-01-31 20:01 ` Andrew Lunn
2017-02-27 4:33 ` Iyappan Subramanian
2017-02-27 4:33 ` Iyappan Subramanian
2017-01-31 20:31 ` Florian Fainelli
2017-01-31 20:31 ` Florian Fainelli
2017-02-27 5:05 ` Iyappan Subramanian
2017-02-27 5:05 ` Iyappan Subramanian
2017-01-31 19:03 ` [PATCH net-next 5/6] drivers: net: xgene-v2: Add transmit and receive Iyappan Subramanian
2017-01-31 19:03 ` Iyappan Subramanian
2017-01-31 20:33 ` Florian Fainelli
2017-01-31 20:33 ` Florian Fainelli
2017-02-01 11:09 ` David Laight
2017-02-01 11:09 ` David Laight
2017-02-27 5:11 ` Iyappan Subramanian
2017-02-27 5:11 ` Iyappan Subramanian
2017-02-27 5:08 ` Iyappan Subramanian
2017-02-27 5:08 ` Iyappan Subramanian
2017-01-31 20:44 ` kbuild test robot
2017-01-31 20:49 ` kbuild test robot
2017-01-31 20:49 ` kbuild test robot
2017-01-31 19:03 ` [PATCH net-next 6/6] MAINTAINERS: Add entry for APM X-Gene SoC Ethernet (v2) driver Iyappan Subramanian
2017-01-31 19:03 ` Iyappan Subramanian
2017-01-31 20:06 ` [PATCH net-next 0/6] drivers: net: xgene-v2: Add RGMII based 1G driver Andrew Lunn
2017-01-31 20:06 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131200149.GM5656@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.