All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] block: Update comments that refer to __bio_map_user() and bio_map_user()
@ 2017-02-01 16:20 Bart Van Assche
  2017-02-01 18:15 ` Christoph Hellwig
  2017-02-01 19:33 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2017-02-01 16:20 UTC (permalink / raw)
  To: Jens Axboe
  Cc: linux-block, Bart Van Assche, Christoph Hellwig, Ming Lei,
	Jens Axboe

Since __bio_map_user() and bio_map_user() have been removed, update
the comments that still refer to these functions.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
References: commit ddad8dd0a162 ("block: use blk_rq_map_user_iov to implement blk_rq_map_user")
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@fb.com>
---
 block/bio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/block/bio.c b/block/bio.c
index 9a2dd7145e83..4b564d0c3e29 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1394,7 +1394,7 @@ struct bio *bio_map_user_iov(struct request_queue *q,
 	bio_set_flag(bio, BIO_USER_MAPPED);
 
 	/*
-	 * subtle -- if __bio_map_user() ended up bouncing a bio,
+	 * subtle -- if bio_map_user_iov() ended up bouncing a bio,
 	 * it would normally disappear when its bi_end_io is run.
 	 * however, we need it for the unmap, so grab an extra
 	 * reference to it
@@ -1436,8 +1436,8 @@ static void __bio_unmap_user(struct bio *bio)
  *	bio_unmap_user	-	unmap a bio
  *	@bio:		the bio being unmapped
  *
- *	Unmap a bio previously mapped by bio_map_user(). Must be called with
- *	a process context.
+ *	Unmap a bio previously mapped by bio_map_user_iov(). Must be called from
+ *	process context.
  *
  *	bio_unmap_user() may sleep.
  */
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] block: Update comments that refer to __bio_map_user() and bio_map_user()
  2017-02-01 16:20 [PATCH] block: Update comments that refer to __bio_map_user() and bio_map_user() Bart Van Assche
@ 2017-02-01 18:15 ` Christoph Hellwig
  2017-02-01 19:33 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-02-01 18:15 UTC (permalink / raw)
  To: Bart Van Assche
  Cc: Jens Axboe, linux-block, Christoph Hellwig, Ming Lei, Jens Axboe

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] block: Update comments that refer to __bio_map_user() and bio_map_user()
  2017-02-01 16:20 [PATCH] block: Update comments that refer to __bio_map_user() and bio_map_user() Bart Van Assche
  2017-02-01 18:15 ` Christoph Hellwig
@ 2017-02-01 19:33 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2017-02-01 19:33 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: linux-block, Christoph Hellwig, Ming Lei, Jens Axboe

On 02/01/2017 08:20 AM, Bart Van Assche wrote:
> Since __bio_map_user() and bio_map_user() have been removed, update
> the comments that still refer to these functions.

Applied, thanks Bart.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-01 19:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-01 16:20 [PATCH] block: Update comments that refer to __bio_map_user() and bio_map_user() Bart Van Assche
2017-02-01 18:15 ` Christoph Hellwig
2017-02-01 19:33 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.