From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Alexandre Courbot <gnurou@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()
Date: Thu, 02 Feb 2017 10:07:02 +0000 [thread overview]
Message-ID: <20170202100702.GE2053@lahna.fi.intel.com> (raw)
In-Reply-To: <CACRpkdaO=1+JHs2qtVULyN1B1pfajc=UF-V_N+Ej_i5SMv-pPQ@mail.gmail.com>
On Wed, Feb 01, 2017 at 03:51:06PM +0100, Linus Walleij wrote:
> fwnode_get_named_gpiod()
> devm_get_gpiod_from_child()
>
> Both are taking a fwnode as argument and the naming is as
> inconsistent as it can be.
>
> Some more churn should be expected as a side
> effect of naming this function wrong in the first place.
> The fwnode API change was on fast-forward and mistakes
> were made, also by me, mea culpa.
The name fwnode_get_named_gpiod() tries to follow of_get_named_gpio() so
that we can easily convert a driver to use fwnodes instead. The other
function is named so because we look child fwnodes under a device. For
that, yes certainly we could have invented a better name ;-)
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Alexandre Courbot <gnurou@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()
Date: Thu, 2 Feb 2017 12:07:02 +0200 [thread overview]
Message-ID: <20170202100702.GE2053@lahna.fi.intel.com> (raw)
In-Reply-To: <CACRpkdaO=1+JHs2qtVULyN1B1pfajc=UF-V_N+Ej_i5SMv-pPQ@mail.gmail.com>
On Wed, Feb 01, 2017 at 03:51:06PM +0100, Linus Walleij wrote:
> fwnode_get_named_gpiod()
> devm_get_gpiod_from_child()
>
> Both are taking a fwnode as argument and the naming is as
> inconsistent as it can be.
>
> Some more churn should be expected as a side
> effect of naming this function wrong in the first place.
> The fwnode API change was on fast-forward and mistakes
> were made, also by me, mea culpa.
The name fwnode_get_named_gpiod() tries to follow of_get_named_gpio() so
that we can easily convert a driver to use fwnodes instead. The other
function is named so because we look child fwnodes under a device. For
that, yes certainly we could have invented a better name ;-)
next prev parent reply other threads:[~2017-02-02 10:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 15:41 [PATCH 0/2] gpio: Add the devm_fwnode_get_index_gpiod_from_child() helper Boris Brezillon
2017-01-30 15:41 ` Boris Brezillon
2017-01-30 15:41 ` [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child() Boris Brezillon
2017-01-30 15:41 ` Boris Brezillon
2017-01-30 19:57 ` Jacek Anaszewski
2017-01-30 19:57 ` Jacek Anaszewski
2017-01-31 1:06 ` Dmitry Torokhov
2017-01-31 1:06 ` Dmitry Torokhov
2017-01-31 8:04 ` Boris Brezillon
2017-01-31 8:04 ` Boris Brezillon
2017-01-31 8:44 ` Dmitry Torokhov
2017-01-31 8:44 ` Dmitry Torokhov
2017-01-31 9:07 ` Boris Brezillon
2017-01-31 9:07 ` Boris Brezillon
2017-01-31 9:11 ` Dmitry Torokhov
2017-01-31 9:11 ` Dmitry Torokhov
2017-01-31 9:24 ` Boris Brezillon
2017-01-31 9:24 ` Boris Brezillon
2017-01-31 18:39 ` Dmitry Torokhov
2017-01-31 18:39 ` Dmitry Torokhov
2017-01-31 19:42 ` Boris Brezillon
2017-01-31 19:42 ` Boris Brezillon
2017-02-01 13:05 ` Linus Walleij
2017-02-01 13:05 ` Linus Walleij
2017-02-01 13:22 ` Boris Brezillon
2017-02-01 13:22 ` Boris Brezillon
2017-02-01 14:51 ` Linus Walleij
2017-02-01 14:51 ` Linus Walleij
2017-02-01 17:18 ` Dmitry Torokhov
2017-02-01 17:18 ` Dmitry Torokhov
2017-02-02 10:07 ` Mika Westerberg [this message]
2017-02-02 10:07 ` Mika Westerberg
2017-02-01 17:17 ` Dmitry Torokhov
2017-02-01 17:17 ` Dmitry Torokhov
2017-02-02 10:53 ` Linus Walleij
2017-02-02 10:53 ` Linus Walleij
2017-02-02 11:53 ` Boris Brezillon
2017-02-02 11:53 ` Boris Brezillon
2017-01-30 15:41 ` [PATCH 2/2] gpio: Add the devm_fwnode_get_index_gpiod_from_child() helper Boris Brezillon
2017-01-30 15:41 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202100702.GE2053@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cooloney@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gnurou@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rpurdie@rpsys.net \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.