All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Jan Kara <jack@suse.cz>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 1/4] mm: Fix sparse, use plain integer as NULL pointer
Date: Thu, 2 Feb 2017 16:08:25 +0300	[thread overview]
Message-ID: <20170202130825.GA32180@node> (raw)
In-Reply-To: <1485992240-10986-2-git-send-email-me@tobin.cc>

On Thu, Feb 02, 2017 at 10:37:17AM +1100, Tobin C. Harding wrote:
> From: Tobin C Harding <me@tobin.cc>
> 
> Patch fixes sparse warning: Using plain integer as NULL pointer. Replaces
> assignment of 0 to pointer with NULL assignment.
> 
> Signed-off-by: Tobin C Harding <me@tobin.cc>

I wrote this part when ARC had pgtable_t defined as 'unsigned long', so
NULL wasn't an option, but 0 was as it's valid pointer according to spec.

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Jan Kara <jack@suse.cz>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 1/4] mm: Fix sparse, use plain integer as NULL pointer
Date: Thu, 2 Feb 2017 16:08:25 +0300	[thread overview]
Message-ID: <20170202130825.GA32180@node> (raw)
In-Reply-To: <1485992240-10986-2-git-send-email-me@tobin.cc>

On Thu, Feb 02, 2017 at 10:37:17AM +1100, Tobin C. Harding wrote:
> From: Tobin C Harding <me@tobin.cc>
> 
> Patch fixes sparse warning: Using plain integer as NULL pointer. Replaces
> assignment of 0 to pointer with NULL assignment.
> 
> Signed-off-by: Tobin C Harding <me@tobin.cc>

I wrote this part when ARC had pgtable_t defined as 'unsigned long', so
NULL wasn't an option, but 0 was as it's valid pointer according to spec.

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

  reply	other threads:[~2017-02-02 13:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 23:37 [PATCH 0/4] mm: trivial sparse and checkpatch fixes Tobin C. Harding
2017-02-01 23:37 ` Tobin C. Harding
2017-02-01 23:37 ` [PATCH 1/4] mm: Fix sparse, use plain integer as NULL pointer Tobin C. Harding
2017-02-01 23:37   ` Tobin C. Harding
2017-02-02 13:08   ` Kirill A. Shutemov [this message]
2017-02-02 13:08     ` Kirill A. Shutemov
2017-02-01 23:37 ` [PATCH 2/4] mm: Fix checkpatch warnings, whitespace Tobin C. Harding
2017-02-01 23:37   ` Tobin C. Harding
2017-02-02  0:48   ` David Rientjes
2017-02-02  0:48     ` David Rientjes
2017-02-02  3:51     ` Tobin Harding
2017-02-02  3:51       ` Tobin Harding
2017-02-01 23:37 ` [PATCH 3/4] mm: Fix checkpatch errors, whitespace errors Tobin C. Harding
2017-02-01 23:37   ` Tobin C. Harding
2017-02-01 23:37 ` [PATCH 4/4] mm: Fix checkpatch warning, extraneous braces Tobin C. Harding
2017-02-01 23:37   ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170202130825.GA32180@node \
    --to=kirill@shutemov.name \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=me@tobin.cc \
    --cc=mhocko@suse.com \
    --cc=ross.zwisler@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.