From: Jan Kara <jack@suse.cz>
To: <linux-fsdevel@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, Jan Kara <jack@suse.cz>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
lustre-devel@lists.lustre.org
Subject: [PATCH 06/24] lustre: Convert to separately allocated bdi
Date: Thu, 2 Feb 2017 18:34:04 +0100 [thread overview]
Message-ID: <20170202173422.3240-7-jack@suse.cz> (raw)
In-Reply-To: <20170202173422.3240-1-jack@suse.cz>
Allocate struct backing_dev_info separately instead of embedding it
inside superblock. This unifies handling of bdi among users.
CC: Oleg Drokin <oleg.drokin@intel.com>
CC: Andreas Dilger <andreas.dilger@intel.com>
CC: James Simmons <jsimmons@infradead.org>
CC: lustre-devel@lists.lustre.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
.../staging/lustre/lustre/include/lustre_disk.h | 4 ----
drivers/staging/lustre/lustre/llite/llite_lib.c | 24 +++-------------------
2 files changed, 3 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_disk.h b/drivers/staging/lustre/lustre/include/lustre_disk.h
index 8886458748c1..a676bccabd43 100644
--- a/drivers/staging/lustre/lustre/include/lustre_disk.h
+++ b/drivers/staging/lustre/lustre/include/lustre_disk.h
@@ -133,13 +133,9 @@ struct lustre_sb_info {
struct obd_export *lsi_osd_exp;
char lsi_osd_type[16];
char lsi_fstype[16];
- struct backing_dev_info lsi_bdi; /* each client mountpoint needs
- * own backing_dev_info
- */
};
#define LSI_UMOUNT_FAILOVER 0x00200000
-#define LSI_BDI_INITIALIZED 0x00400000
#define s2lsi(sb) ((struct lustre_sb_info *)((sb)->s_fs_info))
#define s2lsi_nocast(sb) ((sb)->s_fs_info)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
index 25f5aed97f63..4f07d2e60d40 100644
--- a/drivers/staging/lustre/lustre/llite/llite_lib.c
+++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
@@ -861,15 +861,6 @@ void ll_lli_init(struct ll_inode_info *lli)
mutex_init(&lli->lli_layout_mutex);
}
-static inline int ll_bdi_register(struct backing_dev_info *bdi)
-{
- static atomic_t ll_bdi_num = ATOMIC_INIT(0);
-
- bdi->name = "lustre";
- return bdi_register(bdi, NULL, "lustre-%d",
- atomic_inc_return(&ll_bdi_num));
-}
-
int ll_fill_super(struct super_block *sb, struct vfsmount *mnt)
{
struct lustre_profile *lprof = NULL;
@@ -879,6 +870,7 @@ int ll_fill_super(struct super_block *sb, struct vfsmount *mnt)
char *profilenm = get_profile_name(sb);
struct config_llog_instance *cfg;
int err;
+ static atomic_t ll_bdi_num = ATOMIC_INIT(0);
CDEBUG(D_VFSTRACE, "VFS Op: sb %p\n", sb);
@@ -901,16 +893,11 @@ int ll_fill_super(struct super_block *sb, struct vfsmount *mnt)
if (err)
goto out_free;
- err = bdi_init(&lsi->lsi_bdi);
- if (err)
- goto out_free;
- lsi->lsi_flags |= LSI_BDI_INITIALIZED;
- lsi->lsi_bdi.capabilities = 0;
- err = ll_bdi_register(&lsi->lsi_bdi);
+ err = super_setup_bdi_name(sb, "lustre-%d",
+ atomic_inc_return(&ll_bdi_num));
if (err)
goto out_free;
- sb->s_bdi = &lsi->lsi_bdi;
/* kernel >= 2.6.38 store dentry operations in sb->s_d_op. */
sb->s_d_op = &ll_d_ops;
@@ -1031,11 +1018,6 @@ void ll_put_super(struct super_block *sb)
if (profilenm)
class_del_profile(profilenm);
- if (lsi->lsi_flags & LSI_BDI_INITIALIZED) {
- bdi_destroy(&lsi->lsi_bdi);
- lsi->lsi_flags &= ~LSI_BDI_INITIALIZED;
- }
-
ll_free_sbi(sb);
lsi->lsi_llsbi = NULL;
--
2.10.2
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, Jan Kara <jack@suse.cz>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 06/24] lustre: Convert to separately allocated bdi
Date: Thu, 2 Feb 2017 18:34:04 +0100 [thread overview]
Message-ID: <20170202173422.3240-7-jack@suse.cz> (raw)
In-Reply-To: <20170202173422.3240-1-jack@suse.cz>
Allocate struct backing_dev_info separately instead of embedding it
inside superblock. This unifies handling of bdi among users.
CC: Oleg Drokin <oleg.drokin@intel.com>
CC: Andreas Dilger <andreas.dilger@intel.com>
CC: James Simmons <jsimmons@infradead.org>
CC: lustre-devel at lists.lustre.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
.../staging/lustre/lustre/include/lustre_disk.h | 4 ----
drivers/staging/lustre/lustre/llite/llite_lib.c | 24 +++-------------------
2 files changed, 3 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_disk.h b/drivers/staging/lustre/lustre/include/lustre_disk.h
index 8886458748c1..a676bccabd43 100644
--- a/drivers/staging/lustre/lustre/include/lustre_disk.h
+++ b/drivers/staging/lustre/lustre/include/lustre_disk.h
@@ -133,13 +133,9 @@ struct lustre_sb_info {
struct obd_export *lsi_osd_exp;
char lsi_osd_type[16];
char lsi_fstype[16];
- struct backing_dev_info lsi_bdi; /* each client mountpoint needs
- * own backing_dev_info
- */
};
#define LSI_UMOUNT_FAILOVER 0x00200000
-#define LSI_BDI_INITIALIZED 0x00400000
#define s2lsi(sb) ((struct lustre_sb_info *)((sb)->s_fs_info))
#define s2lsi_nocast(sb) ((sb)->s_fs_info)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
index 25f5aed97f63..4f07d2e60d40 100644
--- a/drivers/staging/lustre/lustre/llite/llite_lib.c
+++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
@@ -861,15 +861,6 @@ void ll_lli_init(struct ll_inode_info *lli)
mutex_init(&lli->lli_layout_mutex);
}
-static inline int ll_bdi_register(struct backing_dev_info *bdi)
-{
- static atomic_t ll_bdi_num = ATOMIC_INIT(0);
-
- bdi->name = "lustre";
- return bdi_register(bdi, NULL, "lustre-%d",
- atomic_inc_return(&ll_bdi_num));
-}
-
int ll_fill_super(struct super_block *sb, struct vfsmount *mnt)
{
struct lustre_profile *lprof = NULL;
@@ -879,6 +870,7 @@ int ll_fill_super(struct super_block *sb, struct vfsmount *mnt)
char *profilenm = get_profile_name(sb);
struct config_llog_instance *cfg;
int err;
+ static atomic_t ll_bdi_num = ATOMIC_INIT(0);
CDEBUG(D_VFSTRACE, "VFS Op: sb %p\n", sb);
@@ -901,16 +893,11 @@ int ll_fill_super(struct super_block *sb, struct vfsmount *mnt)
if (err)
goto out_free;
- err = bdi_init(&lsi->lsi_bdi);
- if (err)
- goto out_free;
- lsi->lsi_flags |= LSI_BDI_INITIALIZED;
- lsi->lsi_bdi.capabilities = 0;
- err = ll_bdi_register(&lsi->lsi_bdi);
+ err = super_setup_bdi_name(sb, "lustre-%d",
+ atomic_inc_return(&ll_bdi_num));
if (err)
goto out_free;
- sb->s_bdi = &lsi->lsi_bdi;
/* kernel >= 2.6.38 store dentry operations in sb->s_d_op. */
sb->s_d_op = &ll_d_ops;
@@ -1031,11 +1018,6 @@ void ll_put_super(struct super_block *sb)
if (profilenm)
class_del_profile(profilenm);
- if (lsi->lsi_flags & LSI_BDI_INITIALIZED) {
- bdi_destroy(&lsi->lsi_bdi);
- lsi->lsi_flags &= ~LSI_BDI_INITIALIZED;
- }
-
ll_free_sbi(sb);
lsi->lsi_llsbi = NULL;
--
2.10.2
next prev parent reply other threads:[~2017-02-02 17:34 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 17:33 [PATCH 0/24 RFC] fs: Convert all embedded bdis into separate ones Jan Kara
2017-02-02 17:33 ` [lustre-devel] " Jan Kara
2017-02-02 17:33 ` Jan Kara
2017-02-02 17:33 ` Jan Kara
2017-02-02 17:33 ` Jan Kara
2017-02-02 17:33 ` [Cluster-devel] " Jan Kara
2017-02-02 17:33 ` [PATCH 01/24] block: Provide bdi_alloc() Jan Kara
2017-02-02 17:34 ` [PATCH 02/24] bdi: Provide bdi_register_va() Jan Kara
2017-02-02 17:34 ` [PATCH 03/24] block: Unregister bdi on last reference drop Jan Kara
2017-02-02 17:34 ` [PATCH 04/24] fs: Provide infrastructure for dynamic BDIs in filesystems Jan Kara
2017-02-02 17:34 ` [lustre-devel] " Jan Kara
2017-02-02 17:34 ` Jan Kara
2017-02-02 17:34 ` Jan Kara
2017-02-02 17:34 ` [Cluster-devel] " Jan Kara
2017-02-02 19:28 ` Liu Bo
2017-02-02 19:28 ` [Cluster-devel] " Liu Bo
2017-02-03 13:50 ` Jan Kara
2017-02-03 13:50 ` [lustre-devel] " Jan Kara
2017-02-03 13:50 ` [Cluster-devel] " Jan Kara
2017-02-03 18:31 ` Liu Bo
2017-02-03 18:31 ` Liu Bo
2017-02-03 18:31 ` [Cluster-devel] " Liu Bo
[not found] ` <20170202173422.3240-5-jack-AlSwsSmVLrQ@public.gmane.org>
2017-02-08 0:38 ` Dilger, Andreas
2017-02-08 0:38 ` [lustre-devel] " Dilger, Andreas
2017-02-08 0:38 ` Dilger, Andreas
2017-02-08 0:38 ` Dilger, Andreas
2017-02-08 0:38 ` Dilger, Andreas
2017-02-08 0:38 ` [Cluster-devel] " Dilger, Andreas
[not found] ` <C01BF300-AD67-4A3E-810F-AAB2EEB90B97-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-02-09 12:12 ` Jan Kara
2017-02-09 12:12 ` [lustre-devel] " Jan Kara
2017-02-09 12:12 ` Jan Kara
2017-02-09 12:12 ` Jan Kara
2017-02-09 12:12 ` Jan Kara
2017-02-09 12:12 ` [lustre-devel] " Jan Kara
2017-02-09 12:12 ` [Cluster-devel] " Jan Kara
2017-02-02 17:34 ` [PATCH 05/24] fs: Get proper reference for s_bdi Jan Kara
2017-02-09 14:36 ` Boaz Harrosh
2017-02-09 15:52 ` Jan Kara
2017-02-02 17:34 ` Jan Kara [this message]
2017-02-02 17:34 ` [lustre-devel] [PATCH 06/24] lustre: Convert to separately allocated bdi Jan Kara
2017-02-08 0:38 ` Dilger, Andreas
2017-02-08 0:38 ` Dilger, Andreas
2017-02-02 17:34 ` [PATCH 07/24] 9p: " Jan Kara
2017-02-02 17:34 ` [PATCH 08/24] btrfs: " Jan Kara
2017-02-03 18:33 ` Liu Bo
2017-02-08 15:22 ` David Sterba
2017-02-02 17:34 ` [PATCH 09/24] ceph: " Jan Kara
2017-02-02 17:34 ` Jan Kara
2017-02-02 17:34 ` [PATCH 10/24] cifs: " Jan Kara
2017-02-02 17:34 ` [PATCH 11/24] ecryptfs: " Jan Kara
2017-02-02 17:34 ` Jan Kara
2017-02-03 23:54 ` Tyler Hicks
2017-02-02 17:34 ` [PATCH 12/24] afs: " Jan Kara
2017-02-02 17:34 ` [PATCH 13/24] orangefs: Remove orangefs_backing_dev_info Jan Kara
2017-02-02 17:34 ` [PATCH 14/24] mtd: Convert to dynamically allocated bdi infrastructure Jan Kara
2017-02-02 17:34 ` [PATCH 15/24] coda: Convert to separately allocated bdi Jan Kara
2017-02-02 17:34 ` [PATCH 16/24] exofs: " Jan Kara
2017-02-09 14:23 ` Boaz Harrosh
2017-02-02 17:34 ` [PATCH 17/24] fuse: " Jan Kara
2017-02-07 9:16 ` Miklos Szeredi
2017-02-07 11:35 ` Jan Kara
2017-02-02 17:34 ` [Cluster-devel] [PATCH 18/24] gfs2: Convert to properly refcounting bdi Jan Kara
2017-02-02 17:34 ` Jan Kara
2017-02-02 17:34 ` [PATCH 19/24] nilfs2: " Jan Kara
2017-02-02 17:34 ` Jan Kara
2017-02-02 17:34 ` [PATCH 20/24] ncpfs: Convert to separately allocated bdi Jan Kara
2017-02-02 17:34 ` [PATCH 21/24] nfs: " Jan Kara
2017-02-02 17:34 ` [PATCH 22/24] ubifs: " Jan Kara
2017-02-02 20:34 ` Richard Weinberger
2017-02-03 13:45 ` Jan Kara
2017-02-08 11:24 ` Richard Weinberger
2017-02-09 12:17 ` Jan Kara
2017-02-09 14:56 ` Richard Weinberger
2017-02-02 17:34 ` [PATCH 23/24] fs: Remove SB_I_DYNBDI flag Jan Kara
2017-02-02 17:34 ` [PATCH 24/24] block: Remove unused functions Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202173422.3240-7-jack@suse.cz \
--to=jack@suse.cz \
--cc=andreas.dilger@intel.com \
--cc=hch@infradead.org \
--cc=jsimmons@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.