From: Pavel Machek <pavel@ucw.cz>
To: "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>, "bp@suse.de" <bp@suse.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"Daniluk, Lukasz" <lukasz.daniluk@intel.com>,
"Cownie, James H" <james.h.cownie@intel.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
"Luc, Piotr" <Piotr.Luc@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot
Date: Fri, 3 Feb 2017 11:47:40 +0100 [thread overview]
Message-ID: <20170203104740.GA30941@amd> (raw)
In-Reply-To: <ED52C51D9B87F54892CE544909A13C6C1FF85E6E@IRSMSX101.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Fri 2016-12-09 12:49:33, Andrejczuk, Grzegorz wrote:
> > > On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > > > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > > > +#ifdef CONFIG_X86_64
> > > > > +static int phi_r3mwait_disabled __read_mostly;
> > > > > +
> > > > > +static int __init phir3mwait_disable(char *__unused) {
> > > > > + phi_r3mwait_disabled = 1;
> > > > > + pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> > > >
> > > > Why would that be a warning? The sysadmin added the command line
> > > > switch, so why does he needs to be warned?
> > >
> > > Its telling admin he did not make a typo on the command line. We often do that....
> >
> > Definitely not at the warning level.
>
> Is info level OK for that message?
I'd say so.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-02-03 10:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 14:01 [PATCH v6 0/4] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing Grzegorz Andrejczuk
2016-10-27 14:02 ` [PATCH v6: 1/4] x86/msr: Add R3MWAIT register and bit to msr-info.h Grzegorz Andrejczuk
2016-10-27 14:32 ` Thomas Gleixner
2016-10-27 14:02 ` [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Grzegorz Andrejczuk
2016-10-27 14:38 ` Thomas Gleixner
2016-10-27 16:53 ` Andrejczuk, Grzegorz
2016-10-27 18:22 ` Thomas Gleixner
2016-11-26 13:15 ` Pavel Machek
2016-11-26 13:20 ` Thomas Gleixner
2016-12-09 12:49 ` Andrejczuk, Grzegorz
2017-02-03 10:47 ` Pavel Machek [this message]
2017-02-03 11:28 ` Andrejczuk, Grzegorz
2016-10-27 14:02 ` [PATCH v6: 3/4] x86: Use HWCAP2 to expose Xeon Phi ring 3 MWAIT Grzegorz Andrejczuk
2016-10-27 14:02 ` [PATCH v6: 4/4] x86/cpufeature: Add R3MWAIT to CPU features Grzegorz Andrejczuk
2016-10-27 14:30 ` Borislav Petkov
2016-10-27 16:46 ` Andrejczuk, Grzegorz
2016-10-27 17:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203104740.GA30941@amd \
--to=pavel@ucw.cz \
--cc=Piotr.Luc@intel.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=grzegorz.andrejczuk@intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=james.h.cownie@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.daniluk@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.