From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Eddie Cai <eddie.cai.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board
Date: Mon, 6 Feb 2017 03:54:35 +0100 [thread overview]
Message-ID: <20170206025435.GA32506@lunn.ch> (raw)
In-Reply-To: <1486347287-31051-3-git-send-email-eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Hi Eddie
> + button@0 {
> + gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
> + linux,code = <116>;
It is a good idea to use include/dt-bindings/input/input.h
and then you can replace <116> with < KEY_POWER > which is more
readable.
> + label = "GPIO Key Power";
> + linux,input-type = <1>;
< EV_KEY >
> + gpio-key,wakeup = <1>;
This has been replace with wakeup-source.
> + debounce-interval = <100>;
> + };
> + };
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board
Date: Mon, 6 Feb 2017 03:54:35 +0100 [thread overview]
Message-ID: <20170206025435.GA32506@lunn.ch> (raw)
In-Reply-To: <1486347287-31051-3-git-send-email-eddie.cai@rock-chips.com>
Hi Eddie
> + button at 0 {
> + gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
> + linux,code = <116>;
It is a good idea to use include/dt-bindings/input/input.h
and then you can replace <116> with < KEY_POWER > which is more
readable.
> + label = "GPIO Key Power";
> + linux,input-type = <1>;
< EV_KEY >
> + gpio-key,wakeup = <1>;
This has been replace with wakeup-source.
> + debounce-interval = <100>;
> + };
> + };
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Eddie Cai <eddie.cai.linux@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@armlinux.org.uk, linux-rockchip@lists.infradead.org,
eddie.cai@rock-chips.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board
Date: Mon, 6 Feb 2017 03:54:35 +0100 [thread overview]
Message-ID: <20170206025435.GA32506@lunn.ch> (raw)
In-Reply-To: <1486347287-31051-3-git-send-email-eddie.cai@rock-chips.com>
Hi Eddie
> + button@0 {
> + gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
> + linux,code = <116>;
It is a good idea to use include/dt-bindings/input/input.h
and then you can replace <116> with < KEY_POWER > which is more
readable.
> + label = "GPIO Key Power";
> + linux,input-type = <1>;
< EV_KEY >
> + gpio-key,wakeup = <1>;
This has been replace with wakeup-source.
> + debounce-interval = <100>;
> + };
> + };
Andrew
next prev parent reply other threads:[~2017-02-06 2:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 2:14 [PATCH V2 0/2] Add support for RK3288 Tinker board Eddie Cai
2017-02-06 2:14 ` Eddie Cai
[not found] ` <1486347287-31051-1-git-send-email-eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-02-06 2:14 ` [PATCH V2 1/2] dt-bindings: add Asus " Eddie Cai
2017-02-06 2:14 ` Eddie Cai
2017-02-06 2:14 ` Eddie Cai
2017-02-08 23:01 ` Rob Herring
2017-02-08 23:01 ` Rob Herring
2017-02-08 23:01 ` Rob Herring
2017-02-06 2:14 ` [PATCH V2 2/2] ARM: dts: rockchip: add dts for RK3288-Tinker board Eddie Cai
2017-02-06 2:14 ` Eddie Cai
2017-02-06 2:14 ` Eddie Cai
2017-02-08 23:07 ` Heiko Stuebner
2017-02-08 23:07 ` Heiko Stuebner
2017-02-08 23:07 ` Heiko Stuebner
2017-02-14 9:54 ` Eddie Cai
2017-02-14 9:54 ` Eddie Cai
2017-02-14 9:54 ` Eddie Cai
[not found] ` <1486347287-31051-3-git-send-email-eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-02-06 2:54 ` Andrew Lunn [this message]
2017-02-06 2:54 ` Andrew Lunn
2017-02-06 2:54 ` Andrew Lunn
[not found] ` <20170206025435.GA32506-g2DYL2Zd6BY@public.gmane.org>
2017-02-06 5:52 ` Eddie Cai
2017-02-06 5:52 ` Eddie Cai
2017-02-06 5:52 ` Eddie Cai
2017-02-09 1:45 ` Andy Yan
2017-02-09 1:45 ` Andy Yan
2017-02-09 1:45 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206025435.GA32506@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=eddie.cai.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.