From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Nayna Jain <nayna@linux.vnet.ibm.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] tpm: silence an array overflow warning
Date: Mon, 06 Feb 2017 09:20:07 +0000 [thread overview]
Message-ID: <20170206092007.GA11103@mwanda> (raw)
In-Reply-To: <20170203181120.d3r7ab4twbvelwmi@intel.com>
On Fri, Feb 03, 2017 at 08:11:20PM +0200, Jarkko Sakkinen wrote:
> On Fri, Feb 03, 2017 at 01:30:40PM +0300, Dan Carpenter wrote:
> > We should check that we're within bounds first before checking that
> > "chip->active_banks[i] != TPM2_ALG_ERROR" so I've re-ordered the two
> > checks.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thank you, good catch! Do you mind if I squash this.
>
Not at all.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Nayna Jain <nayna@linux.vnet.ibm.com>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] tpm: silence an array overflow warning
Date: Mon, 6 Feb 2017 12:20:07 +0300 [thread overview]
Message-ID: <20170206092007.GA11103@mwanda> (raw)
In-Reply-To: <20170203181120.d3r7ab4twbvelwmi@intel.com>
On Fri, Feb 03, 2017 at 08:11:20PM +0200, Jarkko Sakkinen wrote:
> On Fri, Feb 03, 2017 at 01:30:40PM +0300, Dan Carpenter wrote:
> > We should check that we're within bounds first before checking that
> > "chip->active_banks[i] != TPM2_ALG_ERROR" so I've re-ordered the two
> > checks.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thank you, good catch! Do you mind if I squash this.
>
Not at all.
regards,
dan carpenter
next prev parent reply other threads:[~2017-02-06 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 10:30 [patch] tpm: silence an array overflow warning Dan Carpenter
2017-02-03 10:30 ` Dan Carpenter
2017-02-03 18:11 ` Jarkko Sakkinen
2017-02-03 18:11 ` Jarkko Sakkinen
2017-02-06 9:20 ` Dan Carpenter [this message]
2017-02-06 9:20 ` Dan Carpenter
2017-02-06 14:15 ` Jarkko Sakkinen
2017-02-06 14:15 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206092007.GA11103@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.