From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Dave Jiang <dave.jiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: mawilcox-0li6OtcxBFHby3iVrkZq2A@public.gmane.org,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
jack-IBi9RG/b67k@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
vbabka-AlSwsSmVLrQ@public.gmane.org
Subject: Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault
Date: Mon, 6 Feb 2017 06:36:48 -0800 [thread overview]
Message-ID: <20170206143648.GA461@infradead.org> (raw)
In-Reply-To: <148615748258.43180.1690152053774975329.stgit-Cxk7aZI4ujnJARH06PadV2t3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
On Fri, Feb 03, 2017 at 02:31:22PM -0700, Dave Jiang wrote:
> Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has
> been somewhat painful with getting the flags set and removed at the
> correct locations. More than one kernel oops was introduced due to
> difficulties of getting the placement correctly. Removing the flag
> values and introducing an input parameter to huge_fault that indicates
> the size of the page entry. This makes the code easier to trace and
> should avoid the issues we see with the fault flags where removal of the
> flag was necessary in the fallback paths.
Why is this not in struct vm_fault? Also can be use this opportunity
to fold ->huge_fault into ->fault?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: mawilcox@microsoft.com, linux-nvdimm@lists.01.org,
dave.hansen@linux.intel.com, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, kirill.shutemov@linux.intel.com,
jack@suse.com, akpm@linux-foundation.org,
linux-ext4@vger.kernel.org, vbabka@suse.cz
Subject: Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault
Date: Mon, 6 Feb 2017 06:36:48 -0800 [thread overview]
Message-ID: <20170206143648.GA461@infradead.org> (raw)
In-Reply-To: <148615748258.43180.1690152053774975329.stgit@djiang5-desk3.ch.intel.com>
On Fri, Feb 03, 2017 at 02:31:22PM -0700, Dave Jiang wrote:
> Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has
> been somewhat painful with getting the flags set and removed at the
> correct locations. More than one kernel oops was introduced due to
> difficulties of getting the placement correctly. Removing the flag
> values and introducing an input parameter to huge_fault that indicates
> the size of the page entry. This makes the code easier to trace and
> should avoid the issues we see with the fault flags where removal of the
> flag was necessary in the fallback paths.
Why is this not in struct vm_fault? Also can be use this opportunity
to fold ->huge_fault into ->fault?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: akpm@linux-foundation.org, mawilcox@microsoft.com,
linux-nvdimm@lists.01.org, dave.hansen@linux.intel.com,
linux-xfs@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
jack@suse.com, linux-ext4@vger.kernel.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault
Date: Mon, 6 Feb 2017 06:36:48 -0800 [thread overview]
Message-ID: <20170206143648.GA461@infradead.org> (raw)
In-Reply-To: <148615748258.43180.1690152053774975329.stgit@djiang5-desk3.ch.intel.com>
On Fri, Feb 03, 2017 at 02:31:22PM -0700, Dave Jiang wrote:
> Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has
> been somewhat painful with getting the flags set and removed at the
> correct locations. More than one kernel oops was introduced due to
> difficulties of getting the placement correctly. Removing the flag
> values and introducing an input parameter to huge_fault that indicates
> the size of the page entry. This makes the code easier to trace and
> should avoid the issues we see with the fault flags where removal of the
> flag was necessary in the fallback paths.
Why is this not in struct vm_fault? Also can be use this opportunity
to fold ->huge_fault into ->fault?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: akpm@linux-foundation.org, mawilcox@microsoft.com,
linux-nvdimm@lists.01.org, dave.hansen@linux.intel.com,
linux-xfs@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
jack@suse.com, linux-ext4@vger.kernel.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault
Date: Mon, 6 Feb 2017 06:36:48 -0800 [thread overview]
Message-ID: <20170206143648.GA461@infradead.org> (raw)
In-Reply-To: <148615748258.43180.1690152053774975329.stgit@djiang5-desk3.ch.intel.com>
On Fri, Feb 03, 2017 at 02:31:22PM -0700, Dave Jiang wrote:
> Since the introduction of FAULT_FLAG_SIZE to the vm_fault flag, it has
> been somewhat painful with getting the flags set and removed at the
> correct locations. More than one kernel oops was introduced due to
> difficulties of getting the placement correctly. Removing the flag
> values and introducing an input parameter to huge_fault that indicates
> the size of the page entry. This makes the code easier to trace and
> should avoid the issues we see with the fault flags where removal of the
> flag was necessary in the fallback paths.
Why is this not in struct vm_fault? Also can be use this opportunity
to fold ->huge_fault into ->fault?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-06 14:36 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 21:31 [PATCH] mm: replace FAULT_FLAG_SIZE with parameter to huge_fault Dave Jiang
2017-02-03 21:31 ` Dave Jiang
2017-02-03 21:31 ` Dave Jiang
2017-02-03 21:31 ` Dave Jiang
2017-02-03 21:47 ` Dan Williams
2017-02-03 21:47 ` Dan Williams
2017-02-03 21:47 ` Dan Williams
[not found] ` <148615748258.43180.1690152053774975329.stgit-Cxk7aZI4ujnJARH06PadV2t3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
2017-02-03 22:56 ` kbuild test robot
2017-02-03 22:56 ` kbuild test robot
2017-02-03 22:56 ` kbuild test robot
2017-02-03 23:25 ` Dave Jiang
2017-02-03 23:25 ` Dave Jiang
2017-02-03 23:25 ` Dave Jiang
2017-02-03 23:26 ` Dan Williams
2017-02-03 23:26 ` Dan Williams
2017-02-04 0:00 ` Dan Williams
2017-02-04 0:00 ` Dan Williams
2017-02-04 0:00 ` Dan Williams
2017-02-04 0:07 ` Dave Jiang
2017-02-04 0:07 ` Dave Jiang
2017-02-04 0:07 ` Dave Jiang
[not found] ` <86962573-01b7-4ce7-182e-7a77f183cf0e-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-02-09 4:34 ` [kbuild-all] " Ye Xiaolong
2017-02-09 4:34 ` Ye Xiaolong
2017-02-09 4:34 ` Ye Xiaolong
2017-02-09 4:34 ` Ye Xiaolong
2017-02-04 3:51 ` kbuild test robot
2017-02-04 3:51 ` kbuild test robot
2017-02-04 3:51 ` kbuild test robot
2017-02-06 8:51 ` Jan Kara
2017-02-06 8:51 ` Jan Kara
2017-02-06 8:51 ` Jan Kara
2017-02-06 8:51 ` Jan Kara
2017-02-06 14:36 ` Christoph Hellwig [this message]
2017-02-06 14:36 ` Christoph Hellwig
2017-02-06 14:36 ` Christoph Hellwig
2017-02-06 14:36 ` Christoph Hellwig
2017-02-06 16:24 ` Dan Williams
2017-02-06 16:24 ` Dan Williams
2017-02-06 16:24 ` Dan Williams
2017-02-06 17:27 ` Christoph Hellwig
2017-02-06 17:27 ` Christoph Hellwig
2017-02-06 17:27 ` Christoph Hellwig
2017-02-06 17:30 ` Dan Williams
2017-02-06 17:30 ` Dan Williams
2017-02-06 17:30 ` Dan Williams
2017-02-07 8:44 ` Kirill A. Shutemov
2017-02-07 8:44 ` Kirill A. Shutemov
2017-02-07 8:44 ` Kirill A. Shutemov
2017-02-07 16:56 ` Dan Williams
2017-02-07 16:56 ` Dan Williams
2017-02-07 16:56 ` Dan Williams
2017-02-07 17:40 ` Kirill A. Shutemov
2017-02-07 17:40 ` Kirill A. Shutemov
2017-02-07 17:40 ` Kirill A. Shutemov
[not found] ` <20170207174042.GB5578-sVvlyX1904swdBt8bTSxpkEMvNT87kid@public.gmane.org>
2017-02-07 18:08 ` Dan Williams
2017-02-07 18:08 ` Dan Williams
2017-02-07 18:08 ` Dan Williams
2017-02-07 18:08 ` Dan Williams
[not found] ` <CAPcyv4h1LvbEqBi=F=BTtLrHHOvAH3MU2OBDs444-dzwNyupFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-08 8:41 ` Jan Kara
2017-02-08 8:41 ` Jan Kara
2017-02-08 8:41 ` Jan Kara
2017-02-08 8:41 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206143648.GA461@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=dave.jiang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jack-IBi9RG/b67k@public.gmane.org \
--cc=kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mawilcox-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
--cc=vbabka-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.