* [meta-qt5][PATCH v2] qt3d: Add assimp dependency
@ 2017-01-27 22:54 Tom Hochstein
2017-02-07 12:00 ` Martin Jansa
0 siblings, 1 reply; 9+ messages in thread
From: Tom Hochstein @ 2017-01-27 22:54 UTC (permalink / raw)
To: openembedded-devel
Fix build error:
fatal error: assimp/Importer.hpp: No such file or directory
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
---
recipes-qt/qt5/qt3d_git.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
index 2276c36..7c31213 100644
--- a/recipes-qt/qt5/qt3d_git.bb
+++ b/recipes-qt/qt5/qt3d_git.bb
@@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
PACKAGECONFIG_class-native ??= "tools-only"
PACKAGECONFIG_class-nativesdk ??= "tools-only"
PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
+PACKAGECONFIG[assimp] = ",,assimp"
EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [meta-qt5][PATCH v2] qt3d: Add assimp dependency
2017-01-27 22:54 [meta-qt5][PATCH v2] qt3d: Add assimp dependency Tom Hochstein
@ 2017-02-07 12:00 ` Martin Jansa
2017-02-08 17:42 ` Tom Hochstein
0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2017-02-07 12:00 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:
> Fix build error:
>
> fatal error: assimp/Importer.hpp: No such file or directory
I'm was able to build qt3d without this dependency, is there something
in your config which enabled it? Or is it autodetected from sysroot
which wont be an issue anymore with master and RSS, but your change
doesn't fix the autodetection for older branches.
> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
> ---
> recipes-qt/qt5/qt3d_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
> index 2276c36..7c31213 100644
> --- a/recipes-qt/qt5/qt3d_git.bb
> +++ b/recipes-qt/qt5/qt3d_git.bb
> @@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
> PACKAGECONFIG_class-native ??= "tools-only"
> PACKAGECONFIG_class-nativesdk ??= "tools-only"
> PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
> +PACKAGECONFIG[assimp] = ",,assimp"
>
> EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
>
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [meta-qt5][PATCH v2] qt3d: Add assimp dependency
2017-02-07 12:00 ` Martin Jansa
@ 2017-02-08 17:42 ` Tom Hochstein
2017-02-08 19:43 ` Martin Jansa
0 siblings, 1 reply; 9+ messages in thread
From: Tom Hochstein @ 2017-02-08 17:42 UTC (permalink / raw)
To: openembedded-devel@lists.openembedded.org
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On
> Behalf Of Martin Jansa
> Sent: Tuesday, February 07, 2017 6:01 AM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency
>
> On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:
> > Fix build error:
> >
> > fatal error: assimp/Importer.hpp: No such file or directory
>
> I'm was able to build qt3d without this dependency, is there something
> in your config which enabled it? Or is it autodetected from sysroot
> which wont be an issue anymore with master and RSS, but your change
> doesn't fix the autodetection for older branches.
We do enable assimp from another recipe.
I am unable to reproduce the original problem either.
Without the explicit dependency, it would seem that the build would at best be non-deterministic, enabling or disabling assimp support based solely on the timing of the Yocto tasks. I'm not aware of the technologies you allude to. Do they provide some determinism for this case?
>
> > Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
> > ---
> > recipes-qt/qt5/qt3d_git.bb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
> > index 2276c36..7c31213 100644
> > --- a/recipes-qt/qt5/qt3d_git.bb
> > +++ b/recipes-qt/qt5/qt3d_git.bb
> > @@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
> > PACKAGECONFIG_class-native ??= "tools-only"
> > PACKAGECONFIG_class-nativesdk ??= "tools-only"
> > PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
> > +PACKAGECONFIG[assimp] = ",,assimp"
> >
> > EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
> >
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> >
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
> d-
> devel&data=01%7C01%7Ctom.hochstein%40nxp.com%7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [meta-qt5][PATCH v2] qt3d: Add assimp dependency
2017-02-08 17:42 ` Tom Hochstein
@ 2017-02-08 19:43 ` Martin Jansa
2017-02-09 8:38 ` Samuli Piippo
0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2017-02-08 19:43 UTC (permalink / raw)
To: openembedded-devel
RSS:
http://git.openembedded.org/openembedded-core/commit/?id=809746f56df4b91af014bf6a3f28997d6698ac78
http://lists.openembedded.org/pipermail/openembedded-architecture/2017-January/000384.html
and following threads
For morty and older releases you need to disable autodetection in qt3d
sources when the assimp PACKAGECONFIG is not enabled (see PACKAGECONFIG in
other recipes for some examples how to do it - but for qt5 it's often
tricky as it rarely has enable/disable options usable in configure and has
to be patched).
Otherwise assimp can still be detected when it's built as a dependency of
some other recipe and might be removed from sysroot while qt3d build is
already running and causing the issues you were trying to fix.
On Wed, Feb 8, 2017 at 6:42 PM, Tom Hochstein <tom.hochstein@nxp.com> wrote:
>
>
> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org [mailto:
> openembedded-devel-bounces@lists.openembedded.org] On
> > Behalf Of Martin Jansa
> > Sent: Tuesday, February 07, 2017 6:01 AM
> > To: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency
> >
> > On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:
> > > Fix build error:
> > >
> > > fatal error: assimp/Importer.hpp: No such file or directory
> >
> > I'm was able to build qt3d without this dependency, is there something
> > in your config which enabled it? Or is it autodetected from sysroot
> > which wont be an issue anymore with master and RSS, but your change
> > doesn't fix the autodetection for older branches.
>
> We do enable assimp from another recipe.
>
> I am unable to reproduce the original problem either.
>
> Without the explicit dependency, it would seem that the build would at
> best be non-deterministic, enabling or disabling assimp support based
> solely on the timing of the Yocto tasks. I'm not aware of the technologies
> you allude to. Do they provide some determinism for this case?
>
> >
> > > Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
> > > ---
> > > recipes-qt/qt5/qt3d_git.bb | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
> > > index 2276c36..7c31213 100644
> > > --- a/recipes-qt/qt5/qt3d_git.bb
> > > +++ b/recipes-qt/qt5/qt3d_git.bb
> > > @@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
> > > PACKAGECONFIG_class-native ??= "tools-only"
> > > PACKAGECONFIG_class-nativesdk ??= "tools-only"
> > > PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
> > > +PACKAGECONFIG[assimp] = ",,assimp"
> > >
> > > EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
> > >
> > > --
> > > 1.9.1
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > >
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.
> openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
> > d-
> > devel&data=01%7C01%7Ctom.hochstein%40nxp.com%
> 7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635
> > %7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0
> >
> > --
> > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [meta-qt5][PATCH v2] qt3d: Add assimp dependency
2017-02-08 19:43 ` Martin Jansa
@ 2017-02-09 8:38 ` Samuli Piippo
2017-02-09 15:03 ` Tom Hochstein
0 siblings, 1 reply; 9+ messages in thread
From: Samuli Piippo @ 2017-02-09 8:38 UTC (permalink / raw)
To: openembedded-devel
In 5.8 (master), there is now a "system-assimp" PACKAGECONFIG option
that correctly enables/disables assimp dependency.
>>>> fatal error: assimp/Importer.hpp: No such file or directory
Is this really a fatal build error or a config test error?
In case qt3d doesn't find system assimp, it will use its internal copy
of it.
On 02/08/2017 09:43 PM, Martin Jansa wrote:
> RSS:
> http://git.openembedded.org/openembedded-core/commit/?id=809746f56df4b91af014bf6a3f28997d6698ac78
> http://lists.openembedded.org/pipermail/openembedded-architecture/2017-January/000384.html
> and following threads
>
> For morty and older releases you need to disable autodetection in qt3d
> sources when the assimp PACKAGECONFIG is not enabled (see PACKAGECONFIG in
> other recipes for some examples how to do it - but for qt5 it's often
> tricky as it rarely has enable/disable options usable in configure and has
> to be patched).
>
> Otherwise assimp can still be detected when it's built as a dependency of
> some other recipe and might be removed from sysroot while qt3d build is
> already running and causing the issues you were trying to fix.
>
> On Wed, Feb 8, 2017 at 6:42 PM, Tom Hochstein <tom.hochstein@nxp.com> wrote:
>
>>
>>
>>> -----Original Message-----
>>> From: openembedded-devel-bounces@lists.openembedded.org [mailto:
>> openembedded-devel-bounces@lists.openembedded.org] On
>>> Behalf Of Martin Jansa
>>> Sent: Tuesday, February 07, 2017 6:01 AM
>>> To: openembedded-devel@lists.openembedded.org
>>> Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency
>>>
>>> On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:
>>>> Fix build error:
>>>>
>>>> fatal error: assimp/Importer.hpp: No such file or directory
>>>
>>> I'm was able to build qt3d without this dependency, is there something
>>> in your config which enabled it? Or is it autodetected from sysroot
>>> which wont be an issue anymore with master and RSS, but your change
>>> doesn't fix the autodetection for older branches.
>>
>> We do enable assimp from another recipe.
>>
>> I am unable to reproduce the original problem either.
>>
>> Without the explicit dependency, it would seem that the build would at
>> best be non-deterministic, enabling or disabling assimp support based
>> solely on the timing of the Yocto tasks. I'm not aware of the technologies
>> you allude to. Do they provide some determinism for this case?
>>
>>>
>>>> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
>>>> ---
>>>> recipes-qt/qt5/qt3d_git.bb | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
>>>> index 2276c36..7c31213 100644
>>>> --- a/recipes-qt/qt5/qt3d_git.bb
>>>> +++ b/recipes-qt/qt5/qt3d_git.bb
>>>> @@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
>>>> PACKAGECONFIG_class-native ??= "tools-only"
>>>> PACKAGECONFIG_class-nativesdk ??= "tools-only"
>>>> PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
>>>> +PACKAGECONFIG[assimp] = ",,assimp"
>>>>
>>>> EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
>>>>
>>>> --
>>>> 1.9.1
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel@lists.openembedded.org
>>>>
>>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.
>> openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
>>> d-
>>> devel&data=01%7C01%7Ctom.hochstein%40nxp.com%
>> 7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635
>>> %7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0
>>>
>>> --
>>> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [meta-qt5][PATCH v2] qt3d: Add assimp dependency
2017-02-09 8:38 ` Samuli Piippo
@ 2017-02-09 15:03 ` Tom Hochstein
0 siblings, 0 replies; 9+ messages in thread
From: Tom Hochstein @ 2017-02-09 15:03 UTC (permalink / raw)
To: openembedded-devel@lists.openembedded.org
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On
> Behalf Of Samuli Piippo
> Sent: Thursday, February 09, 2017 2:39 AM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency
>
> In 5.8 (master), there is now a "system-assimp" PACKAGECONFIG option
> that correctly enables/disables assimp dependency.
>
> >>>> fatal error: assimp/Importer.hpp: No such file or directory
>
> Is this really a fatal build error or a config test error?
> In case qt3d doesn't find system assimp, it will use its internal copy
> of it.
As I remember it was a build error, but unfortunately I don't have the surrounding error text to confirm this and cannot reproduce the error.
>
>
> On 02/08/2017 09:43 PM, Martin Jansa wrote:
> > RSS:
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.openembedded.org%2Fopenembedded-
> core%2Fcommit%2F%3Fid%3D809746f56df4b91af014bf6a3f28997d6698ac78&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04
> 444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=slwG0AloaQo4oRoDA3GHD6BmPdQ7bzw02GkRJHlp
> aWQ%3D&reserved=0
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fpipermail%2Fopenembedded-
> architecture%2F2017-
> January%2F000384.html&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0&sdata=NL7A%2B0Dj6Mgt4osVT10RGZM3Iz0jpLzTwQemNqD%2BYgA%3D&reserved=0
> > and following threads
> >
> > For morty and older releases you need to disable autodetection in qt3d
> > sources when the assimp PACKAGECONFIG is not enabled (see PACKAGECONFIG in
> > other recipes for some examples how to do it - but for qt5 it's often
> > tricky as it rarely has enable/disable options usable in configure and has
> > to be patched).
> >
> > Otherwise assimp can still be detected when it's built as a dependency of
> > some other recipe and might be removed from sysroot while qt3d build is
> > already running and causing the issues you were trying to fix.
> >
> > On Wed, Feb 8, 2017 at 6:42 PM, Tom Hochstein <tom.hochstein@nxp.com> wrote:
> >
> >>
> >>
> >>> -----Original Message-----
> >>> From: openembedded-devel-bounces@lists.openembedded.org [mailto:
> >> openembedded-devel-bounces@lists.openembedded.org] On
> >>> Behalf Of Martin Jansa
> >>> Sent: Tuesday, February 07, 2017 6:01 AM
> >>> To: openembedded-devel@lists.openembedded.org
> >>> Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency
> >>>
> >>> On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:
> >>>> Fix build error:
> >>>>
> >>>> fatal error: assimp/Importer.hpp: No such file or directory
> >>>
> >>> I'm was able to build qt3d without this dependency, is there something
> >>> in your config which enabled it? Or is it autodetected from sysroot
> >>> which wont be an issue anymore with master and RSS, but your change
> >>> doesn't fix the autodetection for older branches.
> >>
> >> We do enable assimp from another recipe.
> >>
> >> I am unable to reproduce the original problem either.
> >>
> >> Without the explicit dependency, it would seem that the build would at
> >> best be non-deterministic, enabling or disabling assimp support based
> >> solely on the timing of the Yocto tasks. I'm not aware of the technologies
> >> you allude to. Do they provide some determinism for this case?
> >>
> >>>
> >>>> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
> >>>> ---
> >>>> recipes-qt/qt5/qt3d_git.bb | 1 +
> >>>> 1 file changed, 1 insertion(+)
> >>>>
> >>>> diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
> >>>> index 2276c36..7c31213 100644
> >>>> --- a/recipes-qt/qt5/qt3d_git.bb
> >>>> +++ b/recipes-qt/qt5/qt3d_git.bb
> >>>> @@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
> >>>> PACKAGECONFIG_class-native ??= "tools-only"
> >>>> PACKAGECONFIG_class-nativesdk ??= "tools-only"
> >>>> PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
> >>>> +PACKAGECONFIG[assimp] = ",,assimp"
> >>>>
> >>>> EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
> >>>>
> >>>> --
> >>>> 1.9.1
> >>>>
> >>>> --
> >>>> _______________________________________________
> >>>> Openembedded-devel mailing list
> >>>> Openembedded-devel@lists.openembedded.org
> >>>>
> >>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.
> >> openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
> >>> d-
> >>> devel&data=01%7C01%7Ctom.hochstein%40nxp.com%
> >> 7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635
> >>> %7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0
> >>>
> >>> --
> >>> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
> d-
> devel&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0&sdata=gs5n%2FZqFAO8HLTQOrOi4nql3wTRykYUUhM9BCGb9sRY%3D&reserved=0
> >>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
> d-
> devel&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0&sdata=gs5n%2FZqFAO8HLTQOrOi4nql3wTRykYUUhM9BCGb9sRY%3D&reserved=0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [meta-qt5][PATCH v2] qt3d: Add assimp dependency
@ 2017-01-20 23:41 Tom Hochstein
2017-01-20 23:48 ` Tom Hochstein
2017-01-25 15:29 ` Martin Jansa
0 siblings, 2 replies; 9+ messages in thread
From: Tom Hochstein @ 2017-01-20 23:41 UTC (permalink / raw)
To: openembedded-devel
Fix build error:
fatal error: assimp/Importer.hpp: No such file or directory
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
---
recipes-qt/qt5/qt3d_git.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
index 9708ec9..d8f943f 100644
--- a/recipes-qt/qt5/qt3d_git.bb
+++ b/recipes-qt/qt5/qt3d_git.bb
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \
"
DEPENDS += "qtbase"
-DEPENDS_class-target += "qtdeclarative qt3d-native"
+DEPENDS_class-target += "qtdeclarative qt3d-native assimp"
SRC_URI += " \
file://0001-Allow-a-tools-only-build.patch \
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [meta-qt5][PATCH v2] qt3d: Add assimp dependency
2017-01-20 23:41 Tom Hochstein
@ 2017-01-20 23:48 ` Tom Hochstein
2017-01-25 15:29 ` Martin Jansa
1 sibling, 0 replies; 9+ messages in thread
From: Tom Hochstein @ 2017-01-20 23:48 UTC (permalink / raw)
To: openembedded-devel@lists.openembedded.org
First version was based on morty. This one is on master.
Tom
-----Original Message-----
From: Tom Hochstein
Sent: Friday, January 20, 2017 5:41 PM
To: openembedded-devel@lists.openembedded.org
Cc: Tom Hochstein <tom.hochstein@nxp.com>
Subject: [meta-qt5][PATCH v2] qt3d: Add assimp dependency
Fix build error:
fatal error: assimp/Importer.hpp: No such file or directory
Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
---
recipes-qt/qt5/qt3d_git.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
index 9708ec9..d8f943f 100644
--- a/recipes-qt/qt5/qt3d_git.bb
+++ b/recipes-qt/qt5/qt3d_git.bb
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \
"
DEPENDS += "qtbase"
-DEPENDS_class-target += "qtdeclarative qt3d-native"
+DEPENDS_class-target += "qtdeclarative qt3d-native assimp"
SRC_URI += " \
file://0001-Allow-a-tools-only-build.patch \
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [meta-qt5][PATCH v2] qt3d: Add assimp dependency
2017-01-20 23:41 Tom Hochstein
2017-01-20 23:48 ` Tom Hochstein
@ 2017-01-25 15:29 ` Martin Jansa
1 sibling, 0 replies; 9+ messages in thread
From: Martin Jansa @ 2017-01-25 15:29 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]
On Fri, Jan 20, 2017 at 05:41:22PM -0600, Tom Hochstein wrote:
> Fix build error:
>
> fatal error: assimp/Importer.hpp: No such file or directory
unfortunately this would be the first dependency on meta-oe from
meta-qt5 and layer.conf currently lists core as the only dependency.
Is it possible to make this dependency optional with PACKAGECONFIG?
Otherwise you would need to add meta-oe to layer.conf and README
dependencies.
>
> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
> ---
> recipes-qt/qt5/qt3d_git.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-qt/qt5/qt3d_git.bb b/recipes-qt/qt5/qt3d_git.bb
> index 9708ec9..d8f943f 100644
> --- a/recipes-qt/qt5/qt3d_git.bb
> +++ b/recipes-qt/qt5/qt3d_git.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \
> "
>
> DEPENDS += "qtbase"
> -DEPENDS_class-target += "qtdeclarative qt3d-native"
> +DEPENDS_class-target += "qtdeclarative qt3d-native assimp"
>
> SRC_URI += " \
> file://0001-Allow-a-tools-only-build.patch \
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-02-09 15:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-27 22:54 [meta-qt5][PATCH v2] qt3d: Add assimp dependency Tom Hochstein
2017-02-07 12:00 ` Martin Jansa
2017-02-08 17:42 ` Tom Hochstein
2017-02-08 19:43 ` Martin Jansa
2017-02-09 8:38 ` Samuli Piippo
2017-02-09 15:03 ` Tom Hochstein
-- strict thread matches above, loose matches on Subject: below --
2017-01-20 23:41 Tom Hochstein
2017-01-20 23:48 ` Tom Hochstein
2017-01-25 15:29 ` Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.