* [patch] drm/radeon: remove some dead code
@ 2017-02-07 13:16 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-02-07 13:16 UTC (permalink / raw)
To: Alex Deucher
Cc: Christian König, David Airlie, amd-gfx, dri-devel,
kernel-janitors
If "rdev->bios" is NULL then we don't need to free it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
index 00cfb5d2875f..04c0ed41374f 100644
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bios.c
@@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
vhdr->ImageLength,
GFP_KERNEL);
- if (!rdev->bios) {
- kfree(rdev->bios);
+ if (!rdev->bios)
return false;
- }
return true;
}
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] drm/radeon: remove some dead code
@ 2017-02-07 13:16 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-02-07 13:16 UTC (permalink / raw)
To: Alex Deucher
Cc: Christian König, David Airlie, amd-gfx, dri-devel,
kernel-janitors
If "rdev->bios" is NULL then we don't need to free it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
index 00cfb5d2875f..04c0ed41374f 100644
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bios.c
@@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
vhdr->ImageLength,
GFP_KERNEL);
- if (!rdev->bios) {
- kfree(rdev->bios);
+ if (!rdev->bios)
return false;
- }
return true;
}
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] drm/radeon: remove some dead code
2017-02-07 13:16 ` Dan Carpenter
@ 2017-02-08 0:43 ` Michel Dänzer
-1 siblings, 0 replies; 6+ messages in thread
From: Michel Dänzer @ 2017-02-08 0:43 UTC (permalink / raw)
To: Dan Carpenter, Alex Deucher
Cc: David Airlie, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Christian König,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 07/02/17 10:16 PM, Dan Carpenter wrote:
> If "rdev->bios" is NULL then we don't need to free it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
> index 00cfb5d2875f..04c0ed41374f 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
> vhdr->ImageLength,
> GFP_KERNEL);
>
> - if (!rdev->bios) {
> - kfree(rdev->bios);
> + if (!rdev->bios)
> return false;
> - }
> return true;
Could be simplified further to
return rdev->bios != NULL;
or maybe
return !!rdev->bios;
Either way,
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] drm/radeon: remove some dead code
@ 2017-02-08 0:43 ` Michel Dänzer
0 siblings, 0 replies; 6+ messages in thread
From: Michel Dänzer @ 2017-02-08 0:43 UTC (permalink / raw)
To: Dan Carpenter, Alex Deucher
Cc: David Airlie, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Christian König,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 07/02/17 10:16 PM, Dan Carpenter wrote:
> If "rdev->bios" is NULL then we don't need to free it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
> index 00cfb5d2875f..04c0ed41374f 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
> vhdr->ImageLength,
> GFP_KERNEL);
>
> - if (!rdev->bios) {
> - kfree(rdev->bios);
> + if (!rdev->bios)
> return false;
> - }
> return true;
Could be simplified further to
return rdev->bios != NULL;
or maybe
return !!rdev->bios;
Either way,
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] drm/radeon: remove some dead code
2017-02-07 13:16 ` Dan Carpenter
@ 2017-02-09 2:11 ` Alex Deucher
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2017-02-09 2:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alex Deucher, amd-gfx list,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Christian König,
Maling list - DRI developers
On Tue, Feb 7, 2017 at 8:16 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> If "rdev->bios" is NULL then we don't need to free it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
applied. thanks!
>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
> index 00cfb5d2875f..04c0ed41374f 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
> vhdr->ImageLength,
> GFP_KERNEL);
>
> - if (!rdev->bios) {
> - kfree(rdev->bios);
> + if (!rdev->bios)
> return false;
> - }
> return true;
> }
> }
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] drm/radeon: remove some dead code
@ 2017-02-09 2:11 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2017-02-09 2:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alex Deucher, amd-gfx list,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Christian König,
Maling list - DRI developers
On Tue, Feb 7, 2017 at 8:16 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> If "rdev->bios" is NULL then we don't need to free it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
applied. thanks!
>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
> index 00cfb5d2875f..04c0ed41374f 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
> vhdr->ImageLength,
> GFP_KERNEL);
>
> - if (!rdev->bios) {
> - kfree(rdev->bios);
> + if (!rdev->bios)
> return false;
> - }
> return true;
> }
> }
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-09 2:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-07 13:16 [patch] drm/radeon: remove some dead code Dan Carpenter
2017-02-07 13:16 ` Dan Carpenter
2017-02-08 0:43 ` Michel Dänzer
2017-02-08 0:43 ` Michel Dänzer
2017-02-09 2:11 ` Alex Deucher
2017-02-09 2:11 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.