From: Dan Carpenter <dan.carpenter@oracle.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: alsa-devel@alsa-project.org,
"Wei Yongjun" <yongjun_wei@trendmicro.com.cn>,
kernel-janitors@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Mark Brown" <broonie@kernel.org>,
"Mylène Josserand" <mylene.josserand@free-electrons.com>
Subject: Re: [patch] ASoC: sun4i-i2s: remove some dead code
Date: Tue, 7 Feb 2017 16:50:08 +0300 [thread overview]
Message-ID: <20170207135008.GL11103@mwanda> (raw)
In-Reply-To: <20170207134215.f47cufvs7tngrabk@lukather>
On Tue, Feb 07, 2017 at 02:42:15PM +0100, Maxime Ripard wrote:
> > - if (!IS_ERR(i2s->rst)) {
> > - ret = reset_control_deassert(i2s->rst);
> > - if (ret) {
> > - dev_err(&pdev->dev,
> > - "Failed to deassert the reset control\n");
> > - return -EINVAL;
> > - }
> > + ret = reset_control_deassert(i2s->rst);
> > + if (ret) {
> > + dev_err(&pdev->dev,
> > + "Failed to deassert the reset control\n");
> > + return -EINVAL;
>
> In the case where has_reset is false, rst is NULL and will trigger a
> WARN_ON in reset_control_deassert.
>
No it won't. reset_control_deassert(NULL) just returns success
immediately.
> The proper fix would be to move it in the previous if block, or to
> change the IS_ERR check for a NULL check.
We could move it as a clean up but the current code works. Checking for
NULL is wrong.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: alsa-devel@alsa-project.org,
"Wei Yongjun" <yongjun_wei@trendmicro.com.cn>,
kernel-janitors@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Mark Brown" <broonie@kernel.org>,
"Mylène Josserand" <mylene.josserand@free-electrons.com>
Subject: Re: [patch] ASoC: sun4i-i2s: remove some dead code
Date: Tue, 07 Feb 2017 13:50:08 +0000 [thread overview]
Message-ID: <20170207135008.GL11103@mwanda> (raw)
In-Reply-To: <20170207134215.f47cufvs7tngrabk@lukather>
On Tue, Feb 07, 2017 at 02:42:15PM +0100, Maxime Ripard wrote:
> > - if (!IS_ERR(i2s->rst)) {
> > - ret = reset_control_deassert(i2s->rst);
> > - if (ret) {
> > - dev_err(&pdev->dev,
> > - "Failed to deassert the reset control\n");
> > - return -EINVAL;
> > - }
> > + ret = reset_control_deassert(i2s->rst);
> > + if (ret) {
> > + dev_err(&pdev->dev,
> > + "Failed to deassert the reset control\n");
> > + return -EINVAL;
>
> In the case where has_reset is false, rst is NULL and will trigger a
> WARN_ON in reset_control_deassert.
>
No it won't. reset_control_deassert(NULL) just returns success
immediately.
> The proper fix would be to move it in the previous if block, or to
> change the IS_ERR check for a NULL check.
We could move it as a clean up but the current code works. Checking for
NULL is wrong.
regards,
dan carpenter
next prev parent reply other threads:[~2017-02-07 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 13:19 [patch] ASoC: sun4i-i2s: remove some dead code Dan Carpenter
2017-02-07 13:19 ` Dan Carpenter
2017-02-07 13:42 ` Maxime Ripard
2017-02-07 13:42 ` Maxime Ripard
2017-02-07 13:50 ` Dan Carpenter [this message]
2017-02-07 13:50 ` Dan Carpenter
2017-02-08 8:58 ` Maxime Ripard
2017-02-08 8:58 ` Maxime Ripard
2017-02-08 9:01 ` Chen-Yu Tsai
2017-02-08 9:01 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207135008.GL11103@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mylene.josserand@free-electrons.com \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.