* [PATCH] staging: sm750fb: Enclose macro arguments in parentheses
@ 2017-02-07 19:11 Matthieu Simon
2017-02-07 19:48 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Matthieu Simon @ 2017-02-07 19:11 UTC (permalink / raw)
To: linux-fbdev
checkpatch noticed possible precedence issues resulting in the definition
of PEEK32 and POKE32. So, these arguments should be enclosed in
parentheses.
Signed-off-by: Matthieu Simon <gmatthsim@gmail.com>
---
drivers/staging/sm750fb/ddk750_chip.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h
index e63b8b293816..a5f910344373 100644
--- a/drivers/staging/sm750fb/ddk750_chip.h
+++ b/drivers/staging/sm750fb/ddk750_chip.h
@@ -10,8 +10,8 @@
#include <linux/uaccess.h>
/* software control endianness */
-#define PEEK32(addr) readl(addr + mmio750)
-#define POKE32(addr, data) writel(data, addr + mmio750)
+#define PEEK32(addr) readl((addr) + mmio750)
+#define POKE32(addr, data) writel((data), (addr) + mmio750)
extern void __iomem *mmio750;
--
Matthieu
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm750fb: Enclose macro arguments in parentheses
2017-02-07 19:11 [PATCH] staging: sm750fb: Enclose macro arguments in parentheses Matthieu Simon
@ 2017-02-07 19:48 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-02-07 19:48 UTC (permalink / raw)
To: linux-fbdev
On Tue, Feb 07, 2017 at 11:11:22AM -0800, Matthieu Simon wrote:
> checkpatch noticed possible precedence issues resulting in the definition
> of PEEK32 and POKE32. So, these arguments should be enclosed in
> parentheses.
>
> Signed-off-by: Matthieu Simon <gmatthsim@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h
> index e63b8b293816..a5f910344373 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.h
> +++ b/drivers/staging/sm750fb/ddk750_chip.h
> @@ -10,8 +10,8 @@
> #include <linux/uaccess.h>
>
> /* software control endianness */
> -#define PEEK32(addr) readl(addr + mmio750)
> -#define POKE32(addr, data) writel(data, addr + mmio750)
> +#define PEEK32(addr) readl((addr) + mmio750)
> +#define POKE32(addr, data) writel((data), (addr) + mmio750)
Those are funny macros, how about just making them an inline function so
that we get the correct type-checking and better documentation as to
what is going on with them?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-07 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-07 19:11 [PATCH] staging: sm750fb: Enclose macro arguments in parentheses Matthieu Simon
2017-02-07 19:48 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.