* [patch] pinctrl: samsung: checking for IS_ERR() instead of NULL
@ 2017-02-08 7:23 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-02-08 7:23 UTC (permalink / raw)
To: Tomasz Figa, Chanwoo Choi
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Linus Walleij,
linux-samsung-soc, linux-gpio, kernel-janitors
devm_ioremap() returns NULL on error. It doesn't return error pointers.
Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index d79eadad6c5f..35b9d400d5c6 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -990,7 +990,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
res = platform_get_resource(pdev, IORESOURCE_MEM, i);
virt_base[i] = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
- if (IS_ERR(virt_base[i]))
+ if (!virt_base[i])
return ERR_PTR(-EIO);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] pinctrl: samsung: checking for IS_ERR() instead of NULL
@ 2017-02-08 7:23 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-02-08 7:23 UTC (permalink / raw)
To: Tomasz Figa, Chanwoo Choi
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Linus Walleij,
linux-samsung-soc, linux-gpio, kernel-janitors
devm_ioremap() returns NULL on error. It doesn't return error pointers.
Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index d79eadad6c5f..35b9d400d5c6 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -990,7 +990,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d,
res = platform_get_resource(pdev, IORESOURCE_MEM, i);
virt_base[i] = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
- if (IS_ERR(virt_base[i]))
+ if (!virt_base[i])
return ERR_PTR(-EIO);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] pinctrl: samsung: checking for IS_ERR() instead of NULL
2017-02-08 7:23 ` Dan Carpenter
@ 2017-02-08 8:41 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2017-02-08 8:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tomasz Figa, Chanwoo Choi, Sylwester Nawrocki, Linus Walleij,
linux-samsung-soc, linux-gpio, kernel-janitors
On Wed, Feb 8, 2017 at 9:23 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> devm_ioremap() returns NULL on error. It doesn't return error pointers.
>
> Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Fix already sent by Wei:
https://www.spinics.net/lists/arm-kernel/msg560747.html
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] pinctrl: samsung: checking for IS_ERR() instead of NULL
@ 2017-02-08 8:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2017-02-08 8:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tomasz Figa, Chanwoo Choi, Sylwester Nawrocki, Linus Walleij,
linux-samsung-soc, linux-gpio, kernel-janitors
On Wed, Feb 8, 2017 at 9:23 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> devm_ioremap() returns NULL on error. It doesn't return error pointers.
>
> Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Fix already sent by Wei:
https://www.spinics.net/lists/arm-kernel/msg560747.html
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-08 8:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-08 7:23 [patch] pinctrl: samsung: checking for IS_ERR() instead of NULL Dan Carpenter
2017-02-08 7:23 ` Dan Carpenter
2017-02-08 8:41 ` Krzysztof Kozlowski
2017-02-08 8:41 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.