All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: ananth@linux.vnet.ibm.com, mingo@kernel.org, mpe@ellerman.id.au,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3] kprobes: introduce weak variant of kprobe_exceptions_notify
Date: Wed, 8 Feb 2017 10:45:52 +0900	[thread overview]
Message-ID: <20170208104552.497ea03171826cfb9e63b557@kernel.org> (raw)
In-Reply-To: <b0894e503195b13a5ed6319e897e673f376a748d.1486496890.git.naveen.n.rao@linux.vnet.ibm.com>

On Wed,  8 Feb 2017 01:24:14 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:

> kprobe_exceptions_notify() is not used on some of the architectures such
> as arm[64] and powerpc anymore. Introduce a weak variant for such
> architectures.
> 

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

for all patches in this series.

Thank you!

> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
>  kernel/kprobes.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 43460104f119..60a702a05684 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1705,6 +1705,12 @@ void unregister_kprobes(struct kprobe **kps, int num)
>  }
>  EXPORT_SYMBOL_GPL(unregister_kprobes);
>  
> +int __weak __kprobes kprobe_exceptions_notify(struct notifier_block *self,
> +					      unsigned long val, void *data)
> +{
> +	return NOTIFY_DONE;
> +}
> +
>  static struct notifier_block kprobe_exceptions_nb = {
>  	.notifier_call = kprobe_exceptions_notify,
>  	.priority = 0x7fffffff /* we need to be notified first */
> -- 
> 2.11.0
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: mhiramat@kernel.org (Masami Hiramatsu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] kprobes: introduce weak variant of kprobe_exceptions_notify
Date: Wed, 8 Feb 2017 10:45:52 +0900	[thread overview]
Message-ID: <20170208104552.497ea03171826cfb9e63b557@kernel.org> (raw)
In-Reply-To: <b0894e503195b13a5ed6319e897e673f376a748d.1486496890.git.naveen.n.rao@linux.vnet.ibm.com>

On Wed,  8 Feb 2017 01:24:14 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:

> kprobe_exceptions_notify() is not used on some of the architectures such
> as arm[64] and powerpc anymore. Introduce a weak variant for such
> architectures.
> 

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

for all patches in this series.

Thank you!

> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
>  kernel/kprobes.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 43460104f119..60a702a05684 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1705,6 +1705,12 @@ void unregister_kprobes(struct kprobe **kps, int num)
>  }
>  EXPORT_SYMBOL_GPL(unregister_kprobes);
>  
> +int __weak __kprobes kprobe_exceptions_notify(struct notifier_block *self,
> +					      unsigned long val, void *data)
> +{
> +	return NOTIFY_DONE;
> +}
> +
>  static struct notifier_block kprobe_exceptions_nb = {
>  	.notifier_call = kprobe_exceptions_notify,
>  	.priority = 0x7fffffff /* we need to be notified first */
> -- 
> 2.11.0
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

  parent reply	other threads:[~2017-02-08  1:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 19:54 [PATCH 1/3] kprobes: introduce weak variant of kprobe_exceptions_notify Naveen N. Rao
2017-02-07 19:54 ` Naveen N. Rao
2017-02-07 19:54 ` [PATCH 2/3] arm: kprobes: remove kprobe_exceptions_notify Naveen N. Rao
2017-02-07 19:54   ` Naveen N. Rao
2017-03-06 18:07   ` Naveen N. Rao
2017-03-06 18:07     ` Naveen N. Rao
2017-03-06 18:38     ` Russell King - ARM Linux
2017-03-06 18:38       ` Russell King - ARM Linux
2017-03-06 19:04       ` Naveen N. Rao
2017-03-06 19:04         ` Naveen N. Rao
2017-03-06 19:04         ` [PATCH 1/2] " Naveen N. Rao
2017-03-06 19:04           ` Naveen N. Rao
2017-03-06 19:04         ` [PATCH 2/2] arm64: " Naveen N. Rao
2017-03-06 19:04           ` Naveen N. Rao
2017-02-07 19:54 ` [PATCH 3/3] powerpc: kprobes: remove kprobe_exceptions_notify() Naveen N. Rao
2017-02-07 19:54   ` Naveen N. Rao
2017-02-14 12:40   ` [3/3] " Michael Ellerman
2017-02-14 12:40     ` Michael Ellerman
2017-02-08  1:45 ` Masami Hiramatsu [this message]
2017-02-08  1:45   ` [PATCH 1/3] kprobes: introduce weak variant of kprobe_exceptions_notify Masami Hiramatsu
2017-02-10  3:41 ` Michael Ellerman
2017-02-10  3:41   ` Michael Ellerman
2017-02-10  7:50   ` Ingo Molnar
2017-02-10  7:50     ` Ingo Molnar
2017-02-13  8:32   ` Naveen N. Rao
2017-02-13  8:32     ` Naveen N. Rao
2017-02-14 12:40 ` [1/3] " Michael Ellerman
2017-02-14 12:40   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208104552.497ea03171826cfb9e63b557@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=ananth@linux.vnet.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.