From: Jiri Olsa <jolsa@redhat.com>
To: Hari Bathini <hbathini@linux.vnet.ibm.com>
Cc: ast@fb.com, peterz@infradead.org,
lkml <linux-kernel@vger.kernel.org>,
acme@kernel.org, alexander.shishkin@linux.intel.com,
mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
ebiederm@xmission.com, sargun@sargun.me,
Aravinda Prasad <aravinda@linux.vnet.ibm.com>,
brendan.d.gregg@gmail.com
Subject: Re: [PATCH v6 2/3] perf tool: add PERF_RECORD_NAMESPACES to include namespaces related info
Date: Wed, 8 Feb 2017 13:57:26 +0100 [thread overview]
Message-ID: <20170208125726.GB22166@krava> (raw)
In-Reply-To: <148654270963.27983.11333098688761605858.stgit@hbathini.in.ibm.com>
On Wed, Feb 08, 2017 at 02:01:49PM +0530, Hari Bathini wrote:
SNIP
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index ffac8ca..1946a17 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -875,6 +875,9 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
> signal(SIGTERM, sig_handler);
> signal(SIGSEGV, sigsegv_handler);
>
> + if (rec->opts.record_namespaces)
> + tool->namespace_events = true;
should we do this by default? seems like low traffic event
with info that should be always present
also in case we keep the --namespace option, please add
it to the record's doc
jirka
next prev parent reply other threads:[~2017-02-08 13:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 8:31 [PATCH v6 0/3] perf: add support for analyzing events for containers Hari Bathini
2017-02-08 8:31 ` [PATCH v6 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info Hari Bathini
2017-02-16 10:28 ` Peter Zijlstra
2017-02-16 10:36 ` Peter Zijlstra
2017-02-20 4:11 ` Hari Bathini
2017-02-16 11:25 ` Eric W. Biederman
2017-02-16 11:47 ` Peter Zijlstra
2017-02-20 4:16 ` Hari Bathini
2017-02-08 8:31 ` [PATCH v6 2/3] perf tool: " Hari Bathini
2017-02-08 12:57 ` Jiri Olsa
2017-02-08 12:57 ` Jiri Olsa [this message]
2017-02-08 12:57 ` Jiri Olsa
2017-02-21 14:03 ` Hari Bathini
2017-02-08 8:32 ` [PATCH v6 3/3] perf tool: add cgroup identifier entry in perf report Hari Bathini
2017-02-16 6:20 ` [PATCH v6 0/3] perf: add support for analyzing events for containers Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208125726.GB22166@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=aravinda@linux.vnet.ibm.com \
--cc=ast@fb.com \
--cc=brendan.d.gregg@gmail.com \
--cc=daniel@iogearbox.net \
--cc=ebiederm@xmission.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.