All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUGFIX PATCH tip/master 2/3] kprobes/arm64: Fix a possible deadlock case in kretprobe
Date: Wed, 8 Feb 2017 15:06:55 +0000	[thread overview]
Message-ID: <20170208150654.GJ3986@arm.com> (raw)
In-Reply-To: <148648038381.30949.1443281264586280005.stgit@devbox>

[adding linux-arm-kernel]

On Wed, Feb 08, 2017 at 12:13:14AM +0900, Masami Hiramatsu wrote:
> Similar to x86 kretprobe deadlock issue, arm64 also implements
> kretprobe-booster (trampoline code directly call handler.)
> So it has same deadlock issue if there are 2 kretprobes on
> normal function and the function called from FIQ (or anywhere
> which can be invoked when local_irq_disabled).

We don't support FIQ on arm64, so I'm not worried about that particular
case. What are the other cases? I can think of debug exceptions, but those
shouldn't be generally kprobe-able, and taking data aborts in things like
get_user/put_user. Are those affected by this bug?

Either way, could you please expand the commit message like you have
for x86? It makes it much easier to understand the change when looking
back at the log in future.

Thanks,

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H . Peter Anvin" <hpa@zytor.com>, Jon Medhurst <tixy@linaro.org>,
	Wang Nan <wangnan0@huawei.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"David A . Long" <dave.long@linaro.org>,
	Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [BUGFIX PATCH tip/master 2/3] kprobes/arm64: Fix a possible deadlock case in kretprobe
Date: Wed, 8 Feb 2017 15:06:55 +0000	[thread overview]
Message-ID: <20170208150654.GJ3986@arm.com> (raw)
In-Reply-To: <148648038381.30949.1443281264586280005.stgit@devbox>

[adding linux-arm-kernel]

On Wed, Feb 08, 2017 at 12:13:14AM +0900, Masami Hiramatsu wrote:
> Similar to x86 kretprobe deadlock issue, arm64 also implements
> kretprobe-booster (trampoline code directly call handler.)
> So it has same deadlock issue if there are 2 kretprobes on
> normal function and the function called from FIQ (or anywhere
> which can be invoked when local_irq_disabled).

We don't support FIQ on arm64, so I'm not worried about that particular
case. What are the other cases? I can think of debug exceptions, but those
shouldn't be generally kprobe-able, and taking data aborts in things like
get_user/put_user. Are those affected by this bug?

Either way, could you please expand the commit message like you have
for x86? It makes it much easier to understand the change when looking
back at the log in future.

Thanks,

Will

  reply	other threads:[~2017-02-08 15:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 15:10 [BUGFIX PATCH tip/master 0/3] kprobes: Fix a possible deadlock in kretprobe Masami Hiramatsu
2017-02-07 15:12 ` [BUGFIX PATCH tip/master 1/3] kprobes/x86: Fix a possible deadlock case " Masami Hiramatsu
2017-02-07 15:13 ` [BUGFIX PATCH tip/master 2/3] kprobes/arm64: " Masami Hiramatsu
2017-02-08 15:06   ` Will Deacon [this message]
2017-02-08 15:06     ` Will Deacon
2017-02-08 21:45     ` Masami Hiramatsu
2017-02-08 21:45       ` Masami Hiramatsu
2017-02-07 15:14 ` [BUGFIX PATCH tip/master 3/3] kprobes/arm: " Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208150654.GJ3986@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.