From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Baoyou Xie <baoyou.xie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
jun.nie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
perex-/Fr2/VpizcU@public.gmane.org,
tiwai-IBi9RG/b67k@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org,
chen.chaokai-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org,
wang.qiang01-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org
Subject: Re: [PATCH v3 2/3] ASoC: zx-i2s: introduce pclk for zx2967 family
Date: Thu, 9 Feb 2017 09:48:09 +0800 [thread overview]
Message-ID: <20170209014807.GO3407@dragon> (raw)
In-Reply-To: <20170209005207.y6wcrzk43ngfslhl@rob-hp-laptop>
On Wed, Feb 08, 2017 at 06:52:07PM -0600, Rob Herring wrote:
> On Wed, Feb 08, 2017 at 11:02:34AM +0800, Baoyou Xie wrote:
> > ZTE's zx2967 I2S controller driver introduces pclk, this
> > patch documents this fact.
>
> Now we have the same subject for patches 2 and 3.
>
> Personally, I'd prefer "dt-bindings: sound: blah...", but not enough to
> argue with Mark about it. If that is not the prefix, then it should at
> least have "binding" in the subject.
+1
The prefix of sound bindings is quite unique from other subsystems.
Looking at the prefix of Documentation/devicetree/bindings/sound/
commits, I'm always confused whether it's a pure binding commit
or just submitted as part of the driver patch. I feel that we
kinda lose the point of having a prefix.
Just my 2 cents.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com,
jun.nie@linaro.org, mturquette@baylibre.com,
sboyd@codeaurora.org, perex@perex.cz, tiwai@suse.com,
shawn.guo@linaro.org, vinod.koul@intel.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
mathieu.poirier@linaro.org, xie.baoyou@zte.com.cn,
chen.chaokai@zte.com.cn, wang.qiang01@zte.com.cn
Subject: Re: [PATCH v3 2/3] ASoC: zx-i2s: introduce pclk for zx2967 family
Date: Thu, 9 Feb 2017 09:48:09 +0800 [thread overview]
Message-ID: <20170209014807.GO3407@dragon> (raw)
In-Reply-To: <20170209005207.y6wcrzk43ngfslhl@rob-hp-laptop>
On Wed, Feb 08, 2017 at 06:52:07PM -0600, Rob Herring wrote:
> On Wed, Feb 08, 2017 at 11:02:34AM +0800, Baoyou Xie wrote:
> > ZTE's zx2967 I2S controller driver introduces pclk, this
> > patch documents this fact.
>
> Now we have the same subject for patches 2 and 3.
>
> Personally, I'd prefer "dt-bindings: sound: blah...", but not enough to
> argue with Mark about it. If that is not the prefix, then it should at
> least have "binding" in the subject.
+1
The prefix of sound bindings is quite unique from other subsystems.
Looking at the prefix of Documentation/devicetree/bindings/sound/
commits, I'm always confused whether it's a pure binding commit
or just submitted as part of the driver patch. I feel that we
kinda lose the point of having a prefix.
Just my 2 cents.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] ASoC: zx-i2s: introduce pclk for zx2967 family
Date: Thu, 9 Feb 2017 09:48:09 +0800 [thread overview]
Message-ID: <20170209014807.GO3407@dragon> (raw)
In-Reply-To: <20170209005207.y6wcrzk43ngfslhl@rob-hp-laptop>
On Wed, Feb 08, 2017 at 06:52:07PM -0600, Rob Herring wrote:
> On Wed, Feb 08, 2017 at 11:02:34AM +0800, Baoyou Xie wrote:
> > ZTE's zx2967 I2S controller driver introduces pclk, this
> > patch documents this fact.
>
> Now we have the same subject for patches 2 and 3.
>
> Personally, I'd prefer "dt-bindings: sound: blah...", but not enough to
> argue with Mark about it. If that is not the prefix, then it should at
> least have "binding" in the subject.
+1
The prefix of sound bindings is quite unique from other subsystems.
Looking at the prefix of Documentation/devicetree/bindings/sound/
commits, I'm always confused whether it's a pure binding commit
or just submitted as part of the driver patch. I feel that we
kinda lose the point of having a prefix.
Just my 2 cents.
Shawn
next prev parent reply other threads:[~2017-02-09 1:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 3:02 [PATCH v3 1/3] clk: zte: add i2s clocks for zx296718 Baoyou Xie
2017-02-08 3:02 ` Baoyou Xie
2017-02-08 3:02 ` Baoyou Xie
2017-02-08 3:02 ` [PATCH v3 2/3] ASoC: zx-i2s: introduce pclk for zx2967 family Baoyou Xie
2017-02-08 3:02 ` Baoyou Xie
2017-02-08 3:02 ` Baoyou Xie
2017-02-09 0:52 ` Rob Herring
2017-02-09 0:52 ` Rob Herring
2017-02-09 0:52 ` Rob Herring
2017-02-09 1:48 ` Shawn Guo [this message]
2017-02-09 1:48 ` Shawn Guo
2017-02-09 1:48 ` Shawn Guo
2017-02-09 12:06 ` Mark Brown
2017-02-09 12:06 ` Mark Brown
2017-02-09 12:06 ` Mark Brown
2017-02-09 22:47 ` Rob Herring
2017-02-09 22:47 ` Rob Herring
2017-02-09 22:47 ` Rob Herring
2017-02-08 3:02 ` [PATCH v3 3/3] " Baoyou Xie
2017-02-08 3:02 ` Baoyou Xie
2017-02-08 3:02 ` Baoyou Xie
2017-02-08 14:25 ` Shawn Guo
2017-02-08 14:25 ` Shawn Guo
2017-02-08 14:25 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209014807.GO3407@dragon \
--to=shawnguo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=baoyou.xie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=chen.chaokai-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jun.nie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wang.qiang01-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org \
--cc=xie.baoyou-Th6q7B73Y6EnDS1+zs4M5A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.