From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 4/4] perf diff: Change default setting to "delta-abs"
Date: Fri, 10 Feb 2017 16:36:14 +0900 [thread overview]
Message-ID: <20170210073614.24584-5-namhyung@kernel.org> (raw)
In-Reply-To: <20170210073614.24584-1-namhyung@kernel.org>
The "delta-abs" compute method will show most changed entries on top.
So users can easily see how much effect between the data. To see
original-style (sorted by baseline) use -o 0 option.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-diff.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 4b4004d41c6a..27300f2c665b 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -66,7 +66,7 @@ static bool force;
static bool show_period;
static bool show_formula;
static bool show_baseline_only;
-static unsigned int sort_compute;
+static unsigned int sort_compute = 1;
static s64 compute_wdiff_w1;
static s64 compute_wdiff_w2;
@@ -86,7 +86,7 @@ const char *compute_names[COMPUTE_MAX] = {
[COMPUTE_WEIGHTED_DIFF] = "wdiff",
};
-static int compute = COMPUTE_DELTA;
+static int compute = COMPUTE_DELTA_ABS;
static int compute_2_hpp[COMPUTE_MAX] = {
[COMPUTE_DELTA] = PERF_HPP_DIFF__DELTA,
--
2.11.0
next prev parent reply other threads:[~2017-02-10 7:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 7:36 [PATCHSET 0/4] perf diff: Introduce delta-abs compute method (v2) Namhyung Kim
2017-02-10 7:36 ` [PATCH v2 1/4] perf diff: Add 'delta-abs' compute method Namhyung Kim
2017-02-14 6:38 ` [tip:perf/core] " tip-bot for Namhyung Kim
2017-02-10 7:36 ` [PATCH v2 2/4] perf diff: Add diff.order config option Namhyung Kim
2017-02-14 6:38 ` [tip:perf/core] " tip-bot for Namhyung Kim
2017-02-10 7:36 ` [PATCH v2 3/4] perf diff: Add diff.compute " Namhyung Kim
2017-02-14 6:39 ` [tip:perf/core] " tip-bot for Namhyung Kim
2017-02-10 7:36 ` Namhyung Kim [this message]
2017-02-10 16:18 ` [PATCH v2.1 4/4] perf diff: Change default setting to "delta-abs" Namhyung Kim
2017-02-14 6:39 ` [tip:perf/core] " tip-bot for Namhyung Kim
2017-02-10 7:41 ` [PATCHSET 0/4] perf diff: Introduce delta-abs compute method (v2) Ingo Molnar
2017-02-10 9:14 ` Namhyung Kim
2017-02-10 10:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210073614.24584-5-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.