From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: vc04_services: remove unused functions
Date: Fri, 10 Feb 2017 15:40:34 +0300 [thread overview]
Message-ID: <20170210123928.GA4162@mwanda> (raw)
In-Reply-To: <78243491.gCbftNnyIb@wuerfel>
On Wed, Feb 08, 2017 at 11:42:21AM +0100, Arnd Bergmann wrote:
> On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote:
> > There is a bunch of vc04_services that we're still looking to merge in
> > the near future. Please hold off deleting these until we are further
> > along on that.
> >
>
> More generally speaking, I'd like to see all the
> -Wmissing-declarations/-Wmissing-prototypes warnings addressed
> in the kernel and turn on that warning by default.
>
> If there are parts of vc04_services that are intentionally
> left in place but currently unused, adding a declaration in the
> header file with a comment should be sufficient to prevent it
> from getting deleted or seeing bogus warnings.
Yeah. That's true. There really isn't a good reason to have these
warnings.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Alexander Alemayhu <alexander@alemayhu.com>,
devel@driverdev.osuosl.org, stefan.wahren@i2se.com,
daniels@collabora.com, swarren@wwwdotorg.org,
gregkh@linuxfoundation.org, lee@kernel.org,
linux-kernel@vger.kernel.org, eric@anholt.net,
mzoran@crowfest.net, linux-rpi-kernel@lists.infradead.org,
popcornmix@gmail.com, shorne@gmail.com
Subject: Re: [PATCH] staging: vc04_services: remove unused functions
Date: Fri, 10 Feb 2017 15:40:34 +0300 [thread overview]
Message-ID: <20170210123928.GA4162@mwanda> (raw)
In-Reply-To: <78243491.gCbftNnyIb@wuerfel>
On Wed, Feb 08, 2017 at 11:42:21AM +0100, Arnd Bergmann wrote:
> On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote:
> > There is a bunch of vc04_services that we're still looking to merge in
> > the near future. Please hold off deleting these until we are further
> > along on that.
> >
>
> More generally speaking, I'd like to see all the
> -Wmissing-declarations/-Wmissing-prototypes warnings addressed
> in the kernel and turn on that warning by default.
>
> If there are parts of vc04_services that are intentionally
> left in place but currently unused, adding a declaration in the
> header file with a comment should be sufficient to prevent it
> from getting deleted or seeing bogus warnings.
Yeah. That's true. There really isn't a good reason to have these
warnings.
regards,
dan carpenter
next prev parent reply other threads:[~2017-02-10 12:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 11:53 [PATCH] staging: vc04_services: remove unused functions Alexander Alemayhu
2017-02-07 11:53 ` Alexander Alemayhu
2017-02-07 12:09 ` Dan Carpenter
2017-02-07 12:09 ` Dan Carpenter
2017-02-07 19:10 ` Alexander Alemayhu
2017-02-07 19:10 ` Alexander Alemayhu
2017-02-07 21:13 ` Eric Anholt
2017-02-07 21:13 ` Eric Anholt
2017-02-07 22:19 ` Dan Carpenter
2017-02-07 22:19 ` Dan Carpenter
2017-02-08 1:43 ` Michael Zoran
2017-02-08 1:43 ` Michael Zoran
2017-02-08 10:42 ` Arnd Bergmann
2017-02-08 10:42 ` Arnd Bergmann
2017-02-10 12:40 ` Dan Carpenter [this message]
2017-02-10 12:40 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2017-03-14 19:14 [PATCH] staging: vc04_services: Remove " Jean-Baptiste Abbadie
2017-03-14 19:14 ` Jean-Baptiste Abbadie
2017-03-14 21:03 ` Stefan Wahren
2017-03-14 21:03 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210123928.GA4162@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.