From: Thierry Reding <thierry.reding@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: "Daniel Vetter" <daniel.vetter@intel.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v2 7/7] drm: Rename connector list iterator API
Date: Fri, 10 Feb 2017 18:48:06 +0100 [thread overview]
Message-ID: <20170210174806.GA5995@ulmo.ba.sec> (raw)
In-Reply-To: <20170210171414.21768-8-thierry.reding@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1240 bytes --]
On Fri, Feb 10, 2017 at 06:14:14PM +0100, Thierry Reding wrote:
[...]
> /**
> - * drm_connector_list_iter_get - initialize a connector_list iterator
> + * drm_connector_list_iter_begin - initialize a connector_list iterator
> * @dev: DRM device
> * @iter: connector_list iterator
> *
> * Sets @iter up to walk the &drm_mode_config.connector_list of @dev. @iter
> - * must always be cleaned up again by calling drm_connector_list_iter_put().
> + * must always be cleaned up again by calling drm_connector_list_iter_end().
> * Iteration itself happens using drm_connector_list_iter_next() or
> * drm_for_each_connector_iter().
> */
> -void drm_connector_list_iter_get(struct drm_device *dev,
> - struct drm_connector_list_iter *iter)
> +void drm_connector_list_iter_begin(struct drm_device *dev,
> + struct drm_connector_list_iter *iter)
> {
> iter->dev = dev;
> iter->conn = NULL;
> lock_acquire_shared_recursive(&connector_list_iter_dep_map, 0, 1, NULL, _RET_IP_);
> }
> -EXPORT_SYMBOL(drm_connector_list_iter_get);
> +EXPORT_SYMBOL(drm_connector_list_iter_end);
Erm... this should obviously have been drm_connector_list_iter_begin, no
idea why the build tests didn't catch this on the first run.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-02-10 17:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 17:14 [PATCH v2 0/7] drm: Introduce consistent reference counting APIs Thierry Reding
2017-02-10 17:14 ` [PATCH v2 1/7] drm: Rename drm_mode_object_get() Thierry Reding
2017-02-10 17:14 ` [PATCH v2 2/7] drm: Introduce drm_mode_object_{get,put}() Thierry Reding
2017-02-10 17:14 ` [PATCH v2 3/7] drm: Introduce drm_connector_{get,put}() Thierry Reding
2017-02-10 17:14 ` [PATCH v2 4/7] drm: Introduce drm_framebuffer_{get,put}() Thierry Reding
2017-02-10 17:14 ` [PATCH v2 5/7] drm: Introduce drm_gem_object_{get,put}() Thierry Reding
2017-02-10 17:14 ` [PATCH v2 6/7] drm: Introduce drm_property_blob_{get,put}() Thierry Reding
2017-02-10 17:14 ` [PATCH v2 7/7] drm: Rename connector list iterator API Thierry Reding
2017-02-10 17:48 ` Thierry Reding [this message]
2017-02-14 21:55 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210174806.GA5995@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.