All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Jan Kara <jack@suse.cz>, Arnd Bergmann <arnd@arndb.de>,
	linux-nvdimm@lists.01.org,
	Sajjan Vikas C <vikas.cha.sajjan@hpe.com>,
	linux-kernel@vger.kernel.org,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] device-dax: don't set kobj parent during cdev init
Date: Fri, 10 Feb 2017 20:46:17 +0100	[thread overview]
Message-ID: <20170210194617.GA1803@kroah.com> (raw)
In-Reply-To: <1486754370-3057-1-git-send-email-logang@deltatee.com>

On Fri, Feb 10, 2017 at 12:19:30PM -0700, Logan Gunthorpe wrote:
> I copied this code and per feedback from Greg Kroah-Hartman [1] the
> cdev's kobject's parent should not be set to the related device.
> This should have minor consequences but isn't doing what anyone
> expects it to.
> 
> This patch then fixes device-dax so it doesn't make the same mistake.
> 
> [1] https://lkml.org/lkml/2017/2/10/370
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Sajjan Vikas C <vikas.cha.sajjan@hpe.com>,
	Arnd Bergmann <arnd@arndb.de>, Jan Kara <jack@suse.cz>,
	linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org
Subject: Re: [PATCH] device-dax: don't set kobj parent during cdev init
Date: Fri, 10 Feb 2017 20:46:17 +0100	[thread overview]
Message-ID: <20170210194617.GA1803@kroah.com> (raw)
In-Reply-To: <1486754370-3057-1-git-send-email-logang@deltatee.com>

On Fri, Feb 10, 2017 at 12:19:30PM -0700, Logan Gunthorpe wrote:
> I copied this code and per feedback from Greg Kroah-Hartman [1] the
> cdev's kobject's parent should not be set to the related device.
> This should have minor consequences but isn't doing what anyone
> expects it to.
> 
> This patch then fixes device-dax so it doesn't make the same mistake.
> 
> [1] https://lkml.org/lkml/2017/2/10/370
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  parent reply	other threads:[~2017-02-10 19:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 19:19 [PATCH] device-dax: don't set kobj parent during cdev init Logan Gunthorpe
2017-02-10 19:19 ` Logan Gunthorpe
2017-02-10 19:22 ` Logan Gunthorpe
2017-02-10 19:22   ` Logan Gunthorpe
2017-02-10 19:41 ` Dan Williams
2017-02-10 19:41   ` Dan Williams
2017-02-10 20:17   ` Greg Kroah-Hartman
2017-02-10 20:17     ` Greg Kroah-Hartman
2017-02-10 22:25     ` Dan Williams
2017-02-10 22:25       ` Dan Williams
2017-02-11  7:16       ` Greg Kroah-Hartman
2017-02-11  7:16         ` Greg Kroah-Hartman
2017-02-11  8:56         ` Dan Williams
2017-02-11  8:56           ` Dan Williams
2017-02-11 17:59           ` Logan Gunthorpe
2017-02-11 17:59             ` Logan Gunthorpe
2017-02-11 18:27             ` Dan Williams
2017-02-11 18:27               ` Dan Williams
2017-02-11 18:43               ` Logan Gunthorpe
2017-02-11 18:43                 ` Logan Gunthorpe
2017-02-11 18:55                 ` Dan Williams
2017-02-11 18:55                   ` Dan Williams
2017-02-11 18:58                   ` Dan Williams
2017-02-11 18:58                     ` Dan Williams
2017-02-12  5:42                     ` Logan Gunthorpe
2017-02-12  5:42                       ` Logan Gunthorpe
2017-02-13 20:47                       ` Dan Williams
2017-02-13 20:47                         ` Dan Williams
2017-02-13 22:38                         ` Logan Gunthorpe
2017-02-13 22:38                           ` Logan Gunthorpe
2017-02-10 19:46 ` Greg Kroah-Hartman [this message]
2017-02-10 19:46   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170210194617.GA1803@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=logang@deltatee.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=vikas.cha.sajjan@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.