From: Alban <albeu@free.fr>
To: James Hogan <james.hogan@imgtec.com>
Cc: Aban Bedel <albeu@free.fr>, <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Antony Pavlov <antonynpavlov@gmail.com>,
<devicetree@vger.kernel.org>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names
Date: Mon, 13 Feb 2017 09:30:07 +0100 [thread overview]
Message-ID: <20170213093007.7b76fd7c@tock> (raw)
In-Reply-To: <20170211220129.GG24226@jhogan-linux.le.imgtec.org>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
On Sat, 11 Feb 2017 22:01:29 +0000
James Hogan <james.hogan@imgtec.com> wrote:
> Hi Alban,
>
> On Sun, Feb 05, 2017 at 08:52:32PM +0100, Alban wrote:
> > From: Alban Bedel <albeu@free.fr>
> >
> > The binding for the USB PHY went thru before the driver. However the
> > new version of the driver now use the PHY core support for reset, and
> > this expect the reset to be named "phy". So remove the "usb-" prefix
> > from the the reset names.
> >
> > Signed-off-by: Alban Bedel <albeu@free.fr>
> > ---
> > Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++--
> > arch/mips/boot/dts/qca/ar9132.dtsi | 2 +-
>
> <snip>
>
> > diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi
> > index 302f0a8..808c2bb 100644
> > --- a/arch/mips/boot/dts/qca/ar9132.dtsi
> > +++ b/arch/mips/boot/dts/qca/ar9132.dtsi
> > @@ -160,7 +160,7 @@
> > usb_phy: usb-phy {
> > compatible = "qca,ar7100-usb-phy";
> >
> > - reset-names = "usb-phy", "usb-suspend-override";
> > + reset-names = "phy", "suspend-override";
>
> Does arch/mips/boot/dts/qca/ar9331.dtsi need updating too?
Right, I forgot the AR9331 had been added since then, I'll send a new
series.
Alban
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Alban <albeu@free.fr>
To: James Hogan <james.hogan@imgtec.com>
Cc: Aban Bedel <albeu@free.fr>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Antony Pavlov <antonynpavlov@gmail.com>,
devicetree@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names
Date: Mon, 13 Feb 2017 09:30:07 +0100 [thread overview]
Message-ID: <20170213093007.7b76fd7c@tock> (raw)
Message-ID: <20170213083007.fTvxf2NCXmybaCZWozjHtwuzxdrTOt8xoRv43Ql7j1Q@z> (raw)
In-Reply-To: <20170211220129.GG24226@jhogan-linux.le.imgtec.org>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
On Sat, 11 Feb 2017 22:01:29 +0000
James Hogan <james.hogan@imgtec.com> wrote:
> Hi Alban,
>
> On Sun, Feb 05, 2017 at 08:52:32PM +0100, Alban wrote:
> > From: Alban Bedel <albeu@free.fr>
> >
> > The binding for the USB PHY went thru before the driver. However the
> > new version of the driver now use the PHY core support for reset, and
> > this expect the reset to be named "phy". So remove the "usb-" prefix
> > from the the reset names.
> >
> > Signed-off-by: Alban Bedel <albeu@free.fr>
> > ---
> > Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++--
> > arch/mips/boot/dts/qca/ar9132.dtsi | 2 +-
>
> <snip>
>
> > diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi
> > index 302f0a8..808c2bb 100644
> > --- a/arch/mips/boot/dts/qca/ar9132.dtsi
> > +++ b/arch/mips/boot/dts/qca/ar9132.dtsi
> > @@ -160,7 +160,7 @@
> > usb_phy: usb-phy {
> > compatible = "qca,ar7100-usb-phy";
> >
> > - reset-names = "usb-phy", "usb-suspend-override";
> > + reset-names = "phy", "suspend-override";
>
> Does arch/mips/boot/dts/qca/ar9331.dtsi need updating too?
Right, I forgot the AR9331 had been added since then, I'll send a new
series.
Alban
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Alban <albeu-GANU6spQydw@public.gmane.org>
To: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Cc: Aban Bedel <albeu-GANU6spQydw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
Antony Pavlov
<antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org
Subject: Re: [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names
Date: Mon, 13 Feb 2017 09:30:07 +0100 [thread overview]
Message-ID: <20170213093007.7b76fd7c@tock> (raw)
In-Reply-To: <20170211220129.GG24226-4bYivNCBEGTR3KXKvIWQxtm+Uo4AYnCiHZ5vskTnxNA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Sat, 11 Feb 2017 22:01:29 +0000
James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> wrote:
> Hi Alban,
>
> On Sun, Feb 05, 2017 at 08:52:32PM +0100, Alban wrote:
> > From: Alban Bedel <albeu-GANU6spQydw@public.gmane.org>
> >
> > The binding for the USB PHY went thru before the driver. However the
> > new version of the driver now use the PHY core support for reset, and
> > this expect the reset to be named "phy". So remove the "usb-" prefix
> > from the the reset names.
> >
> > Signed-off-by: Alban Bedel <albeu-GANU6spQydw@public.gmane.org>
> > ---
> > Documentation/devicetree/bindings/phy/phy-ath79-usb.txt | 4 ++--
> > arch/mips/boot/dts/qca/ar9132.dtsi | 2 +-
>
> <snip>
>
> > diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi
> > index 302f0a8..808c2bb 100644
> > --- a/arch/mips/boot/dts/qca/ar9132.dtsi
> > +++ b/arch/mips/boot/dts/qca/ar9132.dtsi
> > @@ -160,7 +160,7 @@
> > usb_phy: usb-phy {
> > compatible = "qca,ar7100-usb-phy";
> >
> > - reset-names = "usb-phy", "usb-suspend-override";
> > + reset-names = "phy", "suspend-override";
>
> Does arch/mips/boot/dts/qca/ar9331.dtsi need updating too?
Right, I forgot the AR9331 had been added since then, I'll send a new
series.
Alban
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-02-13 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 19:52 [PATCH v4 1/3] phy: core: Add support for clock and reset to the phy core Alban
2017-02-05 19:52 ` [PATCH v4 2/3] phy: Add a driver for the ATH79 USB phy Alban
2017-02-05 19:52 ` [PATCH v4 3/3] MIPS: ath79: Fix the USB PHY reset names Alban
2017-02-08 22:11 ` Rob Herring
2017-02-08 22:11 ` Rob Herring
2017-02-11 22:01 ` James Hogan
2017-02-11 22:01 ` James Hogan
2017-02-11 22:01 ` James Hogan
2017-02-13 8:30 ` Alban [this message]
2017-02-13 8:30 ` Alban
2017-02-13 8:30 ` Alban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213093007.7b76fd7c@tock \
--to=albeu@free.fr \
--cc=antonynpavlov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.