All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: george.cherian@cavium.com
Cc: linux-crypto@vger.kernel.org
Subject: [bug report] crypto: cavium - Add the Virtual Function driver for CPT
Date: Wed, 15 Feb 2017 11:39:09 +0300	[thread overview]
Message-ID: <20170215083909.GA12892@mwanda> (raw)

Hello George Cherian,

This is a semi-automatic email about new static checker warnings.

The patch c694b233295b: "crypto: cavium - Add the Virtual Function 
driver for CPT" from Feb 7, 2017, leads to the following Smatch 
complaint:

drivers/crypto/cavium/cpt/cptvf_reqmanager.c:333 do_post_process()
	 warn: variable dereferenced before check 'cptvf' (see line 331)

drivers/crypto/cavium/cpt/cptvf_reqmanager.c
   330	{
   331		struct pci_dev *pdev = cptvf->pdev;
                                       ^^^^^^^^^^^
Dereference.

   332	
   333		if (!info || !cptvf) {
                              ^^^^^
Check is too late.

   334			dev_err(&pdev->dev, "Input params are incorrect for post processing\n");
   335			return;

regards,
dan carpenter

             reply	other threads:[~2017-02-15  8:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15  8:39 Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-02-16 20:18 [bug report] crypto: cavium - Add the Virtual Function driver for CPT Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215083909.GA12892@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=george.cherian@cavium.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.