All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: george.cherian@cavium.com
Cc: linux-crypto@vger.kernel.org
Subject: [bug report] crypto: cavium - Add the Virtual Function driver for CPT
Date: Thu, 16 Feb 2017 23:18:11 +0300	[thread overview]
Message-ID: <20170216201811.GA4898@mwanda> (raw)

Hello George Cherian,

This is a semi-automatic email about new static checker warnings.

The patch c694b233295b: "crypto: cavium - Add the Virtual Function
driver for CPT" from Feb 7, 2017, leads to the following Smatch
complaint:

drivers/crypto/cavium/cpt/cptvf_main.c:899 cptvf_remove()
	 error: we previously assumed 'cptvf' could be null (see line 895)

drivers/crypto/cavium/cpt/cptvf_main.c
   894	
   895		if (!cptvf)
                     ^^^^^
Check for NULL.

   896			dev_err(&pdev->dev, "Invalid CPT-VF device\n");
   897	
   898		/* Convey DOWN to PF */
   899		if (cptvf_send_vf_down(cptvf)) {
                                       ^^^^^
Oops inside function.

   900			dev_err(&pdev->dev, "PF not responding to DOWN msg");
   901		} else {

regards,
dan carpenter

             reply	other threads:[~2017-02-16 20:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 20:18 Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-02-15  8:39 [bug report] crypto: cavium - Add the Virtual Function driver for CPT Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216201811.GA4898@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=george.cherian@cavium.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.