* [PATCH] arm64: include asm/assembler.h in entry-ftrace.S
@ 2017-02-14 21:32 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-02-14 21:32 UTC (permalink / raw)
To: linux-arm-kernel
In a randconfig build I ran into this build error:
arch/arm64/kernel/entry-ftrace.S: Assembler messages:
arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function'
The macro is defined in asm/assembler.h, so we should include that file.
Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm64/kernel/entry-ftrace.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/entry-ftrace.S b/arch/arm64/kernel/entry-ftrace.S
index 8f1905b795f3..e1be42e11ff5 100644
--- a/arch/arm64/kernel/entry-ftrace.S
+++ b/arch/arm64/kernel/entry-ftrace.S
@@ -10,6 +10,7 @@
*/
#include <linux/linkage.h>
+#include <asm/assembler.h>
#include <asm/ftrace.h>
#include <asm/insn.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm64: include asm/assembler.h in entry-ftrace.S
@ 2017-02-14 21:32 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-02-14 21:32 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Arnd Bergmann, Ingo Molnar, Ard Biesheuvel, Steven Rostedt,
Josh Poimboeuf, Mark Rutland, linux-arm-kernel, linux-kernel
In a randconfig build I ran into this build error:
arch/arm64/kernel/entry-ftrace.S: Assembler messages:
arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function'
The macro is defined in asm/assembler.h, so we should include that file.
Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm64/kernel/entry-ftrace.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/entry-ftrace.S b/arch/arm64/kernel/entry-ftrace.S
index 8f1905b795f3..e1be42e11ff5 100644
--- a/arch/arm64/kernel/entry-ftrace.S
+++ b/arch/arm64/kernel/entry-ftrace.S
@@ -10,6 +10,7 @@
*/
#include <linux/linkage.h>
+#include <asm/assembler.h>
#include <asm/ftrace.h>
#include <asm/insn.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm64: include asm/assembler.h in entry-ftrace.S
2017-02-14 21:32 ` Arnd Bergmann
@ 2017-02-15 10:58 ` Mark Rutland
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2017-02-15 10:58 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Feb 14, 2017 at 10:32:58PM +0100, Arnd Bergmann wrote:
> In a randconfig build I ran into this build error:
>
> arch/arm64/kernel/entry-ftrace.S: Assembler messages:
> arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function'
>
> The macro is defined in asm/assembler.h, so we should include that file.
>
> Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
My bad; thanks for fixing this.
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> arch/arm64/kernel/entry-ftrace.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/entry-ftrace.S b/arch/arm64/kernel/entry-ftrace.S
> index 8f1905b795f3..e1be42e11ff5 100644
> --- a/arch/arm64/kernel/entry-ftrace.S
> +++ b/arch/arm64/kernel/entry-ftrace.S
> @@ -10,6 +10,7 @@
> */
>
> #include <linux/linkage.h>
> +#include <asm/assembler.h>
> #include <asm/ftrace.h>
> #include <asm/insn.h>
>
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: include asm/assembler.h in entry-ftrace.S
@ 2017-02-15 10:58 ` Mark Rutland
0 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2017-02-15 10:58 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Catalin Marinas, Will Deacon, Ingo Molnar, Ard Biesheuvel,
Steven Rostedt, Josh Poimboeuf, linux-arm-kernel, linux-kernel,
nd
On Tue, Feb 14, 2017 at 10:32:58PM +0100, Arnd Bergmann wrote:
> In a randconfig build I ran into this build error:
>
> arch/arm64/kernel/entry-ftrace.S: Assembler messages:
> arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function'
>
> The macro is defined in asm/assembler.h, so we should include that file.
>
> Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
My bad; thanks for fixing this.
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> arch/arm64/kernel/entry-ftrace.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/entry-ftrace.S b/arch/arm64/kernel/entry-ftrace.S
> index 8f1905b795f3..e1be42e11ff5 100644
> --- a/arch/arm64/kernel/entry-ftrace.S
> +++ b/arch/arm64/kernel/entry-ftrace.S
> @@ -10,6 +10,7 @@
> */
>
> #include <linux/linkage.h>
> +#include <asm/assembler.h>
> #include <asm/ftrace.h>
> #include <asm/insn.h>
>
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm64: include asm/assembler.h in entry-ftrace.S
2017-02-14 21:32 ` Arnd Bergmann
@ 2017-02-15 11:34 ` Will Deacon
-1 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2017-02-15 11:34 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Feb 14, 2017 at 10:32:58PM +0100, Arnd Bergmann wrote:
> In a randconfig build I ran into this build error:
>
> arch/arm64/kernel/entry-ftrace.S: Assembler messages:
> arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function'
>
> The macro is defined in asm/assembler.h, so we should include that file.
>
> Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I've picked this one up too.
Will
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: include asm/assembler.h in entry-ftrace.S
@ 2017-02-15 11:34 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2017-02-15 11:34 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Catalin Marinas, Ingo Molnar, Ard Biesheuvel, Steven Rostedt,
Josh Poimboeuf, Mark Rutland, linux-arm-kernel, linux-kernel
On Tue, Feb 14, 2017 at 10:32:58PM +0100, Arnd Bergmann wrote:
> In a randconfig build I ran into this build error:
>
> arch/arm64/kernel/entry-ftrace.S: Assembler messages:
> arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function'
>
> The macro is defined in asm/assembler.h, so we should include that file.
>
> Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I've picked this one up too.
Will
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-15 11:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14 21:32 [PATCH] arm64: include asm/assembler.h in entry-ftrace.S Arnd Bergmann
2017-02-14 21:32 ` Arnd Bergmann
2017-02-15 10:58 ` Mark Rutland
2017-02-15 10:58 ` Mark Rutland
2017-02-15 11:34 ` Will Deacon
2017-02-15 11:34 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.