All of lore.kernel.org
 help / color / mirror / Atom feed
From: agust@denx.de (Anatolij Gustschin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/3] fpga manager: Add cyclone-ps-spi driver for Altera FPGAs
Date: Wed, 15 Feb 2017 16:26:41 +0100	[thread overview]
Message-ID: <20170215162641.5bc50cf3@crub> (raw)
In-Reply-To: <94f1d92f502b64669467c467038c3aa766b312ad.1485295905.git.stillcompiling@gmail.com>

Hi Joshua,

On Tue, 24 Jan 2017 14:19:33 -0800
Joshua Clayton stillcompiling at gmail.com wrote:
...
>+static int cyclonespi_write(struct fpga_manager *mgr, const char *buf,
>+			    size_t count)
>+{
>+	struct cyclonespi_conf *conf = (struct cyclonespi_conf *)mgr->priv;
>+	const char *fw_data = buf;
>+	const char *fw_data_end = fw_data + count;
>+
>+	while (fw_data < fw_data_end) {
>+		int ret;
>+		size_t stride = min(fw_data_end - fw_data, SZ_4K);
>+
>+		rev_buf(fw_data, stride);

Can we make rev_buf() optional here? I've tested this driver with
Stratix-V FPGA using orion_spi driver. It works without swapping
the data.

Thanks,
Anatolij

WARNING: multiple messages have this Message-ID (diff)
From: Anatolij Gustschin <agust@denx.de>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: Alan Tull <atull@opensource.altera.com>,
	Moritz Fischer <moritz.fischer@ettus.com>,
	Russell King <linux@armlinux.org.uk>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-fpga@vger.kernel.org
Subject: Re: [PATCH v9 2/3] fpga manager: Add cyclone-ps-spi driver for Altera FPGAs
Date: Wed, 15 Feb 2017 16:26:41 +0100	[thread overview]
Message-ID: <20170215162641.5bc50cf3@crub> (raw)
In-Reply-To: <94f1d92f502b64669467c467038c3aa766b312ad.1485295905.git.stillcompiling@gmail.com>

Hi Joshua,

On Tue, 24 Jan 2017 14:19:33 -0800
Joshua Clayton stillcompiling@gmail.com wrote:
...
>+static int cyclonespi_write(struct fpga_manager *mgr, const char *buf,
>+			    size_t count)
>+{
>+	struct cyclonespi_conf *conf = (struct cyclonespi_conf *)mgr->priv;
>+	const char *fw_data = buf;
>+	const char *fw_data_end = fw_data + count;
>+
>+	while (fw_data < fw_data_end) {
>+		int ret;
>+		size_t stride = min(fw_data_end - fw_data, SZ_4K);
>+
>+		rev_buf(fw_data, stride);

Can we make rev_buf() optional here? I've tested this driver with
Stratix-V FPGA using orion_spi driver. It works without swapping
the data.

Thanks,
Anatolij

  reply	other threads:[~2017-02-15 15:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 22:19 [PATCH v9 0/3] Altera Cyclone Passive Serial SPI FPGA Manager Joshua Clayton
2017-01-24 22:19 ` Joshua Clayton
2017-01-24 22:19 ` [PATCH v9 1/3] doc: dt: add cyclone-ps-spi binding document Joshua Clayton
2017-01-24 22:19   ` Joshua Clayton
2017-01-27 22:28   ` Rob Herring
2017-01-27 22:28     ` Rob Herring
2017-01-27 22:28     ` Rob Herring
2017-01-30 18:53     ` Joshua Clayton
2017-01-30 18:53       ` Joshua Clayton
2017-01-30 18:53       ` Joshua Clayton
2017-01-24 22:19 ` [PATCH v9 2/3] fpga manager: Add cyclone-ps-spi driver for Altera FPGAs Joshua Clayton
2017-01-24 22:19   ` Joshua Clayton
2017-02-15 15:26   ` Anatolij Gustschin [this message]
2017-02-15 15:26     ` Anatolij Gustschin
2017-02-15 17:14     ` Alan Tull
2017-02-15 17:14       ` Alan Tull
2017-02-15 17:14       ` Alan Tull
2017-02-15 23:01       ` Joshua Clayton
2017-02-15 23:01         ` Joshua Clayton
2017-01-24 22:19 ` [PATCH v9 3/3] ARM: dts: imx6q-evi: support cyclone-ps-spi Joshua Clayton
2017-01-24 22:19   ` Joshua Clayton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215162641.5bc50cf3@crub \
    --to=agust@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.