All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Kernel-team@fb.com, mhocko@suse.com, minchan@kernel.org,
	hughd@google.com, riel@redhat.com, mgorman@techsingularity.net,
	akpm@linux-foundation.org
Subject: Re: [PATCH V3 1/7] mm: don't assume anonymous pages have SwapBacked flag
Date: Thu, 16 Feb 2017 12:39:58 -0500	[thread overview]
Message-ID: <20170216173958.GA20791@cmpxchg.org> (raw)
In-Reply-To: <62e817d1d7fbee415ded0ac76233cb1329ffe06f.1487100204.git.shli@fb.com>

On Tue, Feb 14, 2017 at 11:36:07AM -0800, Shaohua Li wrote:
> There are a few places the code assumes anonymous pages should have
> SwapBacked flag set. MADV_FREE pages are anonymous pages but we are
> going to add them to LRU_INACTIVE_FILE list and clear SwapBacked flag
> for them. The assumption doesn't hold any more, so fix them.
> 
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Shaohua Li <shli@fb.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Kernel-team@fb.com, mhocko@suse.com, minchan@kernel.org,
	hughd@google.com, riel@redhat.com, mgorman@techsingularity.net,
	akpm@linux-foundation.org
Subject: Re: [PATCH V3 1/7] mm: don't assume anonymous pages have SwapBacked flag
Date: Thu, 16 Feb 2017 12:39:58 -0500	[thread overview]
Message-ID: <20170216173958.GA20791@cmpxchg.org> (raw)
In-Reply-To: <62e817d1d7fbee415ded0ac76233cb1329ffe06f.1487100204.git.shli@fb.com>

On Tue, Feb 14, 2017 at 11:36:07AM -0800, Shaohua Li wrote:
> There are a few places the code assumes anonymous pages should have
> SwapBacked flag set. MADV_FREE pages are anonymous pages but we are
> going to add them to LRU_INACTIVE_FILE list and clear SwapBacked flag
> for them. The assumption doesn't hold any more, so fix them.
> 
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Shaohua Li <shli@fb.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

  reply	other threads:[~2017-02-16 17:40 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 19:36 [PATCH V3 0/7] mm: fix some MADV_FREE issues Shaohua Li
2017-02-14 19:36 ` Shaohua Li
2017-02-14 19:36 ` [PATCH V3 1/7] mm: don't assume anonymous pages have SwapBacked flag Shaohua Li
2017-02-14 19:36   ` Shaohua Li
2017-02-16 17:39   ` Johannes Weiner [this message]
2017-02-16 17:39     ` Johannes Weiner
2017-02-14 19:36 ` [PATCH V3 2/7] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Shaohua Li
2017-02-14 19:36   ` Shaohua Li
2017-02-16 17:52   ` Johannes Weiner
2017-02-16 17:52     ` Johannes Weiner
2017-02-17  0:35     ` Shaohua Li
2017-02-17  0:35       ` Shaohua Li
2017-02-17 16:22       ` Johannes Weiner
2017-02-17 16:22         ` Johannes Weiner
2017-02-14 19:36 ` [PATCH V3 3/7] mm: reclaim MADV_FREE pages Shaohua Li
2017-02-14 19:36   ` Shaohua Li
2017-02-16 18:40   ` Johannes Weiner
2017-02-16 18:40     ` Johannes Weiner
2017-02-17  0:27     ` Shaohua Li
2017-02-17  0:27       ` Shaohua Li
2017-02-17  5:45       ` Minchan Kim
2017-02-17  5:45         ` Minchan Kim
2017-02-17 16:11         ` Johannes Weiner
2017-02-17 16:11           ` Johannes Weiner
2017-02-17 16:01       ` Johannes Weiner
2017-02-17 16:01         ` Johannes Weiner
2017-02-17 18:43         ` Shaohua Li
2017-02-17 18:43           ` Shaohua Li
2017-02-17 20:03           ` Johannes Weiner
2017-02-17 20:03             ` Johannes Weiner
2017-02-17  5:41     ` Minchan Kim
2017-02-17  5:41       ` Minchan Kim
2017-02-17  9:27       ` Minchan Kim
2017-02-17  9:27         ` Minchan Kim
2017-02-17 16:15       ` Johannes Weiner
2017-02-17 16:15         ` Johannes Weiner
2017-02-14 19:36 ` [PATCH V3 4/7] mm: enable MADV_FREE for swapless system Shaohua Li
2017-02-14 19:36   ` Shaohua Li
2017-02-17 16:16   ` Johannes Weiner
2017-02-17 16:16     ` Johannes Weiner
2017-02-14 19:36 ` [PATCH V3 5/7] mm: add vmstat account for MADV_FREE pages Shaohua Li
2017-02-14 19:36   ` Shaohua Li
2017-02-14 19:36 ` [PATCH V3 6/7] proc: show MADV_FREE pages info in smaps Shaohua Li
2017-02-14 19:36   ` Shaohua Li
2017-02-14 19:36 ` [PATCH V3 7/7] mm: add a separate RSS for MADV_FREE pages Shaohua Li
2017-02-14 19:36   ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216173958.GA20791@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=Kernel-team@fb.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    --cc=shli@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.