* [PATCH] dell-laptop: Add another Dell laptop to the DMI whitelist
@ 2017-02-16 12:58 Alex Hung
2017-02-16 13:22 ` Pali Rohár
0 siblings, 1 reply; 3+ messages in thread
From: Alex Hung @ 2017-02-16 12:58 UTC (permalink / raw)
To: alex.hung, mjg59, pali.rohar, dvhart, andy, platform-driver-x86
This is to support Latitude 7480 and many other newer Dell laptops.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
drivers/platform/x86/dell-laptop.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 277656c..6174854 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -109,6 +109,12 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
},
},
{
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/
+ },
+ },
+ {
.ident = "Dell Computer Corporation",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dell-laptop: Add another Dell laptop to the DMI whitelist
2017-02-16 12:58 [PATCH] dell-laptop: Add another Dell laptop to the DMI whitelist Alex Hung
@ 2017-02-16 13:22 ` Pali Rohár
2017-02-17 1:59 ` Darren Hart
0 siblings, 1 reply; 3+ messages in thread
From: Pali Rohár @ 2017-02-16 13:22 UTC (permalink / raw)
To: Alex Hung; +Cc: mjg59, dvhart, andy, platform-driver-x86
On Thursday 16 February 2017 20:58:03 Alex Hung wrote:
> This is to support Latitude 7480 and many other newer Dell laptops.
>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
Looks good. Maybe should be this change backported to stable?
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> drivers/platform/x86/dell-laptop.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index 277656c..6174854 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -109,6 +109,12 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
> },
> },
> {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/
> + },
> + },
> + {
> .ident = "Dell Computer Corporation",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dell-laptop: Add another Dell laptop to the DMI whitelist
2017-02-16 13:22 ` Pali Rohár
@ 2017-02-17 1:59 ` Darren Hart
0 siblings, 0 replies; 3+ messages in thread
From: Darren Hart @ 2017-02-17 1:59 UTC (permalink / raw)
To: Pali Rohár; +Cc: Alex Hung, mjg59, andy, platform-driver-x86
On Thu, Feb 16, 2017 at 02:22:21PM +0100, Pali Rohár wrote:
> On Thursday 16 February 2017 20:58:03 Alex Hung wrote:
> > This is to support Latitude 7480 and many other newer Dell laptops.
> >
> > Signed-off-by: Alex Hung <alex.hung@canonical.com>
>
> Looks good. Maybe should be this change backported to stable?
Applied.
I'd want to see testing on the previous kernels to ensure all the necessary
support for those laptops has also been backported before sending DMI matches
back. We don't want to end up with just the DMI matches in stable kernels, but
inadvertently omit some functional change those machines require which have been
added since the stable release.
Thanks,
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-17 1:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-16 12:58 [PATCH] dell-laptop: Add another Dell laptop to the DMI whitelist Alex Hung
2017-02-16 13:22 ` Pali Rohár
2017-02-17 1:59 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.