From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end
Date: Fri, 17 Feb 2017 14:00:01 +0000 [thread overview]
Message-ID: <20170217140001.GD15431@arm.com> (raw)
In-Reply-To: <8737fdj5q0.fsf@ashishki-desk.ger.corp.intel.com>
On Fri, Feb 17, 2017 at 03:40:23PM +0200, Alexander Shishkin wrote:
> Will Deacon <will.deacon@arm.com> writes:
>
> > @@ -485,7 +485,8 @@ int intel_bts_interrupt(void)
> > return handled;
> >
> > perf_aux_output_end(&bts->handle, local_xchg(&buf->data_size, 0),
> > - !!local_xchg(&buf->lost, 0));
> > + local_xchg(&buf->lost, 0) ?
> > + PERF_AUX_FLAG_OVERWRITE : 0);
>
> Heh, this one would have taken some time to debug. :)
Don't worry, this isn't a bug fix! This patch changes the prototype for
perf_aux_output_end so that it takes the flag instead of a "bool truncated"
parameter, so this is just fixing up the callers at the same time.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com,
mark.rutland@arm.com, kim.phillips@arm.com,
alex.bennee@linaro.org, christoffer.dall@linaro.org,
tglx@linutronix.de, peterz@infradead.org, robh@kernel.org,
suzuki.poulose@arm.com, pawel.moll@arm.com,
mathieu.poirier@linaro.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end
Date: Fri, 17 Feb 2017 14:00:01 +0000 [thread overview]
Message-ID: <20170217140001.GD15431@arm.com> (raw)
In-Reply-To: <8737fdj5q0.fsf@ashishki-desk.ger.corp.intel.com>
On Fri, Feb 17, 2017 at 03:40:23PM +0200, Alexander Shishkin wrote:
> Will Deacon <will.deacon@arm.com> writes:
>
> > @@ -485,7 +485,8 @@ int intel_bts_interrupt(void)
> > return handled;
> >
> > perf_aux_output_end(&bts->handle, local_xchg(&buf->data_size, 0),
> > - !!local_xchg(&buf->lost, 0));
> > + local_xchg(&buf->lost, 0) ?
> > + PERF_AUX_FLAG_OVERWRITE : 0);
>
> Heh, this one would have taken some time to debug. :)
Don't worry, this isn't a bug fix! This patch changes the prototype for
perf_aux_output_end so that it takes the flag instead of a "bool truncated"
parameter, so this is just fixing up the callers at the same time.
Will
next prev parent reply other threads:[~2017-02-17 14:00 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 18:07 [PATCH 00/10] Add support for the ARMv8.2 Statistical Profiling Extension Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-01-27 18:07 ` [PATCH 01/10] arm64: cpufeature: allow for version discrepancy in PMU implementations Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-01-27 18:07 ` [PATCH 02/10] arm64: cpufeature: Don't enforce system-wide SPE capability Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-01-27 18:07 ` [PATCH 03/10] arm64: KVM: Save/restore the host SPE state when entering/leaving a VM Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-02-01 16:29 ` Marc Zyngier
2017-02-01 16:29 ` Marc Zyngier
2017-02-02 18:18 ` Will Deacon
2017-02-02 18:18 ` Will Deacon
2017-02-02 18:21 ` Marc Zyngier
2017-02-02 18:21 ` Marc Zyngier
2017-01-27 18:07 ` [PATCH 04/10] arm64: head.S: Enable EL1 (host) access to SPE when entered at EL2 Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-02-01 16:22 ` Marc Zyngier
2017-02-01 16:22 ` Marc Zyngier
2017-02-09 18:26 ` Mark Rutland
2017-02-09 18:26 ` Mark Rutland
2017-01-27 18:07 ` [PATCH 05/10] genirq: export irq_get_percpu_devid_partition to modules Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-01-27 18:07 ` [PATCH 06/10] perf/core: Export AUX buffer helpers " Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-01-27 18:07 ` [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-02-17 13:40 ` Alexander Shishkin
2017-02-17 13:40 ` Alexander Shishkin
2017-02-17 14:00 ` Will Deacon [this message]
2017-02-17 14:00 ` Will Deacon
2017-02-17 14:06 ` Alexander Shishkin
2017-02-17 14:06 ` Alexander Shishkin
2017-02-17 14:42 ` Will Deacon
2017-02-17 14:42 ` Will Deacon
2017-02-17 14:59 ` Alexander Shishkin
2017-02-17 14:59 ` Alexander Shishkin
2017-01-27 18:07 ` [PATCH 08/10] perf/core: Add PERF_AUX_FLAG_COLLISION to report colliding samples Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-03-31 16:44 ` Robin Murphy
2017-03-31 16:44 ` Robin Murphy
2017-01-27 18:07 ` [PATCH 09/10] drivers/perf: Add support for ARMv8.2 Statistical Profiling Extension Will Deacon
2017-01-27 18:07 ` Will Deacon
2017-01-30 19:03 ` Kim Phillips
2017-01-30 19:03 ` Kim Phillips
2017-01-27 18:07 ` [PATCH 10/10] dt-bindings: Document devicetree binding for ARM SPE Will Deacon
2017-01-27 18:07 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217140001.GD15431@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.