All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jon Derrick <jonathan.derrick@intel.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Scott Bauer <scott.bauer@intel.com>,
	Rafael Antognolli <rafael.antognolli@intel.com>,
	Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCHv2 5/5] block/sed: Eliminate state variable
Date: Sat, 18 Feb 2017 09:36:43 +0100	[thread overview]
Message-ID: <20170218083642.GC11798@lst.de> (raw)
In-Reply-To: <1487376029-22662-6-git-send-email-jonathan.derrick@intel.com>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

But I would just fold it into the previous patch.

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2 5/5] block/sed: Eliminate state variable
Date: Sat, 18 Feb 2017 09:36:43 +0100	[thread overview]
Message-ID: <20170218083642.GC11798@lst.de> (raw)
In-Reply-To: <1487376029-22662-6-git-send-email-jonathan.derrick@intel.com>

Looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>

But I would just fold it into the previous patch.

  reply	other threads:[~2017-02-18  8:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18  0:00 [PATCHv2 0/5] OPAL patche'd cont'd Jon Derrick
2017-02-18  0:00 ` Jon Derrick
2017-02-18  0:00 ` [PATCHv2 1/5] block/sed: Use ssize_t on atom parsers to return errors Jon Derrick
2017-02-18  0:00   ` Jon Derrick
2017-02-18  0:00 ` [PATCHv2 2/5] block/sed: Add helper to qualify response tokens Jon Derrick
2017-02-18  0:00   ` Jon Derrick
2017-02-18  0:00 ` [PATCHv2 3/5] block/sed: Check received header lengths Jon Derrick
2017-02-18  0:00   ` Jon Derrick
2017-02-18  0:00 ` [PATCHv2 4/5] block/sed: Embed function data into the function sequence Jon Derrick
2017-02-18  0:00   ` Jon Derrick
2017-02-18  8:36   ` Christoph Hellwig
2017-02-18  8:36     ` Christoph Hellwig
2017-02-18 15:52     ` Scott Bauer
2017-02-18 15:52       ` Scott Bauer
2017-02-18 16:22       ` Christoph Hellwig
2017-02-18 16:22         ` Christoph Hellwig
2017-02-18  0:00 ` [PATCHv2 5/5] block/sed: Eliminate state variable Jon Derrick
2017-02-18  0:00   ` Jon Derrick
2017-02-18  8:36   ` Christoph Hellwig [this message]
2017-02-18  8:36     ` Christoph Hellwig
2017-02-18  8:24 ` [PATCHv2 0/5] OPAL patche'd cont'd Christoph Hellwig
2017-02-18  8:24   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170218083642.GC11798@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=jonathan.derrick@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=rafael.antognolli@intel.com \
    --cc=scott.bauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.