[meta-raspberrypi][PATCH] linux-raspberrypi: Fix uImage build on 4.9.y and later

[meta-raspberrypi][PATCH] linux-raspberrypi: Fix uImage build on 4.9.y and later

[paul]

From: Paul Barker <paul@paulbarker.me.uk>

Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
---
 recipes-kernel/linux/linux-raspberrypi_4.9.bb | 5 +++++
 recipes-kernel/linux/linux-raspberrypi_dev.bb | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/recipes-kernel/linux/linux-raspberrypi_4.9.bb b/recipes-kernel/linux/linux-raspberrypi_4.9.bb
index dcca369..b113674 100644
--- a/recipes-kernel/linux/linux-raspberrypi_4.9.bb
+++ b/recipes-kernel/linux/linux-raspberrypi_4.9.bb
@@ -7,3 +7,8 @@ SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.9.y
            file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
 "
 require linux-raspberrypi.inc
+
+# A LOADADDR is needed when building a uImage format kernel. This value is not
+# set by default in rpi-4.8.y and later branches so we need to provide it
+# manually. This value unused if KERNEL_IMAGETYPE is not uImage.
+KERNEL_EXTRA_ARGS += "LOADADDR=0x00008000"
diff --git a/recipes-kernel/linux/linux-raspberrypi_dev.bb b/recipes-kernel/linux/linux-raspberrypi_dev.bb
index bec0d23..e45903b 100644
--- a/recipes-kernel/linux/linux-raspberrypi_dev.bb
+++ b/recipes-kernel/linux/linux-raspberrypi_dev.bb
@@ -7,3 +7,8 @@ SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.10.y
            file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
 "
 require linux-raspberrypi.inc
+
+# A LOADADDR is needed when building a uImage format kernel. This value is not
+# set by default in rpi-4.8.y and later branches so we need to provide it
+# manually. This value unused if KERNEL_IMAGETYPE is not uImage.
+KERNEL_EXTRA_ARGS += "LOADADDR=0x00008000"
-- 
2.11.0

Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Fix uImage build on 4.9.y and later

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 2000 bytes --]

On Sat, Feb 18, 2017 at 07:39:13PM +0000, paul@paulbarker.me.uk wrote:
> From: Paul Barker <paul@paulbarker.me.uk>
>
> Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> ---
>  recipes-kernel/linux/linux-raspberrypi_4.9.bb | 5 +++++
>  recipes-kernel/linux/linux-raspberrypi_dev.bb | 5 +++++
>  2 files changed, 10 insertions(+)
>
> diff --git a/recipes-kernel/linux/linux-raspberrypi_4.9.bb b/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> index dcca369..b113674 100644
> --- a/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> +++ b/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> @@ -7,3 +7,8 @@ SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.9.y
>             file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
>  "
>  require linux-raspberrypi.inc
> +
> +# A LOADADDR is needed when building a uImage format kernel. This value is not
> +# set by default in rpi-4.8.y and later branches so we need to provide it
> +# manually. This value unused if KERNEL_IMAGETYPE is not uImage.
> +KERNEL_EXTRA_ARGS += "LOADADDR=0x00008000"
> diff --git a/recipes-kernel/linux/linux-raspberrypi_dev.bb b/recipes-kernel/linux/linux-raspberrypi_dev.bb
> index bec0d23..e45903b 100644
> --- a/recipes-kernel/linux/linux-raspberrypi_dev.bb
> +++ b/recipes-kernel/linux/linux-raspberrypi_dev.bb
> @@ -7,3 +7,8 @@ SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.10.y
>             file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
>  "
>  require linux-raspberrypi.inc
> +
> +# A LOADADDR is needed when building a uImage format kernel. This value is not
> +# set by default in rpi-4.8.y and later branches so we need to provide it
> +# manually. This value unused if KERNEL_IMAGETYPE is not uImage.
> +KERNEL_EXTRA_ARGS += "LOADADDR=0x00008000"

Any reason not to set this in the machine configuration file?

--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Fix uImage build on 4.9.y and later

[Paul Barker]

On Sat, 18 Feb 2017 20:13:07 -0800
Andrei Gherzan <andrei@gherzan.ro> wrote:

> On Sat, Feb 18, 2017 at 07:39:13PM +0000, paul@paulbarker.me.uk wrote:
> > From: Paul Barker <paul@paulbarker.me.uk>
> >
> > Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> > ---
> >  recipes-kernel/linux/linux-raspberrypi_4.9.bb | 5 +++++
> >  recipes-kernel/linux/linux-raspberrypi_dev.bb | 5 +++++
> >  2 files changed, 10 insertions(+)
> >
> > diff --git a/recipes-kernel/linux/linux-raspberrypi_4.9.bb b/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> > index dcca369..b113674 100644
> > --- a/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> > +++ b/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> > @@ -7,3 +7,8 @@ SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.9.y
> >             file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
> >  "
> >  require linux-raspberrypi.inc
> > +
> > +# A LOADADDR is needed when building a uImage format kernel. This value is not
> > +# set by default in rpi-4.8.y and later branches so we need to provide it
> > +# manually. This value unused if KERNEL_IMAGETYPE is not uImage.
> > +KERNEL_EXTRA_ARGS += "LOADADDR=0x00008000"
> > diff --git a/recipes-kernel/linux/linux-raspberrypi_dev.bb b/recipes-kernel/linux/linux-raspberrypi_dev.bb
> > index bec0d23..e45903b 100644
> > --- a/recipes-kernel/linux/linux-raspberrypi_dev.bb
> > +++ b/recipes-kernel/linux/linux-raspberrypi_dev.bb
> > @@ -7,3 +7,8 @@ SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.10.y
> >             file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
> >  "
> >  require linux-raspberrypi.inc
> > +
> > +# A LOADADDR is needed when building a uImage format kernel. This value is not
> > +# set by default in rpi-4.8.y and later branches so we need to provide it
> > +# manually. This value unused if KERNEL_IMAGETYPE is not uImage.
> > +KERNEL_EXTRA_ARGS += "LOADADDR=0x00008000"  
> 
> Any reason not to set this in the machine configuration file?
> 

It's not needed for the 4.4.y kernel series and I haven't tested it
with that.

I've also opened an upstream bug which may lead to futher changes down
the line: https://github.com/raspberrypi/linux/issues/1850

So I think for now I'd just keep the setting in the affected recipes.
We can tidy it up in the future if we drop 4.4.y and based on any
response to the upstream bug.

Thanks,
Paul

Re: [meta-raspberrypi][PATCH] linux-raspberrypi: Fix uImage build on 4.9.y and later

[Paul Barker]

On Sun, 19 Feb 2017 09:29:24 +0000
Paul Barker <paul@paulbarker.me.uk> wrote:

> On Sat, 18 Feb 2017 20:13:07 -0800
> Andrei Gherzan <andrei@gherzan.ro> wrote:
> 
> > On Sat, Feb 18, 2017 at 07:39:13PM +0000, paul@paulbarker.me.uk wrote:  
> > > From: Paul Barker <paul@paulbarker.me.uk>
> > >
> > > Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> > > ---
> > >  recipes-kernel/linux/linux-raspberrypi_4.9.bb | 5 +++++
> > >  recipes-kernel/linux/linux-raspberrypi_dev.bb | 5 +++++
> > >  2 files changed, 10 insertions(+)
> > >
> > > diff --git a/recipes-kernel/linux/linux-raspberrypi_4.9.bb b/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> > > index dcca369..b113674 100644
> > > --- a/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> > > +++ b/recipes-kernel/linux/linux-raspberrypi_4.9.bb
> > > @@ -7,3 +7,8 @@ SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.9.y
> > >             file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
> > >  "
> > >  require linux-raspberrypi.inc
> > > +
> > > +# A LOADADDR is needed when building a uImage format kernel. This value is not
> > > +# set by default in rpi-4.8.y and later branches so we need to provide it
> > > +# manually. This value unused if KERNEL_IMAGETYPE is not uImage.
> > > +KERNEL_EXTRA_ARGS += "LOADADDR=0x00008000"
> > > diff --git a/recipes-kernel/linux/linux-raspberrypi_dev.bb b/recipes-kernel/linux/linux-raspberrypi_dev.bb
> > > index bec0d23..e45903b 100644
> > > --- a/recipes-kernel/linux/linux-raspberrypi_dev.bb
> > > +++ b/recipes-kernel/linux/linux-raspberrypi_dev.bb
> > > @@ -7,3 +7,8 @@ SRC_URI = "git://github.com/raspberrypi/linux.git;protocol=git;branch=rpi-4.10.y
> > >             file://0001-build-arm64-Add-rules-for-.dtbo-files-for-dts-overla.patch \
> > >  "
> > >  require linux-raspberrypi.inc
> > > +
> > > +# A LOADADDR is needed when building a uImage format kernel. This value is not
> > > +# set by default in rpi-4.8.y and later branches so we need to provide it
> > > +# manually. This value unused if KERNEL_IMAGETYPE is not uImage.
> > > +KERNEL_EXTRA_ARGS += "LOADADDR=0x00008000"    
> > 
> > Any reason not to set this in the machine configuration file?
> >   
> 
> It's not needed for the 4.4.y kernel series and I haven't tested it
> with that.
> 
> I've also opened an upstream bug which may lead to futher changes down
> the line: https://github.com/raspberrypi/linux/issues/1850
> 
> So I think for now I'd just keep the setting in the affected recipes.
> We can tidy it up in the future if we drop 4.4.y and based on any
> response to the upstream bug.

Ping on this. I don't feel strongly about where KERNEL_EXTRA_ARGS is
set so we can either merge this as-is or I can move it to the machine
conf file and test with the 4.4.y kernel.

Thanks,
Paul