[PATCH] netcat-openbsd: fix implicit dependency on pkg-config

[PATCH] netcat-openbsd: fix implicit dependency on pkg-config

[Paul Gortmaker]

In the report at http://errors.yoctoproject.org/Errors/Details/130673/
we see the following:

i586-oe-linux-gcc  -m32 -march=i586 <snip> netcat.o atomicio.o socks.o `pkg-config --libs libbsd` -lresolv -o nc
/bin/sh: 1: pkg-config: not found

What follows is a bunch of link errors for BSD library functions, as
the backtick didn't return anything but an empty string and hence no
BSD library was involved in the link.

I was able to reproduce this by temporarily removing my host version
of pkg-config, and then validated that this fix solves it while still
having the host binary removed.  So it should fix the reported issue.
I also confirmed pkg-config was in the sysroot after the change.

Cc: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb b/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
index bb21e0cfeede..06206a5a59d1 100644
--- a/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
+++ b/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
@@ -4,7 +4,7 @@ HOMEPAGE = "http://ftp.debian.org"
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://../debian/copyright;md5=ee6bbaacb5db5f2973818f0902c3ae6f"
 
-DEPENDS += "glib-2.0 libbsd"
+DEPENDS += "glib-2.0 libbsd pkgconfig-native"
 
 SRC_URI = "${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}.orig.tar.gz;name=netcat \
            ${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}-7.debian.tar.gz;name=netcat-patch"
@@ -42,5 +42,3 @@ do_install() {
     install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN}
 }
 ALTERNATIVE_PRIORITY = "60"
-
-PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130673/"
-- 
2.7.4

Re: [PATCH] netcat-openbsd: fix implicit dependency on pkg-config

[Khem Raj]

On Sat, Feb 18, 2017 at 5:12 PM Paul Gortmaker <paul.gortmaker@windriver.com>
wrote:

> In the report at http://errors.yoctoproject.org/Errors/Details/130673/
> we see the following:
>
> i586-oe-linux-gcc  -m32 -march=i586 <snip> netcat.o atomicio.o socks.o
> `pkg-config --libs libbsd` -lresolv -o nc
> /bin/sh: 1: pkg-config: not found
>
> What follows is a bunch of link errors for BSD library functions, as
> the backtick didn't return anything but an empty string and hence no
> BSD library was involved in the link.
>
> I was able to reproduce this by temporarily removing my host version
> of pkg-config, and then validated that this fix solves it while still
> having the host binary removed.  So it should fix the reported issue.
> I also confirmed pkg-config was in the sysroot after the change.
>
> Cc: Martin Jansa <Martin.Jansa@gmail.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> diff --git a/meta-networking/recipes-support/netcat/
> netcat-openbsd_1.105.bb b/meta-networking/recipes-support/netcat/
> netcat-openbsd_1.105.bb
> index bb21e0cfeede..06206a5a59d1 100644
> --- a/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
> +++ b/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
> @@ -4,7 +4,7 @@ HOMEPAGE = "http://ftp.debian.org"
>  LICENSE = "BSD-3-Clause"
>  LIC_FILES_CHKSUM =
> "file://../debian/copyright;md5=ee6bbaacb5db5f2973818f0902c3ae6f"
>
> -DEPENDS += "glib-2.0 libbsd"
> +DEPENDS += "glib-2.0 libbsd pkgconfig-native"


I think inherit pkgconfig should be the way to go here

>
>
>  SRC_URI =
> "${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}.orig.tar.gz;name=netcat
> \
>
> ${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}-7.debian.tar.gz;name=netcat-patch"
> @@ -42,5 +42,3 @@ do_install() {
>      install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN}
>  }
>  ALTERNATIVE_PRIORITY = "60"
> -
> -PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSS
> http://errors.yoctoproject.org/Errors/Details/130673/"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [PATCH] netcat-openbsd: fix implicit dependency on pkg-config

[Paul Gortmaker]

[Re: [oe] [PATCH] netcat-openbsd: fix implicit dependency on pkg-config] On 19/02/2017 (Sun 06:07) Khem Raj wrote:

> On Sat, Feb 18, 2017 at 5:12 PM Paul Gortmaker <paul.gortmaker@windriver.com>
> wrote:
> 
[...]

> >
> > -DEPENDS += "glib-2.0 libbsd"
> > +DEPENDS += "glib-2.0 libbsd pkgconfig-native"
> 
> 
> I think inherit pkgconfig should be the way to go here

That seems reasonable and would explain why I wasn't seeing a lot of
pre-existing depends on pkgconfig.  I'll test that and send a v2.

Thanks,
Paul.
--

> 
> >
> >
> >  SRC_URI =
> > "${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}.orig.tar.gz;name=netcat
> > \
> >
> > ${DEBIAN_MIRROR}/main/n/netcat-openbsd/netcat-openbsd_${PV}-7.debian.tar.gz;name=netcat-patch"
> > @@ -42,5 +42,3 @@ do_install() {
> >      install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN}
> >  }
> >  ALTERNATIVE_PRIORITY = "60"
> > -
> > -PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSS
> > http://errors.yoctoproject.org/Errors/Details/130673/"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[PATCH v2] netcat-openbsd: fix implicit dependency on pkg-config

[Paul Gortmaker]

In the report at http://errors.yoctoproject.org/Errors/Details/130673/
we see the following:

i586-oe-linux-gcc  -m32 -march=i586 <snip> netcat.o atomicio.o socks.o `pkg-config --libs libbsd` -lresolv -o nc
/bin/sh: 1: pkg-config: not found

What follows is a bunch of link errors for BSD library functions, as
the backtick didn't return anything but an empty string and hence no
BSD library was involved in the link.

I was able to reproduce this by temporarily removing my host version
of pkg-config, and then validated that this fix solves it while still
having the host binary removed.  So it should fix the reported issue.
I also confirmed pkg-config was in the sysroot after the change.

Cc: Khem Raj <raj.khem@gmail.com>
Cc: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[v2: use inherit pkgconfig vs. depending on it, as per what
 Khem suggested as being the more conventional route. ]

 meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb b/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
index bb21e0cfeede..e0a0328eccfc 100644
--- a/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
+++ b/meta-networking/recipes-support/netcat/netcat-openbsd_1.105.bb
@@ -14,6 +14,8 @@ SRC_URI[netcat.sha256sum] = "40653fe66c1516876b61b07e093d826e2a5463c5d994f1b7e6c
 SRC_URI[netcat-patch.md5sum] = "e914f8eb7eda5c75c679dd77787ac76b"
 SRC_URI[netcat-patch.sha256sum] = "eee759327ffea293e81d0dde67921b7fcfcad279ffd7a2c9d037bbc8f882b363"
 
+inherit pkgconfig
+
 S = "${WORKDIR}/${BPN}-${PV}"
 
 EXTRA_OEMAKE += "'LDFLAGS=${LDFLAGS}'"
@@ -42,5 +44,3 @@ do_install() {
     install -m 755 ${S}/nc ${D}${bindir}/nc.${BPN}
 }
 ALTERNATIVE_PRIORITY = "60"
-
-PNBLACKLIST[netcat-openbsd] ?= "Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130673/"
-- 
2.7.4