[meta-networking][PATCH v2] Samba: use built-in libtevent

[meta-networking][PATCH v2] Samba: use built-in libtevent

[Gyorgy Szombathelyi]

Since Samba uses libtevent-internal.h in some places, it is
incompatible with external libtevent versions if they're not
the same as the built-in, and just crashes.

Signed-off-by: Gyorgy Szombathelyi <gyurco@freemail.hu>
---
 meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
index 0ba59c7..754455e 100644
--- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
+++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
@@ -33,7 +33,7 @@ inherit systemd waf-samba cpan-base perlnative update-rc.d
 # remove default added RDEPENDS on perl
 RDEPENDS_${PN}_remove = "perl"
 
-DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 libbsd libaio libpam"
+DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libldb krb5 libbsd libaio libpam"
 DEPENDS_append_libc-musl = " libtirpc"
 CFLAGS_append_libc-musl = " -I${STAGING_INCDIR}/tirpc"
 LDFLAGS_append_libc-musl = " -ltirpc"
@@ -74,7 +74,7 @@ SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pd
 SAMBA4_AUTH_MODULES="auth_unix,auth_wbc,auth_server,auth_netlogond,auth_script,auth_samba4"
 SAMBA4_MODULES="${SAMBA4_IDMAP_MODULES},${SAMBA4_PDB_MODULES},${SAMBA4_AUTH_MODULES}"
 
-SAMBA4_LIBS="heimdal,!zlib,!popt,!talloc,!pytalloc,!pytalloc-util,!tevent,!pytevent,!tdb,!pytdb,!ldb,!pyldb"
+SAMBA4_LIBS="heimdal,!zlib,!popt,!talloc,!pytalloc,!pytalloc-util,tevent,!pytevent,!tdb,!pytdb,!ldb,!pyldb"
 
 EXTRA_OECONF += "--enable-fhs \
                  --with-piddir=/run \
-- 
2.9.3

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Andreas Müller]

On Sat, Feb 11, 2017 at 3:17 PM, Gyorgy Szombathelyi <gyurco@freemail.hu> wrote:
> Since Samba uses libtevent-internal.h in some places, it is
> incompatible with external libtevent versions if they're not
> the same as the built-in, and just crashes.
>
> Signed-off-by: Gyorgy Szombathelyi <gyurco@freemail.hu>
> ---
>  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> index 0ba59c7..754455e 100644
> --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> @@ -33,7 +33,7 @@ inherit systemd waf-samba cpan-base perlnative update-rc.d
>  # remove default added RDEPENDS on perl
>  RDEPENDS_${PN}_remove = "perl"
>
> -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 libbsd libaio libpam"
> +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libldb krb5 libbsd libaio libpam"
>  DEPENDS_append_libc-musl = " libtirpc"
>  CFLAGS_append_libc-musl = " -I${STAGING_INCDIR}/tirpc"
>  LDFLAGS_append_libc-musl = " -ltirpc"
> @@ -74,7 +74,7 @@ SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pd
>  SAMBA4_AUTH_MODULES="auth_unix,auth_wbc,auth_server,auth_netlogond,auth_script,auth_samba4"
>  SAMBA4_MODULES="${SAMBA4_IDMAP_MODULES},${SAMBA4_PDB_MODULES},${SAMBA4_AUTH_MODULES}"
>
> -SAMBA4_LIBS="heimdal,!zlib,!popt,!talloc,!pytalloc,!pytalloc-util,!tevent,!pytevent,!tdb,!pytdb,!ldb,!pyldb"
> +SAMBA4_LIBS="heimdal,!zlib,!popt,!talloc,!pytalloc,!pytalloc-util,tevent,!pytevent,!tdb,!pytdb,!ldb,!pyldb"
>
>  EXTRA_OECONF += "--enable-fhs \
>                   --with-piddir=/run \
> --
> 2.9.3
>
This one causes conflict with libldb. Unfortunately these kind of
conflicts remain undetected (I had error with gvfs but that isn't
build in Martins's world - I guess) [1]. Without RSS I get:

ERROR: samba-4.4.5-r0 do_populate_sysroot: The recipe samba is trying
to install files into a shared area when those files already exist.
Those files and their manifest location are:
   /home/a.mueller/tmp/oe-core-glibc/sysroots/raspberrypi2/usr/lib/python2.7/site-packages/_ldb_text.py
 Matched in b'manifest-raspberrypi2-libldb.populate_sysroot'
 /home/a.mueller/tmp/oe-core-glibc/sysroots/raspberrypi2/usr/lib/python2.7/site-packages/ldb.so
 Matched in b'manifest-raspberrypi2-libldb.populate_sysroot'
 /home/a.mueller/tmp/oe-core-glibc/sysroots/raspberrypi2/usr/lib/python2.7/site-packages/_tevent.so
 Matched in b'manifest-raspberrypi2-libtevent.populate_sysroot'
 /home/a.mueller/tmp/oe-core-glibc/sysroots/raspberrypi2/usr/lib/python2.7/site-packages/tevent.py
 Matched in b'manifest-raspberrypi2-libtevent.populate_sysroot'
Please verify which recipe should provide the above files.
The build has stopped as continuing in this scenario WILL break
things, if not now, possibly in the future (we've seen builds fail
several months later). If the system knew how to recover from this
automatically it would however there are several different scenarios
which can result in this and we don't know which one this is. It may
be you have switched providers of something like virtual/kernel (e.g.
from linux-yocto to linux-yocto-dev), in that case you need to execute
the clean task for both recipes and it will resolve this error. It may
be you changed DISTRO_FEATURES from systemd to udev or vice versa.
Cleaning those recipes should again resolve this error however
switching DISTRO_FEATURES on an existing build directory is not
supported, you should really clean out tmp and rebuild (reusing sstate
should be safe). It could be the overlapping files detected are
harmless in which case adding them to SSTATE_DUPWHITELIST may be the
correct solution. It could also be your build is including two
different conflicting versions of things (e.g. bluez 4 and bluez 5 and
the correct solution for that would be to resolve the conflict. If in
doubt, please ask on the mailing list, sharing the error and filelist
above.
ERROR: samba-4.4.5-r0 do_populate_sysroot: If the above message is too
much, the simpler version is you're advised to wipe out tmp and
rebuild (reusing sstate is fine). That will likely fix things in most
(but not all) cases.
ERROR: samba-4.4.5-r0 do_populate_sysroot: Function failed: sstate_task_postfunc

[1] http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132938.html

Andreas

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 5644 bytes --]

On Mon, Feb 20, 2017 at 01:04:58PM +0100, Andreas Müller wrote:
> On Sat, Feb 11, 2017 at 3:17 PM, Gyorgy Szombathelyi <gyurco@freemail.hu> wrote:
> > Since Samba uses libtevent-internal.h in some places, it is
> > incompatible with external libtevent versions if they're not
> > the same as the built-in, and just crashes.
> >
> > Signed-off-by: Gyorgy Szombathelyi <gyurco@freemail.hu>
> > ---
> >  meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > index 0ba59c7..754455e 100644
> > --- a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > +++ b/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb
> > @@ -33,7 +33,7 @@ inherit systemd waf-samba cpan-base perlnative update-rc.d
> >  # remove default added RDEPENDS on perl
> >  RDEPENDS_${PN}_remove = "perl"
> >
> > -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 libbsd libaio libpam"
> > +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libldb krb5 libbsd libaio libpam"
> >  DEPENDS_append_libc-musl = " libtirpc"
> >  CFLAGS_append_libc-musl = " -I${STAGING_INCDIR}/tirpc"
> >  LDFLAGS_append_libc-musl = " -ltirpc"
> > @@ -74,7 +74,7 @@ SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pd
> >  SAMBA4_AUTH_MODULES="auth_unix,auth_wbc,auth_server,auth_netlogond,auth_script,auth_samba4"
> >  SAMBA4_MODULES="${SAMBA4_IDMAP_MODULES},${SAMBA4_PDB_MODULES},${SAMBA4_AUTH_MODULES}"
> >
> > -SAMBA4_LIBS="heimdal,!zlib,!popt,!talloc,!pytalloc,!pytalloc-util,!tevent,!pytevent,!tdb,!pytdb,!ldb,!pyldb"
> > +SAMBA4_LIBS="heimdal,!zlib,!popt,!talloc,!pytalloc,!pytalloc-util,tevent,!pytevent,!tdb,!pytdb,!ldb,!pyldb"
> >
> >  EXTRA_OECONF += "--enable-fhs \
> >                   --with-piddir=/run \
> > --
> > 2.9.3
> >
> This one causes conflict with libldb. Unfortunately these kind of
> conflicts remain undetected (I had error with gvfs but that isn't
> build in Martins's world - I guess) [1]. Without RSS I get:

In last build I've noticed only this new issue related to samba:

ctdb-2.5.6: ctdb rdepends on samba, but it isn't a build dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]

Maybe this dependency was created from samba being libldb provider in
this build.

gvfs and whole meta-gnome layers is still included in my world, maybe it
didn't fail because some gvfs dependency was already failing or one of
samba related changes in master-next is fixing this one.

Regards,

> 
> ERROR: samba-4.4.5-r0 do_populate_sysroot: The recipe samba is trying
> to install files into a shared area when those files already exist.
> Those files and their manifest location are:
>    /home/a.mueller/tmp/oe-core-glibc/sysroots/raspberrypi2/usr/lib/python2.7/site-packages/_ldb_text.py
>  Matched in b'manifest-raspberrypi2-libldb.populate_sysroot'
>  /home/a.mueller/tmp/oe-core-glibc/sysroots/raspberrypi2/usr/lib/python2.7/site-packages/ldb.so
>  Matched in b'manifest-raspberrypi2-libldb.populate_sysroot'
>  /home/a.mueller/tmp/oe-core-glibc/sysroots/raspberrypi2/usr/lib/python2.7/site-packages/_tevent.so
>  Matched in b'manifest-raspberrypi2-libtevent.populate_sysroot'
>  /home/a.mueller/tmp/oe-core-glibc/sysroots/raspberrypi2/usr/lib/python2.7/site-packages/tevent.py
>  Matched in b'manifest-raspberrypi2-libtevent.populate_sysroot'
> Please verify which recipe should provide the above files.
> The build has stopped as continuing in this scenario WILL break
> things, if not now, possibly in the future (we've seen builds fail
> several months later). If the system knew how to recover from this
> automatically it would however there are several different scenarios
> which can result in this and we don't know which one this is. It may
> be you have switched providers of something like virtual/kernel (e.g.
> from linux-yocto to linux-yocto-dev), in that case you need to execute
> the clean task for both recipes and it will resolve this error. It may
> be you changed DISTRO_FEATURES from systemd to udev or vice versa.
> Cleaning those recipes should again resolve this error however
> switching DISTRO_FEATURES on an existing build directory is not
> supported, you should really clean out tmp and rebuild (reusing sstate
> should be safe). It could be the overlapping files detected are
> harmless in which case adding them to SSTATE_DUPWHITELIST may be the
> correct solution. It could also be your build is including two
> different conflicting versions of things (e.g. bluez 4 and bluez 5 and
> the correct solution for that would be to resolve the conflict. If in
> doubt, please ask on the mailing list, sharing the error and filelist
> above.
> ERROR: samba-4.4.5-r0 do_populate_sysroot: If the above message is too
> much, the simpler version is you're advised to wipe out tmp and
> rebuild (reusing sstate is fine). That will likely fix things in most
> (but not all) cases.
> ERROR: samba-4.4.5-r0 do_populate_sysroot: Function failed: sstate_task_postfunc
> 
> [1] http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132938.html
> 
> Andreas
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Andreas Müller]

> In last build I've noticed only this new issue related to samba:
>
> ctdb-2.5.6: ctdb rdepends on samba, but it isn't a build dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
>
> Maybe this dependency was created from samba being libldb provider in
> this build.
>
> gvfs and whole meta-gnome layers is still included in my world, maybe it
> didn't fail because some gvfs dependency was already failing or one of
> samba related changes in master-next is fixing this one.
>
Some background: During last weekend I prepared a series based on
master-next unblacklisting. First target is to build a xfce-image
again [1]. Last step yesterday evening should be rebasing against
latest master-next and run a test build. That failed for gvfs - so I
stopped sending stuff. Now I know why gvfs fails...

How do we proceed with this patch?

[1] https://github.com/schnitzeltony/meta-openembedded/tree/work-2017-02

Andreas

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 5028 bytes --]

On Mon, Feb 20, 2017 at 01:51:49PM +0100, Andreas Müller wrote:
> > In last build I've noticed only this new issue related to samba:
> >
> > ctdb-2.5.6: ctdb rdepends on samba, but it isn't a build dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
> >
> > Maybe this dependency was created from samba being libldb provider in
> > this build.
> >
> > gvfs and whole meta-gnome layers is still included in my world, maybe it
> > didn't fail because some gvfs dependency was already failing or one of
> > samba related changes in master-next is fixing this one.
> >
> Some background: During last weekend I prepared a series based on
> master-next unblacklisting.

Weren't all of these merged before the blacklist in master on Sunday?

044e51895 smbnetfs gnome-disk-utility contacts kexecboot initramfs-kexecboot-klibc-image system-config-keyboard system-setup-keyboard geany geany-plugins efivar efibootmgr gimp system-config-keyboard tumbler: Blacklistptography-vectors python3-ndg-httpsclient python-cryptography-vectors python-pbr bundler netdata menulibre openzone xfce4-verve-plugin iperf terminus-font xf86-video-nouveau ipmiutil klibc-utils pmbw multipath-tools gparted, gnome-system-monitor, php, vala-dbus-binding-tool, gtkmathview, lmsensors, postgresql: Blacklist
92a1d82b0 gnome-disk-utility: add dbus-glib-native to DEPENDS
cfad4bab5 nostromo: add base-passwd to DEPENDS
38813ff30 sthttpd: add base-passwd to DEPENDS
7b62fe8ea xfce4-notifyd: add dbus-glib-native to DEPENDS
f501f7a26 geany: fix build
ffd750f0d abiword: fix build
6bb7f371d gedit: fix build
d34a32cf3 gegl: fix build
786d11d77 libgnomeui: fix build
6f9b762d0 evolution-data-server: fix build
ca8ddbe66 poppler: add qttools-native to qt5 dependency to fix build
928849af3 libglade: fix build and cleanup
f35f4fbb7 esound: fix build
765ac5125 audiofile: add alsa-lib to DEPENDS
93a44dfa4 exfat-utils: update SRC_URI
f87a2b06a glibmm: add dependency on glib-2.0-native

If I have missed some, please resend them. Currently master-next has only
couple (20) changes for meta-networking and new changes (10 for apache2,
lvm2, gitpkgv) from last 2 days which are now being built on jenkins.

$ git log --oneline origin/master..origin/master-next 
51f1b50ba gitpkgv.bbclass: fix versioning with multiple repos
41c5a0f4b netcat-openbsd: fix implicit dependency on pkg-config
29880b781 lvm2: Move libdevmapper to a separate package
e1d9fe8c2 lvm2: Move bash scripts to a separate package
b524e0d7f lvm2: Add a PACKAGECONFIG for lvmetad
02342e3e8 lvm2: Add a PACKAGECONFIG for dmeventd
edbcf88b2 lvm2: Add a PACKAGECONFIG for udev support
0d8ed3a91 lvm2: Standardize how PACKAGECONFIG is defined
daf140bd7 lvm2: Make sure odirect is always enabled
4b8449cdc lvm2: Depend on autoconf-archive-native instead of autoconf-archive
5c752a3cf apache2: Correct the SRC_URI
a40798024 libldb: update package split rules
dcdb7c78f inetutils: update files for -dbg packages
27c27bd91 openconnect: add gettext-native to DEPENDS
cd8780d24 openflow: inherit pkgconfig
5a9f66f13 Samba: use built-in libtevent
f0441dae1 tcpdump: update to 4.9.0 for security fixes
865b175ee wireshark: fix build issue
068a82479 lldpd: Update to version 0.9.6
38b751ec7 inetutils: register hostname.1 man page as an alternate
17beda82a wireshark: update package to 2.2.4
e1968a360 iscsitarget: update patch to contain changes required to build with only linux v4.8 and above
085e8a140 iscsitarget: use upstream to build with linux kernel >= 4.3
7a1bd1a1d iscsitarget: fix inconsistent crash while login to iscsi target from initiator
ae911f1f5 dibbler: fix SRC_URI from ${P} to ${BP}
2b451aaac relayd: derive PV from SRCPV
b07f47fbd iscsitarget: Fix call trace of ahash API calling
2998d7c54 tcpdump: upgrade to 4.8.1
4fb056126 lftp: update to 4.7.5 and change SRC_URI source
8186ef64a opensaf: 5.0.0 -> 5.1.0

> First target is to build a xfce-image
> again [1]. Last step yesterday evening should be rebasing against
> latest master-next and run a test build. That failed for gvfs - so I
> stopped sending stuff. Now I know why gvfs fails...

This branch has many good changes, please send them to ML soonish even
with gvfs failing (or preferably blacklisted until this is resolved) and
I'll happily test and merge as much as possible.

> How do we proceed with this patch?

Only now I've noticed that you're replying on change which is still only in
master-next and not master, so if it's causing issue for gvfs (and ctdb, then
I'll drop
5a9f66f13 Samba: use built-in libtevent
from master-next and Joe can re-visit it later.

> [1] https://github.com/schnitzeltony/meta-openembedded/tree/work-2017-02
> 
> Andreas
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Szombathelyi György]

Hi,

If there's no solution to resolve the conflict between the internal tevent and the external one, then maybe putting the libtevent-internal.h from the external lib to the samba tree would be a way to go.

Br,
György
-------- Eredeti levél --------
Feladó: Andreas Müller <schnitzeltony@googlemail.com>
Dátum: 2017 február 20 12:52:18
Tárgy: Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent
Címzett: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org>
 
> In last build I've noticed only this new issue related to samba:
>
> ctdb-2.5.6: ctdb rdepends on samba, but it isn't a build dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
>
> Maybe this dependency was created from samba being libldb provider in
> this build.
>
> gvfs and whole meta-gnome layers is still included in my world, maybe it
> didn't fail because some gvfs dependency was already failing or one of
> samba related changes in master-next is fixing this one.
>
Some background: During last weekend I prepared a series based on
master-next unblacklisting. First target is to build a xfce-image
again [1]. Last step yesterday evening should be rebasing against
latest master-next and run a test build. That failed for gvfs - so I
stopped sending stuff. Now I know why gvfs fails...

How do we proceed with this patch?

[1] https://github.com/schnitzeltony/meta-openembedded/tree/work-2017-02

Andreas
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Andreas Müller]

On Mon, Feb 20, 2017 at 5:08 PM, Szombathelyi György <gyurco@freemail.hu> wrote:
> Hi,
>
> If there&#39;s no solution to resolve the conflict between the internal tevent and the external one, then maybe putting the libtevent-internal.h from the external lib to the samba tree would be a way to go.
>
> Br,
> György
> -------- Eredeti levél --------
> Feladó: Andreas Müller &lt;schnitzeltony&#64;googlemail.com&gt;
> Dátum: 2017 február 20 12:52:18
> Tárgy: Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent
> Címzett: openembedded-devel&#64;lists.openembedded.org &lt;openembedded-devel&#64;lists.openembedded.org&gt;
>
> &gt; In last build I&#39;ve noticed only this new issue related to samba:
> &gt;
> &gt; ctdb-2.5.6: ctdb rdepends on samba, but it isn&#39;t a build dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
> &gt;
> &gt; Maybe this dependency was created from samba being libldb provider in
> &gt; this build.
> &gt;
> &gt; gvfs and whole meta-gnome layers is still included in my world, maybe it
> &gt; didn&#39;t fail because some gvfs dependency was already failing or one of
> &gt; samba related changes in master-next is fixing this one.
> &gt;
> Some background: During last weekend I prepared a series based on
> master-next unblacklisting. First target is to build a xfce-image
> again [1]. Last step yesterday evening should be rebasing against
> latest master-next and run a test build. That failed for gvfs - so I
> stopped sending stuff. Now I know why gvfs fails...
>
> How do we proceed with this patch?
>
> [1] https://github.com/schnitzeltony/meta-openembedded/tree/work-2017-02
>
Just notices that this patch made it into master breaking at least gvfs. Revert?

Andreas

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Martin Jansa]

Joe?

On Fri, Feb 24, 2017 at 10:37 PM, Andreas Müller <
schnitzeltony@googlemail.com> wrote:

> On Mon, Feb 20, 2017 at 5:08 PM, Szombathelyi György <gyurco@freemail.hu>
> wrote:
> > Hi,
> >
> > If there&#39;s no solution to resolve the conflict between the internal
> tevent and the external one, then maybe putting the libtevent-internal.h
> from the external lib to the samba tree would be a way to go.
> >
> > Br,
> > György
> > -------- Eredeti levél --------
> > Feladó: Andreas Müller &lt;schnitzeltony&#64;googlemail.com&gt;
> > Dátum: 2017 február 20 12:52:18
> > Tárgy: Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent
> > Címzett: openembedded-devel&#64;lists.openembedded.org
> &lt;openembedded-devel&#64;lists.openembedded.org&gt;
> >
> > &gt; In last build I&#39;ve noticed only this new issue related to samba:
> > &gt;
> > &gt; ctdb-2.5.6: ctdb rdepends on samba, but it isn&#39;t a build
> dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
> > &gt;
> > &gt; Maybe this dependency was created from samba being libldb provider
> in
> > &gt; this build.
> > &gt;
> > &gt; gvfs and whole meta-gnome layers is still included in my world,
> maybe it
> > &gt; didn&#39;t fail because some gvfs dependency was already failing or
> one of
> > &gt; samba related changes in master-next is fixing this one.
> > &gt;
> > Some background: During last weekend I prepared a series based on
> > master-next unblacklisting. First target is to build a xfce-image
> > again [1]. Last step yesterday evening should be rebasing against
> > latest master-next and run a test build. That failed for gvfs - so I
> > stopped sending stuff. Now I know why gvfs fails...
> >
> > How do we proceed with this patch?
> >
> > [1] https://github.com/schnitzeltony/meta-openembedded/tree/work-2017-02
> >
> Just notices that this patch made it into master breaking at least gvfs.
> Revert?
>
> Andreas
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[MacDonald, Joe]

Yeah.  If you're near a keyboard, please go ahead and revert otherwise I'll get to in later on tonight.

On Feb 24, 2017 5:01 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
Joe?

On Fri, Feb 24, 2017 at 10:37 PM, Andreas Müller <schnitzeltony@googlemail.com<mailto:schnitzeltony@googlemail.com>> wrote:
On Mon, Feb 20, 2017 at 5:08 PM, Szombathelyi György <gyurco@freemail.hu<mailto:gyurco@freemail.hu>> wrote:
> Hi,
>
> If there&#39;s no solution to resolve the conflict between the internal tevent and the external one, then maybe putting the libtevent-internal.h from the external lib to the samba tree would be a way to go.
>
> Br,
> György
> -------- Eredeti levél --------
> Feladó: Andreas Müller &lt;schnitzeltony&#64;googlemail.com<http://googlemail.com>&gt;
> Dátum: 2017 február 20 12:52:18
> Tárgy: Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent
> Címzett: openembedded-devel&#64;lists.openembedded.org<http://lists.openembedded.org> &lt;openembedded-devel&#64;lists.openembedded.org<http://lists.openembedded.org>&gt;
>
> &gt; In last build I&#39;ve noticed only this new issue related to samba:
> &gt;
> &gt; ctdb-2.5.6: ctdb rdepends on samba, but it isn&#39;t a build dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
> &gt;
> &gt; Maybe this dependency was created from samba being libldb provider in
> &gt; this build.
> &gt;
> &gt; gvfs and whole meta-gnome layers is still included in my world, maybe it
> &gt; didn&#39;t fail because some gvfs dependency was already failing or one of
> &gt; samba related changes in master-next is fixing this one.
> &gt;
> Some background: During last weekend I prepared a series based on
> master-next unblacklisting. First target is to build a xfce-image
> again [1]. Last step yesterday evening should be rebasing against
> latest master-next and run a test build. That failed for gvfs - so I
> stopped sending stuff. Now I know why gvfs fails...
>
> How do we proceed with this patch?
>
> [1] https://github.com/schnitzeltony/meta-openembedded/tree/work-2017-02
>
Just notices that this patch made it into master breaking at least gvfs. Revert?

Andreas
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org<mailto:Openembedded-devel@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 3094 bytes --]

[Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent] On 17.02.24 (Fri 22:33) MacDonald, Joe wrote:

> Yeah.  If you're near a keyboard, please go ahead and revert otherwise
> I'll get to in later on tonight.

Bah.  This isn't just the revert I'd been hoping for.  Samba, as usual,
is a pain.  My builds without gvfs are still happy, but reverting the
patch breaks all builds, AFAICT, so I'm going to leave this alone until
I sort out what the correct repair job looks like here.  Unless someone
comes up with a solution before I get to it.  The weekend is rather full
right now, I'm afraid.

-J.

> 
> On Feb 24, 2017 5:01 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> Joe?
> 
> On Fri, Feb 24, 2017 at 10:37 PM, Andreas Müller <schnitzeltony@googlemail.com<mailto:schnitzeltony@googlemail.com>> wrote:
> On Mon, Feb 20, 2017 at 5:08 PM, Szombathelyi György <gyurco@freemail.hu<mailto:gyurco@freemail.hu>> wrote:
> > Hi,
> >
> > If there&#39;s no solution to resolve the conflict between the internal tevent and the external one, then maybe putting the libtevent-internal.h from the external lib to the samba tree would be a way to go.
> >
> > Br,
> > György
> > -------- Eredeti levél --------
> > Feladó: Andreas Müller &lt;schnitzeltony&#64;googlemail.com<http://googlemail.com>&gt;
> > Dátum: 2017 február 20 12:52:18
> > Tárgy: Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent
> > Címzett: openembedded-devel&#64;lists.openembedded.org<http://lists.openembedded.org> &lt;openembedded-devel&#64;lists.openembedded.org<http://lists.openembedded.org>&gt;
> >
> > &gt; In last build I&#39;ve noticed only this new issue related to samba:
> > &gt;
> > &gt; ctdb-2.5.6: ctdb rdepends on samba, but it isn&#39;t a build dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
> > &gt;
> > &gt; Maybe this dependency was created from samba being libldb provider in
> > &gt; this build.
> > &gt;
> > &gt; gvfs and whole meta-gnome layers is still included in my world, maybe it
> > &gt; didn&#39;t fail because some gvfs dependency was already failing or one of
> > &gt; samba related changes in master-next is fixing this one.
> > &gt;
> > Some background: During last weekend I prepared a series based on
> > master-next unblacklisting. First target is to build a xfce-image
> > again [1]. Last step yesterday evening should be rebasing against
> > latest master-next and run a test build. That failed for gvfs - so I
> > stopped sending stuff. Now I know why gvfs fails...
> >
> > How do we proceed with this patch?
> >
> > [1] https://github.com/schnitzeltony/meta-openembedded/tree/work-2017-02
> >
> Just notices that this patch made it into master breaking at least gvfs. Revert?
> 
> Andreas
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org<mailto:Openembedded-devel@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> 
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Martin Jansa]

> My builds without gvfs are still happy, but reverting the
patch breaks all builds

What gets broken? When I removed this change from master-next after
Andreas's report I haven't seen any new issue and the gvfs one was indeed
fixed after that.

I'll include revert at least in master-next to see what it does with next
bitbake world.

On Sat, Feb 25, 2017 at 4:42 AM, Joe MacDonald <Joe_MacDonald@mentor.com>
wrote:

> [Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent] On
> 17.02.24 (Fri 22:33) MacDonald, Joe wrote:
>
> > Yeah.  If you're near a keyboard, please go ahead and revert otherwise
> > I'll get to in later on tonight.
>
> Bah.  This isn't just the revert I'd been hoping for.  Samba, as usual,
> is a pain.  My builds without gvfs are still happy, but reverting the
> patch breaks all builds, AFAICT, so I'm going to leave this alone until
> I sort out what the correct repair job looks like here.  Unless someone
> comes up with a solution before I get to it.  The weekend is rather full
> right now, I'm afraid.
>
> -J.
>
> >
> > On Feb 24, 2017 5:01 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > Joe?
> >
> > On Fri, Feb 24, 2017 at 10:37 PM, Andreas Müller <
> schnitzeltony@googlemail.com<mailto:schnitzeltony@googlemail.com>> wrote:
> > On Mon, Feb 20, 2017 at 5:08 PM, Szombathelyi György <gyurco@freemail.hu
> <mailto:gyurco@freemail.hu>> wrote:
> > > Hi,
> > >
> > > If there&#39;s no solution to resolve the conflict between the
> internal tevent and the external one, then maybe putting the
> libtevent-internal.h from the external lib to the samba tree would be a way
> to go.
> > >
> > > Br,
> > > György
> > > -------- Eredeti levél --------
> > > Feladó: Andreas Müller &lt;schnitzeltony&#64;googlemail.com<
> http://googlemail.com>&gt;
> > > Dátum: 2017 február 20 12:52:18
> > > Tárgy: Re: [oe] [meta-networking][PATCH v2] Samba: use built-in
> libtevent
> > > Címzett: openembedded-devel&#64;lists.openembedded.org<http://lists.
> openembedded.org> &lt;openembedded-devel&#64;lists.openembedded.org<
> http://lists.openembedded.org>&gt;
> > >
> > > &gt; In last build I&#39;ve noticed only this new issue related to
> samba:
> > > &gt;
> > > &gt; ctdb-2.5.6: ctdb rdepends on samba, but it isn&#39;t a build
> dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
> > > &gt;
> > > &gt; Maybe this dependency was created from samba being libldb
> provider in
> > > &gt; this build.
> > > &gt;
> > > &gt; gvfs and whole meta-gnome layers is still included in my world,
> maybe it
> > > &gt; didn&#39;t fail because some gvfs dependency was already failing
> or one of
> > > &gt; samba related changes in master-next is fixing this one.
> > > &gt;
> > > Some background: During last weekend I prepared a series based on
> > > master-next unblacklisting. First target is to build a xfce-image
> > > again [1]. Last step yesterday evening should be rebasing against
> > > latest master-next and run a test build. That failed for gvfs - so I
> > > stopped sending stuff. Now I know why gvfs fails...
> > >
> > > How do we proceed with this patch?
> > >
> > > [1] https://github.com/schnitzeltony/meta-
> openembedded/tree/work-2017-02
> > >
> > Just notices that this patch made it into master breaking at least gvfs.
> Revert?
> >
> > Andreas
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org<mailto:Openem
> bedded-devel@lists.openembedded.org>
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
> --
> -Joe MacDonald.
> :wq
>

Re: [meta-networking][PATCH v2] Samba: use built-in libtevent

[Joe MacDonald]

[-- Attachment #1: Type: text/plain, Size: 4479 bytes --]

[Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent] On 17.02.25 (Sat 09:20) Martin Jansa wrote:

> > My builds without gvfs are still happy, but reverting the patch
> > breaks all builds
> 
> What gets broken? When I removed this change from master-next after
> Andreas's report I haven't seen any new issue and the gvfs one was
> indeed fixed after that.
> 
> I'll include revert at least in master-next to see what it does with
> next bitbake world.

The failure wasn't specifically an error, it was a ton of QA warnings
about missing providers for libtevent.  After abandoning the previous
build and starting fresh, as the autobuilder would, it seems okay with
the revert, so we'll go with that approach.

-J.

> 
> On Sat, Feb 25, 2017 at 4:42 AM, Joe MacDonald <Joe_MacDonald@mentor.com>
> wrote:
> 
>     [Re: [oe] [meta-networking][PATCH v2] Samba: use built-in libtevent] On
>     17.02.24 (Fri 22:33) MacDonald, Joe wrote:
> 
>     > Yeah.  If you're near a keyboard, please go ahead and revert otherwise
>     > I'll get to in later on tonight.
> 
>     Bah.  This isn't just the revert I'd been hoping for.  Samba, as usual,
>     is a pain.  My builds without gvfs are still happy, but reverting the
>     patch breaks all builds, AFAICT, so I'm going to leave this alone until
>     I sort out what the correct repair job looks like here.  Unless someone
>     comes up with a solution before I get to it.  The weekend is rather full
>     right now, I'm afraid.
> 
>     -J.
>    
>     >
>     > On Feb 24, 2017 5:01 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>     > Joe?
>     >
>     > On Fri, Feb 24, 2017 at 10:37 PM, Andreas Müller <
>     schnitzeltony@googlemail.com<mailto:schnitzeltony@googlemail.com>> wrote:
>     > On Mon, Feb 20, 2017 at 5:08 PM, Szombathelyi György <gyurco@freemail.hu
>     <mailto:gyurco@freemail.hu>> wrote:
>     > > Hi,
>     > >
>     > > If there&#39;s no solution to resolve the conflict between the internal
>     tevent and the external one, then maybe putting the libtevent-internal.h
>     from the external lib to the samba tree would be a way to go.
>     > >
>     > > Br,
>     > > György
>     > > -------- Eredeti levél --------
>     > > Feladó: Andreas Müller &lt;schnitzeltony&#64;googlemail.com<http://
>     googlemail.com>&gt;
>     > > Dátum: 2017 február 20 12:52:18
>     > > Tárgy: Re: [oe] [meta-networking][PATCH v2] Samba: use built-in
>     libtevent
>     > > Címzett: openembedded-devel&#64;lists.openembedded.org<http://lists.
>     openembedded.org> &lt;openembedded-devel&#64;lists.openembedded.org<http://
>     lists.openembedded.org>&gt;
>     > >
>     > > &gt; In last build I&#39;ve noticed only this new issue related to
>     samba:
>     > > &gt;
>     > > &gt; ctdb-2.5.6: ctdb rdepends on samba, but it isn&#39;t a build
>     dependency, missing samba in DEPENDS or PACKAGECONFIG? [build-deps]
>     > > &gt;
>     > > &gt; Maybe this dependency was created from samba being libldb provider
>     in
>     > > &gt; this build.
>     > > &gt;
>     > > &gt; gvfs and whole meta-gnome layers is still included in my world,
>     maybe it
>     > > &gt; didn&#39;t fail because some gvfs dependency was already failing
>     or one of
>     > > &gt; samba related changes in master-next is fixing this one.
>     > > &gt;
>     > > Some background: During last weekend I prepared a series based on
>     > > master-next unblacklisting. First target is to build a xfce-image
>     > > again [1]. Last step yesterday evening should be rebasing against
>     > > latest master-next and run a test build. That failed for gvfs - so I
>     > > stopped sending stuff. Now I know why gvfs fails...
>     > >
>     > > How do we proceed with this patch?
>     > >
>     > > [1] https://github.com/schnitzeltony/meta-openembedded/tree/
>     work-2017-02
>     > >
>     > Just notices that this patch made it into master breaking at least gvfs.
>     Revert?
>     >
>     > Andreas
>     > --
>     > _______________________________________________
>     > Openembedded-devel mailing list
>     > Openembedded-devel@lists.openembedded.org<mailto:Openem
>     bedded-devel@lists.openembedded.org>
>     > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>     >
>     >
>     --
>     -Joe MacDonald.
>     :wq
> 
> 

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]