From: rask@formelder.dk (Rask Ingemann Lambertsen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun8i: NanoPi NEO Air add WiFi / eMMC
Date: Mon, 20 Feb 2017 19:52:03 +0100 [thread overview]
Message-ID: <20170220185202.ficvrxkb26v6enz2@localhost> (raw)
In-Reply-To: <20170219143848.25911-1-jelle@vdwaa.nl>
On Sun, Feb 19, 2017 at 03:38:48PM +0100, Jelle van der Waa wrote:
> Enable the WiFi (AP6212) chip and eMMC support for the NanoPi NEO Air.
>
> Signed-off-by: Jelle van der Waa <jelle@vdwaa.nl>
> ---
> arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts | 45 +++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
> index 3ba081c1f555..3813156f5d35 100644
> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
> @@ -73,6 +73,13 @@
> gpios = <&pio 0 10 GPIO_ACTIVE_HIGH>; /* PA10 */
> };
> };
> +
> + wifi_pwrseq: wifi_pwrseq {
There should not be underscores in node names. See e.g.:
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html
https://www.mail-archive.com/netdev%40vger.kernel.org/msg90319.html
> +&r_pio {
> + wifi_en_nanopi_neo_air: wifi_en_pin {
> + allwinner,pins = "PL7";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +};
1. Underscores in the node name.
2. Pinmux nodes for GPIO usage is considered unnecessary or even harmful
these days. As a bonus, you avoid a duplicate definition.
3. Please use the generic properties, as in
pins = "PL7";
function ="gpio_out";
drive-strength = <10>;
bias-disable;
(but you should just drop the node in this case).
(Do we not usually address the dts maintainers directly when submitting
device tree patches? Just wondering.)
--
Rask Ingemann Lambertsen
WARNING: multiple messages have this Message-ID (diff)
From: Rask Ingemann Lambertsen <rask-SivP7zSAdNDZaaYASwVUlg@public.gmane.org>
To: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>
Cc: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: sun8i: NanoPi NEO Air add WiFi / eMMC
Date: Mon, 20 Feb 2017 19:52:03 +0100 [thread overview]
Message-ID: <20170220185202.ficvrxkb26v6enz2@localhost> (raw)
In-Reply-To: <20170219143848.25911-1-jelle-oJJ1AqDjjO4@public.gmane.org>
On Sun, Feb 19, 2017 at 03:38:48PM +0100, Jelle van der Waa wrote:
> Enable the WiFi (AP6212) chip and eMMC support for the NanoPi NEO Air.
>
> Signed-off-by: Jelle van der Waa <jelle-oJJ1AqDjjO4@public.gmane.org>
> ---
> arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts | 45 +++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
> index 3ba081c1f555..3813156f5d35 100644
> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-neo-air.dts
> @@ -73,6 +73,13 @@
> gpios = <&pio 0 10 GPIO_ACTIVE_HIGH>; /* PA10 */
> };
> };
> +
> + wifi_pwrseq: wifi_pwrseq {
There should not be underscores in node names. See e.g.:
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html
https://www.mail-archive.com/netdev%40vger.kernel.org/msg90319.html
> +&r_pio {
> + wifi_en_nanopi_neo_air: wifi_en_pin {
> + allwinner,pins = "PL7";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +};
1. Underscores in the node name.
2. Pinmux nodes for GPIO usage is considered unnecessary or even harmful
these days. As a bonus, you avoid a duplicate definition.
3. Please use the generic properties, as in
pins = "PL7";
function ="gpio_out";
drive-strength = <10>;
bias-disable;
(but you should just drop the node in this case).
(Do we not usually address the dts maintainers directly when submitting
device tree patches? Just wondering.)
--
Rask Ingemann Lambertsen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-20 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 14:38 [PATCH] ARM: dts: sun8i: NanoPi NEO Air add WiFi / eMMC Jelle van der Waa
2017-02-19 14:38 ` Jelle van der Waa
2017-02-20 18:52 ` Rask Ingemann Lambertsen [this message]
2017-02-20 18:52 ` Rask Ingemann Lambertsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220185202.ficvrxkb26v6enz2@localhost \
--to=rask@formelder.dk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.