From: Anatolij Gustschin <agust@denx.de>
To: Moritz Fischer <mdf@kernel.org>
Cc: linux-fpga@vger.kernel.org,
Devicetree List <devicetree@vger.kernel.org>,
Alan Tull <atull@opensource.altera.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 2/2] fpga manager: Add Xilinx slave serial SPI driver
Date: Mon, 20 Feb 2017 21:05:04 +0100 [thread overview]
Message-ID: <20170220210504.2473ce90@crub> (raw)
In-Reply-To: <CAAtXAHeO_+6ZXP51nxFgyLYR9cjqLrqmoYEniqXmZudF=3uhFA@mail.gmail.com>
Hi Moritz,
On Mon, 20 Feb 2017 09:27:35 -0800
Moritz Fischer mdf@kernel.org wrote:
>Anatolij,
>
>small nits inline.
...
>> + gpiod_set_value(conf->prog_b, 1);
>> +
>> + udelay(1); /* min is 500 ns */
>
>Maybe make this a named constant.
Okay, I can add
const size_t prog_pulse_us = 1;
...
udelay(prog_pulse_us);
...
>> + gpiod_set_value(conf->prog_b, 0);
>> +
>> + if (gpiod_get_value(conf->done)) {
>> + dev_err(&mgr->dev, "Unexpected DONE pin state...\n");
>> + return -EIO;
>> + }
>> +
>> + /* program latency */
>> + usleep_range(1000, 1500);
>
>Same here.
Okay, will change here as well.
Thanks for review! I'll wait some time for more comments and
will submit v3 then.
Anatolij
WARNING: multiple messages have this Message-ID (diff)
From: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>
To: Moritz Fischer <mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Devicetree List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Alan Tull
<atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH v2 2/2] fpga manager: Add Xilinx slave serial SPI driver
Date: Mon, 20 Feb 2017 21:05:04 +0100 [thread overview]
Message-ID: <20170220210504.2473ce90@crub> (raw)
In-Reply-To: <CAAtXAHeO_+6ZXP51nxFgyLYR9cjqLrqmoYEniqXmZudF=3uhFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Moritz,
On Mon, 20 Feb 2017 09:27:35 -0800
Moritz Fischer mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org wrote:
>Anatolij,
>
>small nits inline.
...
>> + gpiod_set_value(conf->prog_b, 1);
>> +
>> + udelay(1); /* min is 500 ns */
>
>Maybe make this a named constant.
Okay, I can add
const size_t prog_pulse_us = 1;
...
udelay(prog_pulse_us);
...
>> + gpiod_set_value(conf->prog_b, 0);
>> +
>> + if (gpiod_get_value(conf->done)) {
>> + dev_err(&mgr->dev, "Unexpected DONE pin state...\n");
>> + return -EIO;
>> + }
>> +
>> + /* program latency */
>> + usleep_range(1000, 1500);
>
>Same here.
Okay, will change here as well.
Thanks for review! I'll wait some time for more comments and
will submit v3 then.
Anatolij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-20 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 14:25 [PATCH v2 0/2] Xilinx Slave Serial FPGA Manager Anatolij Gustschin
[not found] ` <1487600724-17607-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-02-20 14:25 ` [PATCH v2 1/2] dt: bindings: fpga: add xilinx slave-serial binding description Anatolij Gustschin
[not found] ` <1487600724-17607-2-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-02-20 17:28 ` Moritz Fischer
2017-02-20 14:25 ` [PATCH v2 2/2] fpga manager: Add Xilinx slave serial SPI driver Anatolij Gustschin
[not found] ` <1487600724-17607-3-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-02-20 17:27 ` Moritz Fischer
2017-02-20 20:05 ` Anatolij Gustschin [this message]
2017-02-20 20:05 ` Anatolij Gustschin
2017-02-21 14:01 ` Michal Simek
[not found] ` <2d412ae7-4163-9943-6d98-2d6387df7789-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2017-02-21 14:24 ` Anatolij Gustschin
2017-02-21 14:51 ` Michal Simek
[not found] ` <19e0b5d1-bbf6-25ac-2698-6074ebafcf05-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2017-02-21 15:17 ` Anatolij Gustschin
2017-02-21 15:27 ` Michal Simek
[not found] ` <ce0d7ba7-fa05-ad55-407c-3903553ace65-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2017-02-21 15:39 ` Anatolij Gustschin
2017-02-21 18:53 ` Michal Simek
[not found] ` <3a30638c-68f6-8c2b-95b7-c8c700fe4867-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2017-02-21 20:24 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220210504.2473ce90@crub \
--to=agust@denx.de \
--cc=atull@opensource.altera.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.