From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings
Date: Tue, 21 Feb 2017 16:25:45 +0300 [thread overview]
Message-ID: <20170221132545.GD13174@node.shutemov.name> (raw)
In-Reply-To: <20170216184100.GS25530@redhat.com>
On Thu, Feb 16, 2017 at 07:41:00PM +0100, Andrea Arcangeli wrote:
> Kirill what's your take on making the registration checks stricter?
> If we would add a vma_is_anonymous_not_in_fault implemented like above
> vma_can_userfault would just need a
> s/vma_is_anonymous/vma_is_anonymous_not_in_fault/ and it would be more
> strict. khugepaged could be then converted to use it too instead of
> hardcoding this vm_flags check. Unless I'm mistaken I would consider
> such a change to the registration code, purely a cleanup to add a more
> strict check.
[sorry for later response]
I think more strict vma_is_anonymous() is a good thing.
But I don't see a point introducing one more helper. Let's just make the
existing helper work better.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings
Date: Tue, 21 Feb 2017 16:25:45 +0300 [thread overview]
Message-ID: <20170221132545.GD13174@node.shutemov.name> (raw)
In-Reply-To: <20170216184100.GS25530@redhat.com>
On Thu, Feb 16, 2017 at 07:41:00PM +0100, Andrea Arcangeli wrote:
> Kirill what's your take on making the registration checks stricter?
> If we would add a vma_is_anonymous_not_in_fault implemented like above
> vma_can_userfault would just need a
> s/vma_is_anonymous/vma_is_anonymous_not_in_fault/ and it would be more
> strict. khugepaged could be then converted to use it too instead of
> hardcoding this vm_flags check. Unless I'm mistaken I would consider
> such a change to the registration code, purely a cleanup to add a more
> strict check.
[sorry for later response]
I think more strict vma_is_anonymous() is a good thing.
But I don't see a point introducing one more helper. Let's just make the
existing helper work better.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2017-02-21 13:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 21:46 [PATCH] userfaultfd: hugetlbfs: add UFFDIO_COPY support for shared mappings Mike Kravetz
2017-02-15 21:46 ` Mike Kravetz
2017-02-16 18:41 ` Andrea Arcangeli
2017-02-16 18:41 ` Andrea Arcangeli
2017-02-17 0:18 ` Mike Kravetz
2017-02-17 0:18 ` Mike Kravetz
2017-02-17 15:52 ` Andrea Arcangeli
2017-02-17 15:52 ` Andrea Arcangeli
2017-02-17 20:17 ` Andrew Morton
2017-02-17 20:17 ` Andrew Morton
2017-02-17 20:51 ` Andrea Arcangeli
2017-02-17 20:51 ` Andrea Arcangeli
2017-02-17 21:08 ` Andrew Morton
2017-02-17 21:08 ` Andrew Morton
2017-02-17 21:34 ` Andrea Arcangeli
2017-02-17 21:34 ` Andrea Arcangeli
2017-02-21 13:25 ` Kirill A. Shutemov [this message]
2017-02-21 13:25 ` Kirill A. Shutemov
2017-02-22 15:15 ` Andrea Arcangeli
2017-02-22 15:15 ` Andrea Arcangeli
2017-02-23 14:56 ` Kirill A. Shutemov
2017-02-23 14:56 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221132545.GD13174@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dgilbert@redhat.com \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.