From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] dmaengine: bcm2835: Fix cyclic DMA period splitting
Date: Wed, 22 Feb 2017 08:11:41 +0530 [thread overview]
Message-ID: <20170222024140.GV2843@localhost> (raw)
In-Reply-To: <20170220190115.GB4170@camel2.lan>
On Mon, Feb 20, 2017 at 08:01:16PM +0100, Matthias Reichl wrote:
> The code responsible for splitting periods into chunks that
> can be handled by the DMA controller missed to update total_len,
> the number of bytes processed in the current period, when there
> are more chunks to follow.
>
> Therefore total_len was stuck at 0 and the code didn't work at all.
> This resulted in a wrong control block layout and audio issues because
> the cyclic DMA callback wasn't executing on period boundaries.
>
> Fix this by adding the missing total_len update.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Matthias Reichl <hias@horus.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Martin Sperl <kernel@martin.sperl.org>,
Clive Messer <clive.messer@digitaldreamtime.co.uk>,
dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] dmaengine: bcm2835: Fix cyclic DMA period splitting
Date: Wed, 22 Feb 2017 08:11:41 +0530 [thread overview]
Message-ID: <20170222024140.GV2843@localhost> (raw)
In-Reply-To: <20170220190115.GB4170@camel2.lan>
On Mon, Feb 20, 2017 at 08:01:16PM +0100, Matthias Reichl wrote:
> The code responsible for splitting periods into chunks that
> can be handled by the DMA controller missed to update total_len,
> the number of bytes processed in the current period, when there
> are more chunks to follow.
>
> Therefore total_len was stuck at 0 and the code didn't work at all.
> This resulted in a wrong control block layout and audio issues because
> the cyclic DMA callback wasn't executing on period boundaries.
>
> Fix this by adding the missing total_len update.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2017-02-22 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 19:01 [RESEND PATCH] dmaengine: bcm2835: Fix cyclic DMA period splitting Matthias Reichl
2017-02-20 19:01 ` Matthias Reichl
2017-02-22 2:41 ` Vinod Koul [this message]
2017-02-22 2:41 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222024140.GV2843@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.