* [bug report] ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk
@ 2017-02-22 18:46 Dan Carpenter
2017-02-22 21:10 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-02-22 18:46 UTC (permalink / raw)
Cc: Detlef Urban, alsa-devel
Hello Detlef Urban,
This is a semi-automatic email about new static checker warnings.
The patch d2bb390a2081: "ALSA: usb-audio: Tascam US-16x08 DSP mixer
quirk" from Feb 20, 2017, leads to the following Smatch complaint:
sound/usb/mixer_us16x08.c:716 snd_us16x08_meter_get()
warn: variable dereferenced before check 'elem' (see line 711)
sound/usb/mixer_us16x08.c
710 struct usb_mixer_elem_info *elem = kcontrol->private_data;
711 struct snd_usb_audio *chip = elem->head.mixer->chip;
^^^^^^^^^^^^^^^^^^^^^^
Dereference.
712 struct snd_us16x08_meter_store *store = elem->private_data;
713 u8 meter_urb[64];
714 char tmp[max(sizeof(mix_init_msg1), sizeof(mix_init_msg2))];
715
716 if (elem) {
^^^^
Check.
717 store = (struct snd_us16x08_meter_store *) elem->private_data;
718 chip = elem->head.mixer->chip;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk
2017-02-22 18:46 [bug report] ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk Dan Carpenter
@ 2017-02-22 21:10 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-02-22 21:10 UTC (permalink / raw)
To: Dan Carpenter; +Cc: onkel, alsa-devel
On Wed, 22 Feb 2017 19:46:49 +0100,
Dan Carpenter wrote:
>
> Hello Detlef Urban,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch d2bb390a2081: "ALSA: usb-audio: Tascam US-16x08 DSP mixer
> quirk" from Feb 20, 2017, leads to the following Smatch complaint:
>
> sound/usb/mixer_us16x08.c:716 snd_us16x08_meter_get()
> warn: variable dereferenced before check 'elem' (see line 711)
>
> sound/usb/mixer_us16x08.c
> 710 struct usb_mixer_elem_info *elem = kcontrol->private_data;
> 711 struct snd_usb_audio *chip = elem->head.mixer->chip;
> ^^^^^^^^^^^^^^^^^^^^^^
> Dereference.
>
> 712 struct snd_us16x08_meter_store *store = elem->private_data;
> 713 u8 meter_urb[64];
> 714 char tmp[max(sizeof(mix_init_msg1), sizeof(mix_init_msg2))];
> 715
> 716 if (elem) {
> ^^^^
> Check.
>
> 717 store = (struct snd_us16x08_meter_store *) elem->private_data;
> 718 chip = elem->head.mixer->chip;
Thanks for the report.
The buggy part was already removed in the later patch.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-22 21:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-22 18:46 [bug report] ALSA: usb-audio: Tascam US-16x08 DSP mixer quirk Dan Carpenter
2017-02-22 21:10 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.