From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 00/10] try to reduce fragmenting fallbacks
Date: Thu, 23 Feb 2017 16:01:19 +0000 [thread overview]
Message-ID: <20170223160119.crigcfmfzphxirh6@techsingularity.net> (raw)
In-Reply-To: <19bcb38a-5dde-24d5-cf1d-50683d5ef4d9@suse.cz>
On Mon, Feb 20, 2017 at 01:30:33PM +0100, Vlastimil Babka wrote:
> On 02/13/2017 12:07 PM, Mel Gorman wrote:
> > On Fri, Feb 10, 2017 at 06:23:33PM +0100, Vlastimil Babka wrote:
> >
> > By and large, I like the series, particularly patches 7 and 8. I cannot
> > make up my mind about the RFC patches 9 and 10 yet. Conceptually they
> > seem sound but they are much more far reaching than the rest of the
> > series.
> >
> > It would be nice if patches 1-8 could be treated in isolation with data
> > on the number of extfrag events triggered, time spent in compaction and
> > the success rate. Patches 9 and 10 are tricy enough that they would need
> > data per patch where as patches 1-8 should be ok with data gathered for
> > the whole series.
>
> Ok let's try again with a fresh subthread after fixing automation and
> postprocessing...
>
> <SNIP>
>
> To sum up, patches 1-8 look OK to me. Patch 9 looks also very promising, but
> there's danger of increased allocation latencies due to the forced compaction.
> Patch 10 has either implementation bugs or there's some unforeseen consequence
> of its design.
>
I don't have anything useful to add other than the figures for patches
1-8 look good and the fact that fragmenting events that misplace unmovable
allocations is welcome.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 00/10] try to reduce fragmenting fallbacks
Date: Thu, 23 Feb 2017 16:01:19 +0000 [thread overview]
Message-ID: <20170223160119.crigcfmfzphxirh6@techsingularity.net> (raw)
In-Reply-To: <19bcb38a-5dde-24d5-cf1d-50683d5ef4d9@suse.cz>
On Mon, Feb 20, 2017 at 01:30:33PM +0100, Vlastimil Babka wrote:
> On 02/13/2017 12:07 PM, Mel Gorman wrote:
> > On Fri, Feb 10, 2017 at 06:23:33PM +0100, Vlastimil Babka wrote:
> >
> > By and large, I like the series, particularly patches 7 and 8. I cannot
> > make up my mind about the RFC patches 9 and 10 yet. Conceptually they
> > seem sound but they are much more far reaching than the rest of the
> > series.
> >
> > It would be nice if patches 1-8 could be treated in isolation with data
> > on the number of extfrag events triggered, time spent in compaction and
> > the success rate. Patches 9 and 10 are tricy enough that they would need
> > data per patch where as patches 1-8 should be ok with data gathered for
> > the whole series.
>
> Ok let's try again with a fresh subthread after fixing automation and
> postprocessing...
>
> <SNIP>
>
> To sum up, patches 1-8 look OK to me. Patch 9 looks also very promising, but
> there's danger of increased allocation latencies due to the forced compaction.
> Patch 10 has either implementation bugs or there's some unforeseen consequence
> of its design.
>
I don't have anything useful to add other than the figures for patches
1-8 look good and the fact that fragmenting events that misplace unmovable
allocations is welcome.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2017-02-23 16:01 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 17:23 [PATCH v2 00/10] try to reduce fragmenting fallbacks Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-10 17:23 ` [PATCH v2 01/10] mm, compaction: reorder fields in struct compact_control Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-13 10:49 ` Mel Gorman
2017-02-13 10:49 ` Mel Gorman
2017-02-14 16:33 ` Johannes Weiner
2017-02-14 16:33 ` Johannes Weiner
2017-02-10 17:23 ` [PATCH v2 02/10] mm, compaction: remove redundant watermark check in compact_finished() Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-13 10:49 ` Mel Gorman
2017-02-13 10:49 ` Mel Gorman
2017-02-14 16:34 ` Johannes Weiner
2017-02-14 16:34 ` Johannes Weiner
2017-02-10 17:23 ` [PATCH v2 03/10] mm, page_alloc: split smallest stolen page in fallback Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-13 10:51 ` Mel Gorman
2017-02-13 10:51 ` Mel Gorman
2017-02-13 10:54 ` Vlastimil Babka
2017-02-13 10:54 ` Vlastimil Babka
2017-02-14 16:59 ` Johannes Weiner
2017-02-14 16:59 ` Johannes Weiner
2017-02-10 17:23 ` [PATCH v2 04/10] mm, page_alloc: count movable pages when stealing from pageblock Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-13 10:53 ` Mel Gorman
2017-02-13 10:53 ` Mel Gorman
2017-02-14 10:07 ` Xishi Qiu
2017-02-14 10:07 ` Xishi Qiu
2017-02-15 10:47 ` Vlastimil Babka
2017-02-15 10:47 ` Vlastimil Babka
2017-02-15 11:56 ` Xishi Qiu
2017-02-15 11:56 ` Xishi Qiu
2017-02-17 16:21 ` Vlastimil Babka
2017-02-17 16:21 ` Vlastimil Babka
2017-02-14 18:10 ` Johannes Weiner
2017-02-14 18:10 ` Johannes Weiner
2017-02-17 16:09 ` Vlastimil Babka
2017-02-17 16:09 ` Vlastimil Babka
2017-02-10 17:23 ` [PATCH v2 05/10] mm, compaction: change migrate_async_suitable() to suitable_migration_source() Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-13 10:53 ` Mel Gorman
2017-02-13 10:53 ` Mel Gorman
2017-02-14 18:12 ` Johannes Weiner
2017-02-14 18:12 ` Johannes Weiner
2017-02-10 17:23 ` [PATCH v2 06/10] mm, compaction: add migratetype to compact_control Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-13 10:53 ` Mel Gorman
2017-02-13 10:53 ` Mel Gorman
2017-02-14 18:15 ` Johannes Weiner
2017-02-14 18:15 ` Johannes Weiner
2017-02-10 17:23 ` [PATCH v2 07/10] mm, compaction: restrict async compaction to pageblocks of same migratetype Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-13 10:56 ` Mel Gorman
2017-02-13 10:56 ` Mel Gorman
2017-02-14 20:10 ` Johannes Weiner
2017-02-14 20:10 ` Johannes Weiner
2017-02-17 16:32 ` Vlastimil Babka
2017-02-17 16:32 ` Vlastimil Babka
2017-02-17 17:39 ` Johannes Weiner
2017-02-17 17:39 ` Johannes Weiner
2017-02-10 17:23 ` [PATCH v2 08/10] mm, compaction: finish whole pageblock to reduce fragmentation Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-13 10:57 ` Mel Gorman
2017-02-13 10:57 ` Mel Gorman
2017-02-16 11:44 ` Johannes Weiner
2017-02-16 11:44 ` Johannes Weiner
2017-02-10 17:23 ` [RFC v2 09/10] mm, page_alloc: disallow migratetype fallback in fastpath Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-02-10 17:23 ` [RFC v2 10/10] mm, page_alloc: introduce MIGRATE_MIXED migratetype Vlastimil Babka
2017-02-10 17:23 ` Vlastimil Babka
2017-03-08 2:16 ` Yisheng Xie
2017-03-08 2:16 ` Yisheng Xie
2017-03-08 7:07 ` Vlastimil Babka
2017-03-08 7:07 ` Vlastimil Babka
2017-03-13 2:16 ` Yisheng Xie
2017-03-13 2:16 ` Yisheng Xie
2017-02-13 11:07 ` [PATCH v2 00/10] try to reduce fragmenting fallbacks Mel Gorman
2017-02-13 11:07 ` Mel Gorman
2017-02-15 14:29 ` Vlastimil Babka
2017-02-15 14:29 ` Vlastimil Babka
2017-02-15 16:11 ` Vlastimil Babka
2017-02-15 16:11 ` Vlastimil Babka
2017-02-15 20:11 ` Vlastimil Babka
2017-02-15 20:11 ` Vlastimil Babka
2017-02-16 15:12 ` Vlastimil Babka
2017-02-16 15:12 ` Vlastimil Babka
2017-02-17 15:24 ` Vlastimil Babka
2017-02-17 15:24 ` Vlastimil Babka
2017-02-20 12:30 ` Vlastimil Babka
2017-02-20 12:30 ` Vlastimil Babka
2017-02-23 16:01 ` Mel Gorman [this message]
2017-02-23 16:01 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223160119.crigcfmfzphxirh6@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.