From: Mark Rutland <mark.rutland@arm.com>
To: Christoffer Dall <cdall@linaro.org>
Cc: marc.zyngier@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [RFC PATCH 00/13] arm64/kvm: use common sysreg definitions
Date: Fri, 24 Feb 2017 12:16:27 +0000 [thread overview]
Message-ID: <20170224121626.GC417@leverpostej> (raw)
In-Reply-To: <20170224101650.GE1409@cbox>
On Fri, Feb 24, 2017 at 11:16:50AM +0100, Christoffer Dall wrote:
> Hi Mark,
>
> On Tue, Jan 31, 2017 at 06:05:38PM +0000, Mark Rutland wrote:
> > Whenever we add new functionality involving new system registers, we need to
> > add sys_reg() definitions so that we can access the registers regardless of
> > whether the toolchain can assemble them. At the same time, we have to add
> > duplicate definitions of the register encodings to KVM's sysreg tables, so that
> > we can handle any configurable traps. This redundancy is unfortunate, and
> > defining the encodings directly in the sysreg tables can make those tables
> > difficult to read.
> >
> > This series attempts to address both of these issues by allowing us to use
> > common sys_reg() mnemonics in <asm/sysreg.h> to initialise KVM's sysreg tables.
> > To that end, this series tries to make <asm/sysreg.h> the canonical location
> > for common sysreg encodings.
> I did not do a full in-depth review, but I really like this overall
> change and the changes to KVM look great to me.
Cool; I'll respin+repost this once rc1's out.
I'll have to prepare a prize for whoever's willing to verify the
encodings. ;)
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 00/13] arm64/kvm: use common sysreg definitions
Date: Fri, 24 Feb 2017 12:16:27 +0000 [thread overview]
Message-ID: <20170224121626.GC417@leverpostej> (raw)
In-Reply-To: <20170224101650.GE1409@cbox>
On Fri, Feb 24, 2017 at 11:16:50AM +0100, Christoffer Dall wrote:
> Hi Mark,
>
> On Tue, Jan 31, 2017 at 06:05:38PM +0000, Mark Rutland wrote:
> > Whenever we add new functionality involving new system registers, we need to
> > add sys_reg() definitions so that we can access the registers regardless of
> > whether the toolchain can assemble them. At the same time, we have to add
> > duplicate definitions of the register encodings to KVM's sysreg tables, so that
> > we can handle any configurable traps. This redundancy is unfortunate, and
> > defining the encodings directly in the sysreg tables can make those tables
> > difficult to read.
> >
> > This series attempts to address both of these issues by allowing us to use
> > common sys_reg() mnemonics in <asm/sysreg.h> to initialise KVM's sysreg tables.
> > To that end, this series tries to make <asm/sysreg.h> the canonical location
> > for common sysreg encodings.
> I did not do a full in-depth review, but I really like this overall
> change and the changes to KVM look great to me.
Cool; I'll respin+repost this once rc1's out.
I'll have to prepare a prize for whoever's willing to verify the
encodings. ;)
Thanks,
Mark.
next prev parent reply other threads:[~2017-02-24 12:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 18:05 [RFC PATCH 00/13] arm64/kvm: use common sysreg definitions Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 01/13] arm64: sysreg: sort by encoding Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 02/13] arm64: sysreg: add debug system registers Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 03/13] arm64: sysreg: add performance monitor registers Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 04/13] arm64: sysreg: subsume GICv3 sysreg definitions Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 05/13] arm64: sysreg: add register encodings used by KVM Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 06/13] arm64: sysreg: add Set/Way sys encodings Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 07/13] arm64: kvm: add SYS_DESC() Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 08/13] arm64: kvm: Use common debug sysreg definitions Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 09/13] arm64: kvm: Use common performance monitor " Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 10/13] arm64: kvm: Use common GICv3 " Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 11/13] arm64: kvm: use common invariant " Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 12/13] arm64: kvm: Use common " Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-01-31 18:05 ` [RFC PATCH 13/13] arm64: kvm: Use common Set/Way sys definitions Mark Rutland
2017-01-31 18:05 ` Mark Rutland
2017-02-24 10:16 ` [RFC PATCH 00/13] arm64/kvm: use common sysreg definitions Christoffer Dall
2017-02-24 10:16 ` Christoffer Dall
2017-02-24 12:16 ` Mark Rutland [this message]
2017-02-24 12:16 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170224121626.GC417@leverpostej \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=cdall@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.