From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path
Date: Sat, 25 Feb 2017 04:11:11 +0000 [thread overview]
Message-ID: <20170225041111.GB4429@mwanda> (raw)
In-Reply-To: <398315856.259038.1487972318815@email.1und1.de>
On Fri, Feb 24, 2017 at 10:38:38PM +0100, Stefan Wahren wrote:
>
> > Dan Carpenter <dan.carpenter@oracle.com> hat am 24. Februar 2017 um 20:57 geschrieben:
> >
> >
> > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote:
> > > Hi Christophe,
> > >
> > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET:
> > > >If 'kzalloc()' fails, we should release resources allocated so far, just as
> > > >done in all other cases in this function.
> > > >
> > > >Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > >---
> > > >Not sure that the error handling path is correct.
> > > >Is 'gdev[0]' freed? Should it be?
> > >
> >
> > Yes, but I already sent a patch to fix this and your leak as well and
> > Greg merged it.
>
> My leak? I'm confused.
The one you're fixing I mean.
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: bcm2835: Fix a memory leak in error handling path
Date: Sat, 25 Feb 2017 07:11:11 +0300 [thread overview]
Message-ID: <20170225041111.GB4429@mwanda> (raw)
In-Reply-To: <398315856.259038.1487972318815@email.1und1.de>
On Fri, Feb 24, 2017 at 10:38:38PM +0100, Stefan Wahren wrote:
>
> > Dan Carpenter <dan.carpenter@oracle.com> hat am 24. Februar 2017 um 20:57 geschrieben:
> >
> >
> > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote:
> > > Hi Christophe,
> > >
> > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET:
> > > >If 'kzalloc()' fails, we should release resources allocated so far, just as
> > > >done in all other cases in this function.
> > > >
> > > >Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > >---
> > > >Not sure that the error handling path is correct.
> > > >Is 'gdev[0]' freed? Should it be?
> > >
> >
> > Yes, but I already sent a patch to fix this and your leak as well and
> > Greg merged it.
>
> My leak? I'm confused.
The one you're fixing I mean.
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: lee@kernel.org, rjui@broadcom.com, linux-media@vger.kernel.org,
eric@anholt.net, kernel-janitors@vger.kernel.org, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org, mchehab@kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
sbranden@broadcom.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
devel@driverdev.osuosl.org, swarren@wwwdotorg.org,
f.fainelli@gmail.com, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path
Date: Sat, 25 Feb 2017 07:11:11 +0300 [thread overview]
Message-ID: <20170225041111.GB4429@mwanda> (raw)
In-Reply-To: <398315856.259038.1487972318815@email.1und1.de>
On Fri, Feb 24, 2017 at 10:38:38PM +0100, Stefan Wahren wrote:
>
> > Dan Carpenter <dan.carpenter@oracle.com> hat am 24. Februar 2017 um 20:57 geschrieben:
> >
> >
> > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote:
> > > Hi Christophe,
> > >
> > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET:
> > > >If 'kzalloc()' fails, we should release resources allocated so far, just as
> > > >done in all other cases in this function.
> > > >
> > > >Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > >---
> > > >Not sure that the error handling path is correct.
> > > >Is 'gdev[0]' freed? Should it be?
> > >
> >
> > Yes, but I already sent a patch to fix this and your leak as well and
> > Greg merged it.
>
> My leak? I'm confused.
The one you're fixing I mean.
next prev parent reply other threads:[~2017-02-25 4:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 10:34 [PATCH] staging: bcm2835: Fix a memory leak in error handling path Christophe JAILLET
2017-02-19 10:34 ` Christophe JAILLET
2017-02-19 10:34 ` Christophe JAILLET
2017-02-24 12:37 ` Stefan Wahren
2017-02-24 12:37 ` Stefan Wahren
2017-02-24 12:37 ` Stefan Wahren
2017-02-24 19:57 ` Dan Carpenter
2017-02-24 19:57 ` Dan Carpenter
2017-02-24 19:57 ` Dan Carpenter
2017-02-24 21:38 ` Stefan Wahren
2017-02-24 21:38 ` Stefan Wahren
2017-02-24 21:38 ` Stefan Wahren
2017-02-25 4:11 ` Dan Carpenter [this message]
2017-02-25 4:11 ` Dan Carpenter
2017-02-25 4:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170225041111.GB4429@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.