All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rask Ingemann Lambertsen <rask@formelder.dk>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: devicetree@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-sunxi@googlegroups.com, Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	Andre Przywara <andre.przywara@arm.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 7/7] arm64: dts: sunxi: add support for the Orange Pi PC 2 board
Date: Sun, 26 Feb 2017 10:19:55 +0100	[thread overview]
Message-ID: <20170226091955.h3f5pgk7elboxqym@localhost> (raw)
In-Reply-To: <20170226011956.53581-8-icenowy@aosc.xyz>

On Sun, Feb 26, 2017 at 09:19:56AM +0800, Icenowy Zheng wrote:
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> new file mode 100644
> index 000000000000..79784cba806c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
[...]
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		pwr_led {
> +			label = "orangepi:green:pwr";
> +			gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>;
> +			default-state = "on";
> +		};
> +
> +		status_led {

IMHO, you don't need the '_led' suffix inside the 'leds' node, and then you
also avoid having underscores in the node names.

> +			label = "orangepi:red:status";
> +			gpios = <&pio 0 20 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +
> +	r_gpio_keys {

Node names should not contain underscores. You can use hyphens instead. See
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html

> +&mmc0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> +	vmmc-supply = <&reg_vcc3v3>;
> +	bus-width = <4>;
> +	cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
> +	cd-inverted;

You should be able to simplify those last two lines to just

cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */

(see the paragraph which begins with "*NOTE* on CD and WP polarity."
in 'Documentation/devicetree/bindings/mmc/mmc.txt'.)

-- 
Rask Ingemann Lambertsen

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: rask@formelder.dk (Rask Ingemann Lambertsen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 7/7] arm64: dts: sunxi: add support for the Orange Pi PC 2 board
Date: Sun, 26 Feb 2017 10:19:55 +0100	[thread overview]
Message-ID: <20170226091955.h3f5pgk7elboxqym@localhost> (raw)
In-Reply-To: <20170226011956.53581-8-icenowy@aosc.xyz>

On Sun, Feb 26, 2017 at 09:19:56AM +0800, Icenowy Zheng wrote:
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> new file mode 100644
> index 000000000000..79784cba806c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
[...]
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		pwr_led {
> +			label = "orangepi:green:pwr";
> +			gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>;
> +			default-state = "on";
> +		};
> +
> +		status_led {

IMHO, you don't need the '_led' suffix inside the 'leds' node, and then you
also avoid having underscores in the node names.

> +			label = "orangepi:red:status";
> +			gpios = <&pio 0 20 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +
> +	r_gpio_keys {

Node names should not contain underscores. You can use hyphens instead. See
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html

> +&mmc0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> +	vmmc-supply = <&reg_vcc3v3>;
> +	bus-width = <4>;
> +	cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
> +	cd-inverted;

You should be able to simplify those last two lines to just

cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */

(see the paragraph which begins with "*NOTE* on CD and WP polarity."
in 'Documentation/devicetree/bindings/mmc/mmc.txt'.)

-- 
Rask Ingemann Lambertsen

WARNING: multiple messages have this Message-ID (diff)
From: Rask Ingemann Lambertsen <rask@formelder.dk>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: devicetree@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-sunxi@googlegroups.com, Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Rob Herring <robh+dt@kernel.org>,
	Andre Przywara <andre.przywara@arm.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 7/7] arm64: dts: sunxi: add support for the Orange Pi PC 2 board
Date: Sun, 26 Feb 2017 10:19:55 +0100	[thread overview]
Message-ID: <20170226091955.h3f5pgk7elboxqym@localhost> (raw)
In-Reply-To: <20170226011956.53581-8-icenowy@aosc.xyz>

On Sun, Feb 26, 2017 at 09:19:56AM +0800, Icenowy Zheng wrote:
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> new file mode 100644
> index 000000000000..79784cba806c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
[...]
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		pwr_led {
> +			label = "orangepi:green:pwr";
> +			gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>;
> +			default-state = "on";
> +		};
> +
> +		status_led {

IMHO, you don't need the '_led' suffix inside the 'leds' node, and then you
also avoid having underscores in the node names.

> +			label = "orangepi:red:status";
> +			gpios = <&pio 0 20 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +
> +	r_gpio_keys {

Node names should not contain underscores. You can use hyphens instead. See
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html

> +&mmc0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> +	vmmc-supply = <&reg_vcc3v3>;
> +	bus-width = <4>;
> +	cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
> +	cd-inverted;

You should be able to simplify those last two lines to just

cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */

(see the paragraph which begins with "*NOTE* on CD and WP polarity."
in 'Documentation/devicetree/bindings/mmc/mmc.txt'.)

-- 
Rask Ingemann Lambertsen

WARNING: multiple messages have this Message-ID (diff)
From: Rask Ingemann Lambertsen <rask@formelder.dk>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Andre Przywara <andre.przywara@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@googlegroups.com, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 7/7] arm64: dts: sunxi: add support for the Orange Pi PC 2 board
Date: Sun, 26 Feb 2017 10:19:55 +0100	[thread overview]
Message-ID: <20170226091955.h3f5pgk7elboxqym@localhost> (raw)
In-Reply-To: <20170226011956.53581-8-icenowy@aosc.xyz>

On Sun, Feb 26, 2017 at 09:19:56AM +0800, Icenowy Zheng wrote:
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
> new file mode 100644
> index 000000000000..79784cba806c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts
[...]
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		pwr_led {
> +			label = "orangepi:green:pwr";
> +			gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>;
> +			default-state = "on";
> +		};
> +
> +		status_led {

IMHO, you don't need the '_led' suffix inside the 'leds' node, and then you
also avoid having underscores in the node names.

> +			label = "orangepi:red:status";
> +			gpios = <&pio 0 20 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +
> +	r_gpio_keys {

Node names should not contain underscores. You can use hyphens instead. See
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html
https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html

> +&mmc0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> +	vmmc-supply = <&reg_vcc3v3>;
> +	bus-width = <4>;
> +	cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */
> +	cd-inverted;

You should be able to simplify those last two lines to just

cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */

(see the paragraph which begins with "*NOTE* on CD and WP polarity."
in 'Documentation/devicetree/bindings/mmc/mmc.txt'.)

-- 
Rask Ingemann Lambertsen

  reply	other threads:[~2017-02-26  9:19 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-26  1:19 [PATCH v5 0/7] Allwinner H5 and Orange Pi PC2 support Icenowy Zheng
2017-02-26  1:19 ` Icenowy Zheng
2017-02-26  1:19 ` Icenowy Zheng
2017-02-26  1:19 ` [PATCH v5 1/7] arm64: allwinner: Kconfig: add essential pinctrl driver for H5 Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-27  8:25   ` Maxime Ripard
2017-02-27  8:25     ` Maxime Ripard
2017-02-27  8:25     ` Maxime Ripard
2017-02-27  8:25     ` Maxime Ripard
2017-02-26  1:19 ` [PATCH v5 2/7] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5 Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  9:52   ` Rask Ingemann Lambertsen
2017-02-26  9:52     ` Rask Ingemann Lambertsen
2017-02-26  9:52     ` Rask Ingemann Lambertsen
2017-02-26  9:52     ` Rask Ingemann Lambertsen
2017-02-26 14:57     ` Icenowy Zheng
2017-02-26 14:57       ` Icenowy Zheng
2017-02-26 14:57       ` Icenowy Zheng
2017-02-27 12:24   ` Maxime Ripard
2017-02-27 12:24     ` Maxime Ripard
2017-02-27 12:24     ` Maxime Ripard
2017-02-27 12:24     ` Maxime Ripard
2017-02-26  1:19 ` [PATCH v5 3/7] clk: sunxi-ng: add support for Allwinner H5 SoC Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19 ` [PATCH v5 4/7] ARM: dts: sun8i: convert H3 dtsi to use new sunxi-h3-h5 binding header Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19 ` [PATCH v5 5/7] arm: dts: sun8i: split Allwinner H3 .dtsi Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  3:46   ` Chen-Yu Tsai
2017-02-26  3:46     ` Chen-Yu Tsai
2017-02-26  3:46     ` Chen-Yu Tsai
2017-02-26  3:46     ` Chen-Yu Tsai
2017-02-27  8:20     ` Marc Zyngier
2017-02-27  8:20       ` Marc Zyngier
2017-02-27  8:20       ` Marc Zyngier
2017-02-27  8:20       ` Marc Zyngier
2017-02-26  1:19 ` [PATCH v5 6/7] arm64: dts: allwinner: add Allwinner H5 .dtsi Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  8:55   ` Rask Ingemann Lambertsen
2017-02-26  8:55     ` Rask Ingemann Lambertsen
2017-02-26  8:55     ` Rask Ingemann Lambertsen
2017-02-26  8:55     ` Rask Ingemann Lambertsen
2017-02-26  9:00     ` Chen-Yu Tsai
2017-02-26  9:00       ` Chen-Yu Tsai
2017-02-26  9:00       ` Chen-Yu Tsai
2017-02-26  9:00       ` Chen-Yu Tsai
2017-02-26 14:54     ` Icenowy Zheng
2017-02-26 14:54       ` Icenowy Zheng
2017-02-26 14:54       ` Icenowy Zheng
2017-02-26  1:19 ` [PATCH v5 7/7] arm64: dts: sunxi: add support for the Orange Pi PC 2 board Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  1:19   ` Icenowy Zheng
2017-02-26  9:19   ` Rask Ingemann Lambertsen [this message]
2017-02-26  9:19     ` Rask Ingemann Lambertsen
2017-02-26  9:19     ` Rask Ingemann Lambertsen
2017-02-26  9:19     ` Rask Ingemann Lambertsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170226091955.h3f5pgk7elboxqym@localhost \
    --to=rask@formelder.dk \
    --cc=andre.przywara@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.xyz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.