From: Keith Busch <keith.busch@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Matias Bjørling" <matias@cnexlabs.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] lightnvm: add generic ocssd detection
Date: Mon, 27 Feb 2017 13:50:17 -0500 [thread overview]
Message-ID: <20170227185016.GC5789@localhost.localdomain> (raw)
In-Reply-To: <108882ac-9f55-e4f5-c04e-244848139db8@grimberg.me>
On Mon, Feb 27, 2017 at 08:35:06PM +0200, Sagi Grimberg wrote:
> > On Sat, Feb 25, 2017 at 08:16:04PM +0100, Matias Bj�rling wrote:
> > > On 02/25/2017 07:21 PM, Christoph Hellwig wrote:
> > > > No way in hell. vs is vendor specific and we absolutely can't overload
> > > > it with any sort of meaning. Get OCSSD support properly standardized and
> > > > add a class code for it. Until then it's individual PCI IDs.
> > > >
> > >
> > > You are right, that is the right way to go, and we are working on it. In the
> > > meantime, there are a couple of reasons I want to do a pragmatic solution:
> >
> > Reasonable reaosons, but that's just not how standard interfaces work.
> > Either you standardize the behaviour and have a standardized trigger
> > for it, or it is vendor specific and needs to be keyed off a specific
> > vendor/device identification.
>
> I agree, I don't see how we're allowed to use vs for that.
>From personal experience, some OEMs will put whatever they want in the
VS region for their rebranded device, making it an unreliable place to
check for a capability.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/2] lightnvm: add generic ocssd detection
Date: Mon, 27 Feb 2017 13:50:17 -0500 [thread overview]
Message-ID: <20170227185016.GC5789@localhost.localdomain> (raw)
In-Reply-To: <108882ac-9f55-e4f5-c04e-244848139db8@grimberg.me>
On Mon, Feb 27, 2017@08:35:06PM +0200, Sagi Grimberg wrote:
> > On Sat, Feb 25, 2017@08:16:04PM +0100, Matias Bj?rling wrote:
> > > On 02/25/2017 07:21 PM, Christoph Hellwig wrote:
> > > > No way in hell. vs is vendor specific and we absolutely can't overload
> > > > it with any sort of meaning. Get OCSSD support properly standardized and
> > > > add a class code for it. Until then it's individual PCI IDs.
> > > >
> > >
> > > You are right, that is the right way to go, and we are working on it. In the
> > > meantime, there are a couple of reasons I want to do a pragmatic solution:
> >
> > Reasonable reaosons, but that's just not how standard interfaces work.
> > Either you standardize the behaviour and have a standardized trigger
> > for it, or it is vendor specific and needs to be keyed off a specific
> > vendor/device identification.
>
> I agree, I don't see how we're allowed to use vs for that.
>From personal experience, some OEMs will put whatever they want in the
VS region for their rebranded device, making it an unreliable place to
check for a capability.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Matias Bjørling" <matias@cnexlabs.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] lightnvm: add generic ocssd detection
Date: Mon, 27 Feb 2017 13:50:17 -0500 [thread overview]
Message-ID: <20170227185016.GC5789@localhost.localdomain> (raw)
In-Reply-To: <108882ac-9f55-e4f5-c04e-244848139db8@grimberg.me>
On Mon, Feb 27, 2017 at 08:35:06PM +0200, Sagi Grimberg wrote:
> > On Sat, Feb 25, 2017 at 08:16:04PM +0100, Matias Bjørling wrote:
> > > On 02/25/2017 07:21 PM, Christoph Hellwig wrote:
> > > > No way in hell. vs is vendor specific and we absolutely can't overload
> > > > it with any sort of meaning. Get OCSSD support properly standardized and
> > > > add a class code for it. Until then it's individual PCI IDs.
> > > >
> > >
> > > You are right, that is the right way to go, and we are working on it. In the
> > > meantime, there are a couple of reasons I want to do a pragmatic solution:
> >
> > Reasonable reaosons, but that's just not how standard interfaces work.
> > Either you standardize the behaviour and have a standardized trigger
> > for it, or it is vendor specific and needs to be keyed off a specific
> > vendor/device identification.
>
> I agree, I don't see how we're allowed to use vs for that.
>From personal experience, some OEMs will put whatever they want in the
VS region for their rebranded device, making it an unreliable place to
check for a capability.
next prev parent reply other threads:[~2017-02-27 18:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 17:16 [PATCH 1/2] lightnvm: add generic ocssd detection Matias Bjørling
2017-02-24 17:16 ` [PATCH 2/2] lightnvm: fix assert fixes and enable checks Matias Bjørling
2017-02-25 18:21 ` [PATCH 1/2] lightnvm: add generic ocssd detection Christoph Hellwig
2017-02-25 18:21 ` Christoph Hellwig
2017-02-25 19:16 ` Matias Bjørling
2017-02-25 19:16 ` Matias Bjørling
2017-02-26 6:47 ` Christoph Hellwig
2017-02-26 6:47 ` Christoph Hellwig
2017-02-26 6:47 ` Christoph Hellwig
2017-02-27 18:35 ` Sagi Grimberg
2017-02-27 18:35 ` Sagi Grimberg
2017-02-27 18:35 ` Sagi Grimberg
2017-02-27 18:50 ` Keith Busch [this message]
2017-02-27 18:50 ` Keith Busch
2017-02-27 18:50 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227185016.GC5789@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=matias@cnexlabs.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.