Re: [Qemu-devel] [PATCH Risu 2/5] risu_reginfo_ppc64le: Remove unused code from PPC64 register comparison

[joserz@linux.vnet.ibm.com]

On Tue, Feb 28, 2017 at 01:43:22PM +0000, Peter Maydell wrote:
> On 27 February 2017 at 19:41, Jose Ricardo Ziviani
> <joserz@linux.vnet.ibm.com> wrote:
> > Signed-off-by: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
> > ---
> >  risu_reginfo_ppc64le.c | 8 --------
> >  1 file changed, 8 deletions(-)
> >
> > diff --git a/risu_reginfo_ppc64le.c b/risu_reginfo_ppc64le.c
> > index e6bc0e0..a76f296 100644
> > --- a/risu_reginfo_ppc64le.c
> > +++ b/risu_reginfo_ppc64le.c
> > @@ -86,14 +86,6 @@ int reginfo_is_eq(struct reginfo *m, struct reginfo *a, ucontext_t *uc)
> >                  m->vrregs.vrregs[i][1] != a->vrregs.vrregs[i][1] ||
> >                  m->vrregs.vrregs[i][2] != a->vrregs.vrregs[i][2] ||
> >                  m->vrregs.vrregs[i][3] != a->vrregs.vrregs[i][3]) {
> > -
> > -            if (uc != NULL && (m->gregs[CCR] & 0x10)) {
> > -                uc->uc_mcontext.v_regs->vrregs[i][0] = a->vrregs.vrregs[i][0];
> > -                uc->uc_mcontext.v_regs->vrregs[i][1] = a->vrregs.vrregs[i][1];
> > -                uc->uc_mcontext.v_regs->vrregs[i][2] = a->vrregs.vrregs[i][2];
> > -                uc->uc_mcontext.v_regs->vrregs[i][3] = a->vrregs.vrregs[i][3];
> > -                return 1;
> > -            }
> >              return 0;
> >          }
> >      }
> > --
> 
> I have a variation on this patch already in my set of refactoring
> patches that I posted last week:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg06152.html

Sorry, I missed that commit. I'll send a v2 with the fix suggested by
Nikunj and without this one.

Thanks Peter

> 
> thanks
> -- PMM
>